Bug 21915: Call reconcile_balance on manual credit creation

[koha.git] / members / mod_debarment.pl

diff --git a/members/mod_debarment.pl b/members/mod_debarment.pl
index 592e134..bc155e5 100755 (executable)
--- a/members/mod_debarment.pl
+++ b/members/mod_debarment.pl
@@ -19,21 +19,29 @@
 
 use Modern::Perl;
 
-use CGI;
+use CGI qw ( -utf8 );
 
 use C4::Auth;
 use Koha::DateUtils;
-use Koha::Borrower::Debarments;
+use Koha::Patron::Debarments;
 
 my $cgi = new CGI;
 
-my ( $loggedinuser, $cookie, $sessionID ) = checkauth( $cgi, 0, { borrowers => 1 }, 'intranet' );
+my ( $loggedinuserid, $cookie, $sessionID ) = checkauth( $cgi, 0, { borrowers => 'edit_borrowers' }, 'intranet' );
 
 my $borrowernumber = $cgi->param('borrowernumber');
 my $action         = $cgi->param('action');
 
+my $logged_in_user = Koha::Patrons->find( { userid => $loggedinuserid } ) or die "Not logged in";
+my $patron         = Koha::Patrons->find($borrowernumber);
+
+# Ideally we should display a warning on the interface if the patron is not allowed
+# to modify a debarment
+# But a librarian is not supposed to hack the system
+$action = '' unless $logged_in_user->can_see_patron_infos( $patron );
+
 if ( $action eq 'del' ) {
-    DelDebarment( $cgi->param('borrower_debarment_id') );
+    DelDebarment( scalar $cgi->param('borrower_debarment_id') );
 } elsif ( $action eq 'add' ) {
     my $expiration = $cgi->param('expiration');
     if ($expiration) {
@@ -44,7 +52,7 @@ if ( $action eq 'del' ) {
     AddDebarment(
         {   borrowernumber => $borrowernumber,
             type           => 'MANUAL',
-            comment        => $cgi->param('comment'),
+            comment        => scalar $cgi->param('comment'),
             expiration     => $expiration,
         }
     );