Bug 16918 (QA Followup) - Add reverse proxy and fix intranet vs opac typo

[koha.git] / misc / cronjobs / cart_to_shelf.pl

diff --git a/misc/cronjobs/cart_to_shelf.pl b/misc/cronjobs/cart_to_shelf.pl
index 5b2b743..965f7dd 100755 (executable)
--- a/misc/cronjobs/cart_to_shelf.pl
+++ b/misc/cronjobs/cart_to_shelf.pl
@@ -4,18 +4,18 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 #-----------------------------------
 
 =head1 NAME
@@ -28,6 +28,9 @@ cart_to_shelf.pl  cron script to set items with location of CART to original she
 use strict;
 use warnings;
 
+use C4::Items qw/ CartToShelf /;
+use C4::Log;
+
 BEGIN {
 
     # find Koha's Perl modules
@@ -43,7 +46,7 @@ my $hours = 0;
 GetOptions( 'h|hours=s' => \$hours, );
 
 my $usage = << 'ENDUSAGE';
-longoverdue.pl : This cron script will set any item of the location CART ( Shelving Cart ) to it's original shelving location
+cart_to_shelf.pl: This cron script will set any item of the location CART ( Shelving Cart ) to it's original shelving location
                  after the given numer of hours has passed.
 
 This script takes the following parameters :
@@ -51,7 +54,7 @@ This script takes the following parameters :
     --hours | -h         The number of hours that need to pass before the location is updated.
 
   examples :
-  $PERL5LIB/misc/cronjobs/cart_to_shelf.pl --hours 24
+  {Koha script directory}/cronjobs/cart_to_shelf.pl --hours 24
     Would make any item that has a location of CART for more than 24 hours change to it's original shelving location.
 
 ENDUSAGE
@@ -61,9 +64,11 @@ unless ($hours) {
     die "ERROR: No --hours (-h) option defined";
 }
 
-my $query =
-"UPDATE items SET location = permanent_location WHERE location = 'CART' AND TIMESTAMPDIFF(HOUR, items.timestamp, NOW() ) > ?";
+cronlogaction();
 
-my $dbh = C4::Context->dbh;
-my $sth = $dbh->prepare($query);
+my $query = "SELECT itemnumber FROM items WHERE location = 'CART' AND TIMESTAMPDIFF(HOUR, items.timestamp, NOW() ) > ?";
+my $sth = C4::Context->dbh->prepare($query);
 $sth->execute($hours);
+while (my ($itemnumber) = $sth->fetchrow_array) {
+    CartToShelf($itemnumber);
+}