Bug 16918 (QA Followup) - Add reverse proxy and fix intranet vs opac typo

[koha.git] / misc / cronjobs / delete_items.pl

diff --git a/misc/cronjobs/delete_items.pl b/misc/cronjobs/delete_items.pl
index c6683ff..78a9b35 100755 (executable)
--- a/misc/cronjobs/delete_items.pl
+++ b/misc/cronjobs/delete_items.pl
@@ -1,7 +1,5 @@
 #! /usr/bin/perl
 
-use warnings;
-use strict;
 use Getopt::Long;
 use C4::Context;
 use C4::Items;
@@ -9,12 +7,10 @@ use C4::Circulation;
 use Modern::Perl;
 use Pod::Usage;
 
-my $VERSION='1.0';
-
 my $dbh = C4::Context->dbh();
 
 my $query = {
-    target_items => q|SELECT itemnumber from items|
+    target_items => q|SELECT itemnumber, biblionumber from items|
 };
 
 my $GLOBAL = {
@@ -23,7 +19,7 @@ my $GLOBAL = {
 };
 
 my $OPTIONS = {
-      criteria => []
+      where => []
     , flags    => {
             verbose   => ''
           , commit    => ''
@@ -34,62 +30,52 @@ my $OPTIONS = {
 };
 
 GetOptions(
-      'criteria=s' => $OPTIONS->{criteria}
+      'where=s'    => $OPTIONS->{where}
     , 'v|verbose'  => sub { $OPTIONS->{flags}->{verbose}   = 1 }
     , 'V|version'  => sub { $OPTIONS->{flags}->{version}   = 1 }
     , 'h|help'     => sub { $OPTIONS->{flags}->{help}      = 1 }
     , 'm|manual'   => sub { $OPTIONS->{flags}->{manual}    = 1 }
     , 'c|commit'   => sub { $OPTIONS->{flags}->{commit}    = 1 } # aka DO-EET!
-    , 'dry-run'    => sub { $OPTIONS->{flags}->{commit}    = 0;
-                            $OPTIONS->{flags}->{verbose}   = 1 }
 );
 
-my @criteria = @{ $OPTIONS->{criteria} };
-
-if( $OPTIONS->{flags}->{version} ) {
-    say "$0 version $VERSION";
-    exit;
-}
+my @where = @{ $OPTIONS->{where} };
 
 pod2usage( -verbose => 2 ) if  $OPTIONS->{flags}->{manual};
-pod2usage(1) if ( $OPTIONS->{flags}->{help} || scalar @criteria == 0 );
-
-
-
+pod2usage( -verbose => 1 ) if  $OPTIONS->{flags}->{help};
+pod2usage( -verbose => 1 -msg => 'You must supply at least one --where option' ) if scalar @where == 0;
 
 sub verbose {
     say @_ if $OPTIONS->{flags}->{verbose};
 }
 
-
-my $where_clause = ' where ' . join ( " and ", @criteria );
+my $where_clause = ' where ' . join ( " and ", @where );
 
 verbose "Where statement: $where_clause";
 
-$GLOBAL->{sth}->{target_tiems} = $dbh->prepare( $query->{target_items} . $where_clause  );
-$GLOBAL->{sth}->{target_tiems}->execute();
+$GLOBAL->{sth}->{target_items} = $dbh->prepare( $query->{target_items} . $where_clause  );
+$GLOBAL->{sth}->{target_items}->execute();
+
+DELITEM: while ( my $item = $GLOBAL->{sth}->{target_items}->fetchrow_hashref() ) {
 
-DELITEM: while ( my $item = $GLOBAL->{sth}->{target_tiems}->fetchrow_hashref() ) {
-    my $issue = GetOpenIssue( $item->{itemnumber} );
-    if( defined $issue ) {
-        verbose "Cannot delete '$item->{itemnumber}' -- item is checked out."
+    my $status = C4::Items::ItemSafeToDelete( $item->{biblionumber}, $item->{itemnumber} );
+    if( $status eq '1' )  {
+        C4::Items::DelItemCheck( $item->{biblionumber}, $item->{itemnumber} )
+            if $OPTIONS->{flags}->{commit};
+        verbose "Deleting '$item->{itemnumber}'";
     } else {
-        verbose "Deleting '$item->{itemnumber}' ";
-        C4::Items::DelItem( { itemnumber => $item->{itemnumber} } ) if $OPTIONS->{flags}->{commit} ;
+        verbose "Item '$item->{itemnumber}' not deletd: $status";
     }
 }
 
 =head1 NAME
 
- delete_items.pl - A batch item deletion tool, which generates a query against
-                   the items database and deletes the items matching the
-                   criteria specified in the command line arguments.
+delete_items.pl - A batch item deletion tool, which generates a query against the items database and deletes the items matching the criteria specified in the command line arguments.
 
 =head1 SYNOPSIS
 
-delete_items.pl [--help|--manual|--version]
+delete_items.pl [--help|--manual]
 
-delete_items.pl [--verbose] [--dry-run] --criteria "I<SQL CONDITIONAL EXPRESSION>" ... [--commit]
+delete_items.pl [--verbose] --where "I<SQL CONDITIONAL EXPRESSION>" ... [--commit]
 
 =cut
 
@@ -105,18 +91,14 @@ Show the brief help information.
 
 Read the manual, with examples.
 
-=item B<--version>
-
-Show the version number and exit.
-
 =item B<--verbose>
 
-Send the "WHERE" clause generated by the collected C<--criteria>
+Send the "WHERE" clause generated by the collected C<--where>
 arguments, as well as items affected to Standard Out.
 
-=item B<--criteria>
+=item B<--where>
 
-The C<--criteria> option may called multiple times. The following argument
+The C<--where> option may called multiple times. The following argument
 must be a syntactically valid SQL statement which is part of the C<WHERE>
 clause querying the items table. These are joined by C<AND>.
 
@@ -124,10 +106,6 @@ clause querying the items table. These are joined by C<AND>.
 
 No items will be deleted unless the C<--commit> flag is present.
 
-=item B<--dry-run>
-
-Disables C<--commit> flag and enables C<--verbose> flag.
-
 =back
 
 =cut
@@ -137,9 +115,9 @@ Disables C<--commit> flag and enables C<--verbose> flag.
 
   The following is an example of this script:
 
- delete_items.pl --criteria "items.withdrawn ! 0"  --criteria "items.withdrawn_on < $(date --date="13 month ago" --rfc-3339=date)" --commit
+ delete_items.pl --where "items.withdrawn ! 0"  --where "items.withdrawn_on < $(date --date="13 month ago" --rfc-3339=date)" --commit
 
- delete_items.pl --criteria "itemlost >= '1'" --criteria "itemlost <='4'" --criteria "itemlost_on < '2014-04-28'" --commit
+ delete_items.pl --where "itemlost >= '1'" --where "itemlost <='4'" --where "itemlost_on < '2014-04-28'" --commit
 
 =cut