Bug 13531 - Follow up

[koha.git] / misc / migration_tools / remove_unused_authorities.pl

diff --git a/misc/migration_tools/remove_unused_authorities.pl b/misc/migration_tools/remove_unused_authorities.pl
index fbeee78..28c651f 100755 (executable)
--- a/misc/migration_tools/remove_unused_authorities.pl
+++ b/misc/migration_tools/remove_unused_authorities.pl
@@ -27,12 +27,13 @@ use C4::Context;
 use C4::AuthoritiesMarc;
 use Getopt::Long;
 
-my ($test,@authtypes);
+my @authtypes;
 my $want_help = 0;
+my $test = 0;
 GetOptions(
-    'aut|authtypecode:s'    => \@authtypes,
-    't'    => \$test,
-    'h|help'        => \$want_help
+    'aut|authtypecode:s' => \@authtypes,
+    't|test'             => \$test,
+    'h|help'             => \$want_help
 );
 
 if ($want_help) {
@@ -40,17 +41,18 @@ if ($want_help) {
     exit 0;
 }
 
+if ($test) {
+    print "testing only, authorities will not be deleted.\n";
+}
+
 my $dbh=C4::Context->dbh;
-@authtypes or @authtypes = qw( NC );
 my $thresholdmin=0;
 my $thresholdmax=0;
 my @results;
 # prepare the request to retrieve all authorities of the requested types
-my $rqselect = $dbh->prepare(
-    qq{SELECT * from auth_header where authtypecode IN (}
-    . join(",",map{$dbh->quote($_)}@authtypes)
-    . ")"
-);
+my $rqsql = "SELECT * from auth_header where 1";
+$rqsql .= " AND authtypecode IN (".join(",",map{$dbh->quote($_)}@authtypes).")" if @authtypes;
+my $rqselect = $dbh->prepare($rqsql);
 $|=1;
 
 $rqselect->execute;
@@ -82,13 +84,22 @@ print "$counter authorities parsed, $totdeleted deleted and $totundeleted unchan
 
 sub print_usage {
     print <<_USAGE_;
-$0: Removes unused authorities.
+$0: Remove unused authority records
+
+This script removes authority records that do not have any biblio
+records attached to them.
+
+If the --aut option is supplied, only authority records of that
+particular type will be checked for usage.  --aut can be repeated.
+
+If --aut is not supplied, all authority records will be checked.
+
+Use --test to perform a test run.  This script does not ask the
+operator to confirm the deletion of each authority record.
 
-This script will parse all authoritiestypes given as parameter, and remove authorities without any biblio attached.
-warning : there is no individual confirmation !
 parameters
     --aut|authtypecode TYPE       the list of authtypes to check
-    --t|test                      test mode, don't delete really, just count
+    --test or -t                  test mode, don't delete really, just count
     --help or -h                  show this message.
 
 _USAGE_