use strict;
use warnings;
-use CGI;
+use CGI qw ( -utf8 );
use C4::Auth; # checkauth, getborrowernumber.
use C4::Koha;
use C4::Circulation;
use C4::Overdues;
use C4::Debug;
use Koha::DateUtils;
+use Koha::Borrower::Debarments qw(IsDebarred);
use Date::Calc qw/Today Date_to_Days/;
# use Data::Dumper;
# holdingbranch, force the value $rank and $found.
my $rank = $biblioData->{rank};
if ( $itemNum ne '' ) {
- $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum );
+ $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum ) eq 'OK';
$rank = '0' unless C4::Context->preference('ReservesNeedReturns');
my $item = GetItem($itemNum);
if ( $item->{'holdingbranch'} eq $branch ) {
}
}
else {
- $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum );
+ $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum ) eq 'OK';
# Inserts a null into the 'itemnumber' field of 'reserves' table.
$itemNum = undef;
lost => 1
);
}
-if ( $borr->{'debarred'} ) {
+if ( IsDebarred($borrowernumber) ) {
$noreserves = 1;
$template->param(
message => 1,
$biblioLoopIter{itemLoop} = [];
my $numCopiesAvailable = 0;
+ my $numCopiesOPACAvailable = 0;
foreach my $itemInfo (@{$biblioData->{itemInfos}}) {
my $itemNum = $itemInfo->{itemnumber};
my $itemLoopIter = {};
my $branch = GetReservesControlBranch( $itemInfo, $borr );
- my $branchitemrule = GetBranchItemRule( $branch, $itemInfo->{'itype'} );
- my $policy_holdallowed = 1;
-
- if ( $branchitemrule->{'holdallowed'} == 0 ||
- ( $branchitemrule->{'holdallowed'} == 1 && $borr->{'branchcode'} ne $itemInfo->{'homebranch'} ) ) {
- $policy_holdallowed = 0;
+ my $policy_holdallowed = !$itemLoopIter->{already_reserved};
+ if ($policy_holdallowed) {
+ if (my $branchitemrule = GetBranchItemRule( $branch, $itemInfo->{'itype'} )) {
+ $policy_holdallowed =
+ ($branchitemrule->{'holdallowed'} == 2) ||
+ ($branchitemrule->{'holdallowed'} == 1
+ && $borr->{'branchcode'} eq $itemInfo->{'homebranch'});
+ } else {
+ $policy_holdallowed = 0; # No rule - not allowed
+ }
}
-
- if (IsAvailableForItemLevelRequest($itemNum) and $policy_holdallowed and CanItemBeReserved($borrowernumber,$itemNum) and ($itemLoopIter->{already_reserved} ne 1)) {
- $itemLoopIter->{available} = 1;
+ $policy_holdallowed &&=
+ IsAvailableForItemLevelRequest($itemInfo,$borr) &&
+ CanItemBeReserved($borrowernumber,$itemNum) eq 'OK';
+
+ if ($policy_holdallowed) {
+ if ( my $hold_allowed = OPACItemHoldsAllowed( $itemInfo, $borr ) ) {
+ $itemLoopIter->{available} = 1;
+ $numCopiesOPACAvailable++;
+ $biblioLoopIter{force_hold} = 1 if $hold_allowed eq 'F';
+ }
$numCopiesAvailable++;
}
$numBibsAvailable++;
$biblioLoopIter{bib_available} = 1;
$biblioLoopIter{holdable} = 1;
+ $biblioLoopIter{itemholdable} = 1 if $numCopiesOPACAvailable;
}
if ($biblioLoopIter{already_reserved}) {
$biblioLoopIter{holdable} = undef;
- }
- if(not CanBookBeReserved($borrowernumber,$biblioNum)){
- $biblioLoopIter{holdable} = undef;
+ $biblioLoopIter{itemholdable} = undef;
}
if(not C4::Context->preference('AllowHoldsOnPatronsPossessions') and CheckIfIssuedToPatron($borrowernumber,$biblioNum)) {
$biblioLoopIter{holdable} = undef;
$biblioLoopIter{already_patron_possession} = 1;
}
- if( $biblioLoopIter{holdable} ){ $anyholdable++; }
+ $biblioLoopIter{holdable} &&= CanBookBeReserved($borrowernumber,$biblioNum) eq 'OK';
push @$biblioLoop, \%biblioLoopIter;
+
+ $anyholdable = 1 if $biblioLoopIter{holdable};
}
if ( $numBibsAvailable == 0 || $anyholdable == 0) {
# display infos
$template->param(bibitemloop => $biblioLoop);
-$template->param( showholds=>$show_holds_count);
-$template->param( showpriority=>$show_priority);
# can set reserve date in future
if (
C4::Context->preference( 'AllowHoldDateInFuture' ) &&