$template->param( branch => $branch );
# make branch selection options...
-my $CGIbranchloop = GetBranchesLoop($branch);
-$template->param( CGIbranch => $CGIbranchloop );
+my $branchloop = GetBranchesLoop($branch);
# Is the person allowed to choose their branch
my $OPACChooseBranch = (C4::Context->preference("OPACAllowUserToChooseBranch")) ? 1 : 0;
$itemInfoHash{$itemInfo->{itemnumber}} = $itemInfo;
}
- if ($show_holds_count) {
- # Compute the priority rank.
- my ( $rank, $reserves ) = GetReservesFromBiblionumber($biblioNumber,1);
- $biblioData->{reservecount} = 1; # new reserve
- foreach my $res (@$reserves) {
- my $found = $res->{'found'};
- if ( $found && ($found eq 'W') ) {
- $rank--;
- }
- else {
- $biblioData->{reservecount}++;
- }
+ # Compute the priority rank.
+ my ( $rank, $reserves ) =
+ GetReservesFromBiblionumber( $biblioNumber, 1 );
+ $biblioData->{reservecount} = 1; # new reserve
+ foreach my $res (@{$reserves}) {
+ my $found = $res->{found};
+ if ( $found && $found eq 'W' ) {
+ $rank--;
+ }
+ else {
+ $biblioData->{reservecount}++;
}
- $rank++;
- $biblioData->{rank} = $rank;
}
+ $biblioData->{rank} = $rank + 1;
}
#
#
#
if ( $query->param('place_reserve') ) {
- my $notes = $query->param('notes');
- my $canreserve=0;
+ my $reserve_cnt = 0;
+ if ($MAXIMUM_NUMBER_OF_RESERVES) {
+ $reserve_cnt = GetReservesFromBorrowernumber( $borrowernumber );
+ }
# List is composed of alternating biblio/item/branch
my $selectedItems = $query->param('selecteditems');
while (@selectedItems) {
my $biblioNum = shift(@selectedItems);
my $itemNum = shift(@selectedItems);
- my $branch = shift(@selectedItems); # i.e., branch code, not name
+ my $branch = shift(@selectedItems); # i.e., branch code, not name
+
+ my $canreserve = 0;
my $singleBranchMode = C4::Context->preference("singleBranchMode");
- if ($singleBranchMode || ! $OPACChooseBranch) { # single branch mode or disabled user choosing
+ if ( $singleBranchMode || !$OPACChooseBranch )
+ { # single branch mode or disabled user choosing
$branch = $borr->{'branchcode'};
}
- #item may belong to a host biblio, if yes change biblioNum to hosts bilbionumber
- if ($itemNum ne '') {
- my $hostbiblioNum = GetBiblionumberFromItemnumber($itemNum);
- if ($hostbiblioNum ne $biblioNum) {
- $biblioNum = $hostbiblioNum;
- }
- }
+#item may belong to a host biblio, if yes change biblioNum to hosts bilbionumber
+ if ( $itemNum ne '' ) {
+ my $hostbiblioNum = GetBiblionumberFromItemnumber($itemNum);
+ if ( $hostbiblioNum ne $biblioNum ) {
+ $biblioNum = $hostbiblioNum;
+ }
+ }
my $biblioData = $biblioDataHash{$biblioNum};
my $found;
- # Check for user supplied reserve date
- my $startdate;
- if (
- C4::Context->preference( 'AllowHoldDateInFuture' ) &&
- C4::Context->preference( 'OPACAllowHoldDateInFuture' )
- ) {
- $startdate = $query->param("reserve_date_$biblioNum");
- }
-
- my $expiration_date = $query->param("expiration_date_$biblioNum");
+ # Check for user supplied reserve date
+ my $startdate;
+ if ( C4::Context->preference('AllowHoldDateInFuture')
+ && C4::Context->preference('OPACAllowHoldDateInFuture') )
+ {
+ $startdate = $query->param("reserve_date_$biblioNum");
+ }
+
+ my $expiration_date = $query->param("expiration_date_$biblioNum");
- # If a specific item was selected and the pickup branch is the same as the
- # holdingbranch, force the value $rank and $found.
+ # If a specific item was selected and the pickup branch is the same as the
+ # holdingbranch, force the value $rank and $found.
my $rank = $biblioData->{rank};
- if ($itemNum ne ''){
- $canreserve = 1 if CanItemBeReserved($borrowernumber,$itemNum);
+ if ( $itemNum ne '' ) {
+ $canreserve = 1 if CanItemBeReserved( $borrowernumber, $itemNum );
$rank = '0' unless C4::Context->preference('ReservesNeedReturns');
my $item = GetItem($itemNum);
- if ( $item->{'holdingbranch'} eq $branch ){
- $found = 'W' unless C4::Context->preference('ReservesNeedReturns');
+ if ( $item->{'holdingbranch'} eq $branch ) {
+ $found = 'W'
+ unless C4::Context->preference('ReservesNeedReturns');
}
}
else {
- $canreserve = 1 if CanBookBeReserved($borrowernumber,$biblioNum);
+ $canreserve = 1 if CanBookBeReserved( $borrowernumber, $biblioNum );
+
# Inserts a null into the 'itemnumber' field of 'reserves' table.
$itemNum = undef;
}
+ my $notes = $query->param('notes_'.$biblioNum)||'';
+
+ if ( $MAXIMUM_NUMBER_OF_RESERVES
+ && $reserve_cnt >= $MAXIMUM_NUMBER_OF_RESERVES )
+ {
+ $canreserve = 0;
+ }
# Here we actually do the reserveration. Stage 3.
- AddReserve($branch, $borrowernumber, $biblioNum, 'a', [$biblioNum], $rank, $startdate, $expiration_date, $notes,
- $biblioData->{'title'}, $itemNum, $found) if ($canreserve);
+ if ($canreserve) {
+ AddReserve(
+ $branch, $borrowernumber,
+ $biblioNum, 'a',
+ [$biblioNum], $rank,
+ $startdate, $expiration_date,
+ $notes, $biblioData->{title},
+ $itemNum, $found
+ );
+ ++$reserve_cnt;
+ }
}
print $query->redirect("/cgi-bin/koha/opac-user.pl#opac-user-holds");
$noreserves = 1;
$template->param( too_much_oweing => $amount );
}
-if ( $borr->{gonenoaddress} && ($borr->{gonenoaddress} eq 1) ) {
+if ( $borr->{gonenoaddress} && ($borr->{gonenoaddress} == 1) ) {
$noreserves = 1;
$template->param(
message => 1,
GNA => 1
);
}
-if ( $borr->{lost} && ($borr->{lost} eq 1) ) {
+if ( $borr->{lost} && ($borr->{lost} == 1) ) {
$noreserves = 1;
$template->param(
message => 1,
my $biblioLoop = [];
my $numBibsAvailable = 0;
my $itemdata_enumchron = 0;
-my $anyholdable;
+my $anyholdable = 0;
my $itemLevelTypes = C4::Context->preference('item-level_itypes');
$template->param('item_level_itypes' => $itemLevelTypes);
my $record = GetMarcBiblio($biblioNum);
# Init the bib item with the choices for branch pickup
- my %biblioLoopIter = ( branchChoicesLoop => $CGIbranchloop );
+ my %biblioLoopIter = ( branchloop => $branchloop );
# Get relevant biblio data.
my $biblioData = $biblioDataHash{$biblioNum};
$biblioLoopIter{rank} = $biblioData->{rank};
$biblioLoopIter{reservecount} = $biblioData->{reservecount};
$biblioLoopIter{already_reserved} = $biblioData->{already_reserved};
+ $biblioLoopIter{mandatorynotes}=0; #FIXME: For future use
if (!$itemLevelTypes && $biblioData->{itemtype}) {
$biblioLoopIter{description} = $itemTypes->{$biblioData->{itemtype}}{description};
# If there is no loan, return and transfer, we show a checkbox.
$itemLoopIter->{notforloan} = $itemLoopIter->{notforloan} || 0;
- my $branch = C4::Circulation::_GetCircControlBranch($itemLoopIter, $borr);
+ my $branch = ( C4::Context->preference('ReservesControlBranch') eq 'ItemHomeLibrary' ) ? $itemInfo->{'homebranch'} : $borr->{'branchcode'};
my $branchitemrule = GetBranchItemRule( $branch, $itemInfo->{'itype'} );
my $policy_holdallowed = 1;
$numBibsAvailable++;
$biblioLoopIter{bib_available} = 1;
$biblioLoopIter{holdable} = 1;
- $anyholdable = 1;
}
if ($biblioLoopIter{already_reserved}) {
$biblioLoopIter{holdable} = undef;
- $anyholdable = undef;
}
if(not CanBookBeReserved($borrowernumber,$biblioNum)){
$biblioLoopIter{holdable} = undef;
- $anyholdable = undef;
+ }
+ if(not C4::Context->preference('AllowHoldsOnPatronsPossessions') and CheckIfIssuedToPatron($borrowernumber,$biblioNum)) {
+ $biblioLoopIter{holdable} = undef;
+ $biblioLoopIter{already_patron_possession} = 1;
}
+ if( $biblioLoopIter{holdable} ){ $anyholdable++; }
+
push @$biblioLoop, \%biblioLoopIter;
}
-if ( $numBibsAvailable == 0 || !$anyholdable) {
+if ( $numBibsAvailable == 0 || $anyholdable == 0) {
$template->param( none_available => 1 );
}
-my $itemTableColspan = 7;
+my $itemTableColspan = 8;
if (! $template->{VARS}->{'OPACItemHolds'}) {
$itemTableColspan--;
}
if (! $template->{VARS}->{'singleBranchMode'}) {
$itemTableColspan--;
}
+my $show_notes=C4::Context->preference('OPACShowHoldNotes');
+$template->param(OPACShowHoldNotes=>$show_notes);
+$itemTableColspan-- if !$show_notes;
$template->param(itemtable_colspan => $itemTableColspan);
# display infos
);
}
-$template->param( DHTMLcalendar_dateformat => C4::Dates->DHTMLcalendar() );
-
output_html_with_http_headers $query, $cookie, $template->output;