ffzg/recall_notices.pl: added --interval and --dedup

[koha.git] / opac / opac-review.pl

diff --git a/opac/opac-review.pl b/opac/opac-review.pl
index 52f96e7..86a9848 100755 (executable)
--- a/opac/opac-review.pl
+++ b/opac/opac-review.pl
@@ -4,48 +4,63 @@
 #
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 
-use strict;
-use warnings;
-use CGI;
+use Modern::Perl;
+use CGI qw ( -utf8 );
 use C4::Auth;
 use C4::Koha;
 use C4::Output;
-use C4::Review;
 use C4::Biblio;
 use C4::Scrubber;
 use C4::Debug;
 
+use Koha::Biblios;
+use Koha::DateUtils;
+use Koha::Review;
+use Koha::Reviews;
+
 my $query        = new CGI;
 my $biblionumber = $query->param('biblionumber');
 my $review       = $query->param('review');
+my $reviewid     = $query->param('reviewid');
 my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
     {
-        template_name   => "opac-review.tmpl",
+        template_name   => "opac-review.tt",
         query           => $query,
         type            => "opac",
-        authnotrequired => 1,
+        authnotrequired => ( C4::Context->preference("OpacPublic") ? 1 : 0 ),
     }
 );
 
 # FIXME: need to allow user to delete their own comment(s)
 
-my $biblio = GetBiblioData($biblionumber);
-my $savedreview = getreview($biblionumber,$borrowernumber);
-my ($clean, @errors);
-if (defined $review) {
+my ( $clean, @errors, $savedreview );
+my $biblio = Koha::Biblios->find( $biblionumber );
+
+if( !$biblio ) {
+    push @errors, { nobiblio => 1 };
+} elsif( $reviewid ) { # edit existing one, check on creator
+    $savedreview = Koha::Reviews->search({ reviewid => $reviewid, borrowernumber => $borrowernumber })->next;
+    push @errors, { unauthorized => 1 } if !$savedreview;
+} else { # this check prevents adding multiple comments
+    # FIXME biblionumber, borrowernumber should be a unique key of reviews
+    $savedreview = Koha::Reviews->search({ biblionumber => $biblionumber, borrowernumber => $borrowernumber })->next;
+    $review = $savedreview? $savedreview->review: $review;
+}
+
+if( !@errors && defined $review ) {
        if ($review !~ /\S/) {
                push @errors, {empty=>1};
        } else {
@@ -55,28 +70,38 @@ if (defined $review) {
                } else {
                        if ($clean ne $review) {
                                push @errors, {scrubbed=>$clean};
-                               my $js_ok_review = $clean;
-                               $js_ok_review =~ s/"/&quot;/g;  # probably redundant w/ TMPL ESCAPE=JS
-                               $template->param(clean_review=>$js_ok_review);
-                       }
-                       if ($savedreview) {
-                       updatereview($biblionumber, $borrowernumber, $clean);
-                       } else {
-                       savereview($biblionumber, $borrowernumber, $clean);
                        }
+            if ($savedreview) {
+                $savedreview->set(
+                    {
+                        review        => $clean,
+                        approved      => 0,
+                        datereviewed  => dt_from_string
+                    }
+                )->store;
+            } else {
+                $reviewid = Koha::Review->new(
+                    {   biblionumber   => $biblionumber,
+                        borrowernumber => $borrowernumber,
+                        review         => $clean,
+                        datereviewed   => dt_from_string
+                    }
+                )->store->reviewid;
+            }
                        unless (@errors){ $template->param(WINDOW_CLOSE=>1); }
                }
        }
 }
 (@errors   ) and $template->param(   ERRORS=>\@errors);
 ($cgi_debug) and $template->param(cgi_debug=>1       );
+$review = $clean;
+$review ||= $savedreview->review if $savedreview;
 $template->param(
     'biblionumber'   => $biblionumber,
     'borrowernumber' => $borrowernumber,
-    'review'         => $clean || $savedreview->{'review'},
-       'reviewid'       => $query->param('reviewid') || 0,
-    'title'          => $biblio->{'title'},
+    'review'         => $review,
+    'reviewid'       => $reviewid || 0,
+    'title'          => $biblio->title,
 );
 
 output_html_with_http_headers $query, $cookie, $template->output;
-