bug 5237: Testing renewals on patron barcodes with + signs at the end

[koha.git] / reserve / renewscript.pl

diff --git a/reserve/renewscript.pl b/reserve/renewscript.pl
index daf8c2a..4444e7c 100755 (executable)
--- a/reserve/renewscript.pl
+++ b/reserve/renewscript.pl
@@ -18,15 +18,16 @@
 # WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
 # A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
-
+# You should have received a copy of the GNU General Public License along
+# with Koha; if not, write to the Free Software Foundation, Inc.,
+# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
+use strict;
+use warnings;
 use CGI;
 use C4::Circulation;
 use C4::Auth;
+use URI::Escape;
 use C4::Dates qw/format_date_in_iso/;
-use strict;
 my $input = new CGI;
 
 #Set Up User_env
@@ -38,8 +39,8 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
         query           => $input,
         type            => "intranet",
         authnotrequired => 0,
-        flagsrequired   => { borrowers => 1 },
-        debug           => 1,
+        flagsrequired   => { circulate => 1 },
+        debug           => 0,
     }
 );
 
@@ -47,9 +48,21 @@ my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
 # find items to renew, all items or a selection of items
 #
 
-my @data = $input->param('items[]');
+my @data;
+if ($input->param('renew_all')) {
+    @data = $input->param('all_items[]');
+}
+else {
+    @data = $input->param('items[]');
+}
+
+my @barcodes;
+if ($input->param('return_all')) {
+    @barcodes = $input->param('all_barcodes[]');
+} else {
+    @barcodes = $input->param('barcodes[]');
+}
 
-my @barcodes = $input->param('barcodes[]');
 my $branch=$input->param('branch');
 my $datedue;
 if ($input->param('newduedate')){
@@ -62,10 +75,12 @@ if ($input->param('newduedate')){
 #
 my $cardnumber = $input->param("cardnumber");
 my $borrowernumber = $input->param("borrowernumber");
+my $exemptfine = $input->param("exemptfine") || 0;
+my $override_limit = $input->param("override_limit") || 0;
 my $failedrenews;
 foreach my $itemno (@data) {
     # check status before renewing issue
-       my ($renewokay,$error) = CanBookBeRenewed($borrowernumber,$itemno);
+       my ($renewokay,$error) = CanBookBeRenewed($borrowernumber,$itemno,$override_limit);
     if ($renewokay){
         AddRenewal($borrowernumber,$itemno,$branch,$datedue);
     }
@@ -75,9 +90,9 @@ foreach my $itemno (@data) {
 }
 my $failedreturn;
 foreach my $barcode (@barcodes) {
-    # check status before renewing issue  
+    # check status before renewing issue
    my ( $returned, $messages, $issueinformation, $borrower ) = 
-    AddReturn($barcode,$branch,1);
+    AddReturn($barcode, $branch, $exemptfine);
    $failedreturn.="&failedreturn=$barcode" unless ($returned);
 }
 
@@ -85,6 +100,7 @@ foreach my $barcode (@barcodes) {
 # redirection to the referrer page
 #
 if ($input->param('destination') eq "circ"){
+    $cardnumber = uri_escape($cardnumber);
     print $input->redirect(
         '/cgi-bin/koha/circ/circulation.pl?findborrower='.$cardnumber.$failedrenews.$failedreturn
     );