Bug 20829: Handle non-existent barcode when linking to host item

[koha.git] / rotating_collections / transferCollection.pl

diff --git a/rotating_collections/transferCollection.pl b/rotating_collections/transferCollection.pl
index 39945d5..49b09b3 100755 (executable)
--- a/rotating_collections/transferCollection.pl
+++ b/rotating_collections/transferCollection.pl
@@ -2,83 +2,71 @@
 
 # This file is part of Koha.
 #
-# Koha is free software; you can redistribute it and/or modify it under the
-# terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
-# version.
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
 #
-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY
-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR
-# A PARTICULAR PURPOSE.  See the GNU General Public License for more details.
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
-# You should have received a copy of the GNU General Public License along with
-# Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
-# Suite 330, Boston, MA  02111-1307 USA
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
 #
 
-use strict;
-#use warnings; FIXME - Bug 2505
-require Exporter;
+use Modern::Perl;
 
 use C4::Output;
 use C4::Auth;
 use C4::Context;
 use C4::RotatingCollections;
-use C4::Branch;
 
-use CGI;
+use CGI qw ( -utf8 );
 
 my $query = new CGI;
 
-my $colId = $query->param('colId');
+my $colId    = $query->param('colId');
 my $toBranch = $query->param('toBranch');
 
-my ($template, $loggedinuser, $cookie)
-    = get_template_and_user({template_name => "rotating_collections/transferCollection.tmpl",
-                            query => $query,
-                            type => "intranet",
-                            authnotrequired => 0,
-                            flagsrequired => {parameters => 1},
-                            debug => 1,
-                            });
+my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
+    {
+        template_name   => "rotating_collections/transferCollection.tt",
+        query           => $query,
+        type            => "intranet",
+        authnotrequired => 0,
+        flagsrequired   => { tools => 'rotating_collections' },
+        debug           => 1,
+    }
+);
 
 ## Transfer collection
 my ( $success, $errorCode, $errorMessage );
-if ( $toBranch ) {
-  ( $success, $errorCode, $errorMessage ) = TransferCollection( $colId, $toBranch );
+if ($toBranch) {
+    ( $success, $errorCode, $errorMessage ) =
+      TransferCollection( $colId, $toBranch );
 
-  if ( $success ) {
-    $template->param( transferSuccess => 1 );
-  } else {
-    $template->param( transferFailure => 1,
-                      errorCode => $errorCode,
-                      errorMessage => $errorMessage
-    );
-  }
+    if ($success) {
+        $template->param( transferSuccess => 1 );
+    }
+    else {
+        $template->param(
+            transferFailure => 1,
+            errorCode       => $errorCode,
+            errorMessage    => $errorMessage
+        );
+    }
 }
 
-## Set up the toBranch select options
-my $branches = GetBranches();
-my @branchoptionloop;
-foreach my $br (keys %$branches) {
-  my %branch;
-  $branch{code}=$br;
-  $branch{name}=$branches->{$br}->{'branchname'};
-  push (@branchoptionloop, \%branch);
-}
-    
 ## Get data about collection
-my ( $colId, $colTitle, $colDesc, $colBranchcode ) = GetCollection( $colId );                                
+my ( $colTitle, $colDesc, $colBranchcode );
+( $colId, $colTitle, $colDesc, $colBranchcode ) = GetCollection($colId);
 $template->param(
-                intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
-                intranetstylesheet => C4::Context->preference("intranetstylesheet"),
-                IntranetNav => C4::Context->preference("IntranetNav"),
-                                  
-                colId => $colId,
-                colTitle => $colTitle,
-                colDesc => $colDesc,
-                colBranchcode => $colBranchcode,
-                branchoptionloop => \@branchoptionloop
-                );
-                                                                                                
+    colId            => $colId,
+    colTitle         => $colTitle,
+    colDesc          => $colDesc,
+    colBranchcode    => $colBranchcode,
+);
+
 output_html_with_http_headers $query, $cookie, $template->output;