Bug 14969: Remove C4::Dates from serials/*.pl files

[koha.git] / serials / checkexpiration.pl

diff --git a/serials/checkexpiration.pl b/serials/checkexpiration.pl
index 23e692f..3222e22 100755 (executable)
--- a/serials/checkexpiration.pl
+++ b/serials/checkexpiration.pl
@@ -50,8 +50,9 @@ use C4::Serials; # GetExpirationDate
 use C4::Branch;
 use C4::Output;
 use C4::Context;
-use C4::Dates qw/format_date format_date_in_iso/;
-use Date::Calc qw/Today Date_to_Days/;
+use Koha::DateUtils;
+
+use DateTime;
 
 my $query = new CGI;
 
@@ -69,7 +70,8 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user (
 my $title = $query->param('title');
 my $issn  = $query->param('issn');
 my $branch = $query->param('branch');
-my $date  = format_date_in_iso($query->param('date'));
+my $date = $query->param('date');
+$date = eval { dt_from_string( $query->param('date') ) } if $date;
 
 if ($date) {
     my @subscriptions = SearchSubscriptions({ title => $title, issn => $issn, orderby => 'title' });
@@ -78,20 +80,25 @@ if ($date) {
     foreach my $subscription ( @subscriptions ) {
         my $subscriptionid = $subscription->{'subscriptionid'};
         my $expirationdate = GetExpirationDate($subscriptionid);
+
         $subscription->{expirationdate} = $expirationdate;
+
         next if $expirationdate !~ /\d{4}-\d{2}-\d{2}/; # next if not in ISO format.
+
         next if $subscription->{closed};
-        if (   ( ref $flags->{serials} and $flags->{serials}->{superserials} )
+        if (   !C4::Context->preference("IndependentBranches")
+            or C4::Context->IsSuperLibrarian()
+            or ( ref $flags->{serials} and $flags->{serials}->{superserials} )
             or ( !ref $flags->{serials} and $flags->{serials} == 1 ) )
         {
             $subscription->{cannotedit} = 0;
         }
         next if $subscription->{cannotedit};
-        if ( Date_to_Days(split "-",$expirationdate) < Date_to_Days(split "-",$date) &&
-             Date_to_Days(split "-",$expirationdate) > Date_to_Days(&Today) &&
-             ( !$branch || ($subscription->{'branchcode'} eq $branch) ) ) {
-            $subscription->{expirationdate}=format_date($subscription->{expirationdate});
-            push @subscriptions_loop,$subscription;
+
+        my $expirationdate_dt = dt_from_string( $expirationdate, 'iso' );
+        if (   DateTime->compare( $date, $expirationdate_dt ) == 1
+            && ( !$branch || ( $subscription->{'branchcode'} eq $branch ) ) ) {
+            push @subscriptions_loop, $subscription;
         }
     }
 
@@ -99,38 +106,26 @@ if ($date) {
         title           => $title,
         issn            => $issn,
         numsubscription => scalar @subscriptions_loop,
-        date => format_date($date),
+        date => $date,
         subscriptions_loop => \@subscriptions_loop,
         "BiblioDefaultView".C4::Context->preference("BiblioDefaultView") => 1,
+        searched => 1,
     );
 }
 
 my $branchname;
-my @branches_loop;
-if (   $flags->{superlibrarian}
+my $branches_loop;
+if (  !C4::Context->preference("IndependentBranches")
+    or C4::Context->IsSuperLibrarian()
     or ( ref $flags->{serials}  and $flags->{serials}->{superserials} )
     or ( !ref $flags->{serials} and $flags->{serials} == 1 ) )
 {
-    my $branches = GetBranches();
-    foreach my $b (sort keys %$branches) {
-        my $selected = 0;
-        if( $branch and $branch eq $b ){
-            $selected = 1;
-            $branchname = $branches->{$b}->{branchname};
-        }
-        push @branches_loop, {
-            branchcode => $b,
-            branchname => $branches->{$b}->{branchname},
-            selected   => $selected,
-        };
-    }
+    $branches_loop = C4::Branch::GetBranchesLoop( $branch );
 }
 
 $template->param (
     (uc(C4::Context->preference("marcflavour"))) => 1,
-    branches_loop   => \@branches_loop,
-    branchcode      => $branch,
-    branchname      => $branchname,
+    branches_loop   => $branches_loop,
 );
 
 output_html_with_http_headers $query, $cookie, $template->output;