Bug 15774: Show additional field values in edit form

[koha.git] / serials / checkexpiration.pl

diff --git a/serials/checkexpiration.pl b/serials/checkexpiration.pl
index 11d1714..ae88841 100755 (executable)
--- a/serials/checkexpiration.pl
+++ b/serials/checkexpiration.pl
@@ -42,16 +42,15 @@ The date to filter on.
 
 =cut
 
-use strict;
-use warnings;
+use Modern::Perl;
 use CGI qw ( -utf8 );
 use C4::Auth;
 use C4::Serials; # GetExpirationDate
-use C4::Branch;
 use C4::Output;
 use C4::Context;
-use C4::Dates qw/format_date format_date_in_iso/;
-use Date::Calc qw/Date_to_Days/;
+use Koha::DateUtils;
+
+use DateTime;
 
 my $query = new CGI;
 
@@ -69,7 +68,8 @@ my ( $template, $loggedinuser, $cookie, $flags ) = get_template_and_user (
 my $title = $query->param('title');
 my $issn  = $query->param('issn');
 my $branch = $query->param('branch');
-my $date  = format_date_in_iso($query->param('date'));
+my $date = $query->param('date');
+$date = eval { dt_from_string( scalar $query->param('date') ) } if $date;
 
 if ($date) {
     my @subscriptions = SearchSubscriptions({ title => $title, issn => $issn, orderby => 'title' });
@@ -78,8 +78,11 @@ if ($date) {
     foreach my $subscription ( @subscriptions ) {
         my $subscriptionid = $subscription->{'subscriptionid'};
         my $expirationdate = GetExpirationDate($subscriptionid);
+
         $subscription->{expirationdate} = $expirationdate;
+
         next if $expirationdate !~ /\d{4}-\d{2}-\d{2}/; # next if not in ISO format.
+
         next if $subscription->{closed};
         if (   !C4::Context->preference("IndependentBranches")
             or C4::Context->IsSuperLibrarian()
@@ -89,10 +92,11 @@ if ($date) {
             $subscription->{cannotedit} = 0;
         }
         next if $subscription->{cannotedit};
-        if ( Date_to_Days(split "-",$expirationdate) < Date_to_Days(split "-",$date) &&
-             ( !$branch || ($subscription->{'branchcode'} eq $branch) ) ) {
-            $subscription->{expirationdate}=format_date($subscription->{expirationdate});
-            push @subscriptions_loop,$subscription;
+
+        my $expirationdate_dt = dt_from_string( $expirationdate, 'iso' );
+        if (   DateTime->compare( $date, $expirationdate_dt ) == 1
+            && ( !$branch || ( $subscription->{'branchcode'} eq $branch ) ) ) {
+            push @subscriptions_loop, $subscription;
         }
     }
 
@@ -100,26 +104,26 @@ if ($date) {
         title           => $title,
         issn            => $issn,
         numsubscription => scalar @subscriptions_loop,
-        date => format_date($date),
+        date => $date,
         subscriptions_loop => \@subscriptions_loop,
         "BiblioDefaultView".C4::Context->preference("BiblioDefaultView") => 1,
         searched => 1,
     );
 }
 
-my $branchname;
-my $branches_loop;
+my $can_change_library;;
 if (  !C4::Context->preference("IndependentBranches")
     or C4::Context->IsSuperLibrarian()
     or ( ref $flags->{serials}  and $flags->{serials}->{superserials} )
     or ( !ref $flags->{serials} and $flags->{serials} == 1 ) )
 {
-    $branches_loop = C4::Branch::GetBranchesLoop( $branch );
+    $can_change_library = 1;
 }
 
 $template->param (
     (uc(C4::Context->preference("marcflavour"))) => 1,
-    branches_loop   => $branches_loop,
+    can_change_library => $can_change_library,
+    branch => $branch,
 );
 
 output_html_with_http_headers $query, $cookie, $template->output;