Fixing version number

[koha.git] / serials / claims.pl

diff --git a/serials/claims.pl b/serials/claims.pl
index a96857e..75f78ed 100755 (executable)
--- a/serials/claims.pl
+++ b/serials/claims.pl
@@ -1,6 +1,7 @@
 #!/usr/bin/perl
 
 use strict;
+use warnings;
 use CGI;
 use C4::Auth;
 use C4::Serials;
@@ -20,6 +21,16 @@ my $order = $input->param('order');
 my %supplierlist = GetSuppliersWithLateIssues;
 my @select_supplier;
 
+# open template first (security & userenv set here)
+my ($template, $loggedinuser, $cookie)
+= get_template_and_user({template_name => "serials/claims.tmpl",
+            query => $input,
+            type => "intranet",
+            authnotrequired => 0,
+            flagsrequired => {serials => 'claim_serials'},
+            debug => 1,
+            });
+
 foreach my $supplierid (sort {$supplierlist{$a} cmp $supplierlist{$b} } keys %supplierlist){
         my ($count, @dummy) = GetLateOrMissingIssues($supplierid,"",$order);
         my $counting = $count;
@@ -33,29 +44,31 @@ foreach (keys %$letters){
     push @letters ,{code=>$_,name=> $letters->{$_}};
 }
 
-my $letter=((scalar(@letters)>1)||($letters[0]->{name}||$letters[0]->{code}));
-my ($count2, @missingissues) = GetLateOrMissingIssues($supplierid,$serialid,$order) if $supplierid;
+my $letter=((scalar(@letters)>1) || ($letters[0]->{name}||$letters[0]->{code}));
+my ($count2, @missingissues);
+if ($supplierid) {
+    ($count2, @missingissues) = GetLateOrMissingIssues($supplierid,$serialid,$order);
+}
 
 my $CGIsupplier=CGI::scrolling_list( -name     => 'supplierid',
+                       -id        => 'supplierid',
                        -values   => \@select_supplier,
                        -default  => $supplierid,
                        -labels   => \%supplierlist,
                        -size     => 1,
-                       -multiple => 0 
-            -onChange => 'onchange="submit();"');
+                       -multiple => 0 );
 
 my ($singlesupplier,@supplierinfo);
 if($supplierid){
    (@supplierinfo)=GetBookSeller($supplierid);
 } else { # set up supplierid for the claim links out of main table if all suppliers is chosen
-   for(my $i=0; $i<@missingissues;$i++){
-       $missingissues[$i]->{'supplierid'} = getsupplierbyserialid($missingissues[$i]->{'serialid'});
+   for my $mi (@missingissues){
+       $mi->{supplierid} = getsupplierbyserialid($mi->{serialid});
    }
 }
 
-
 my $preview=0;
-if($op eq 'preview'){
+if($op && $op eq 'preview'){
     $preview = 1;
 }
 
@@ -66,15 +79,6 @@ if ($op eq "send_alert"){
   ### $cntupdate SHOULD be equal to scalar(@$serialnums)
 }
 
-my ($template, $loggedinuser, $cookie)
-= get_template_and_user({template_name => "serials/claims.tmpl",
-                               query => $input,
-                               type => "intranet",
-                               authnotrequired => 0,
-                               flagsrequired => {serials => 1},
-                               debug => 1,
-                               });
-
 $template->param('letters'=>\@letters,'letter'=>$letter);
 $template->param(
         order =>$order,
@@ -88,8 +92,6 @@ $template->param(
         claimletter => $claimletter,
         singlesupplier => $singlesupplier,
         supplierloop => \@supplierinfo,
-        intranetcolorstylesheet => C4::Context->preference("intranetcolorstylesheet"),
-        intranetstylesheet => C4::Context->preference("intranetstylesheet"),
-        IntranetNav => C4::Context->preference("IntranetNav"),
+        dateformat    => C4::Context->preference("dateformat"),
         );
 output_html_with_http_headers $input, $cookie, $template->output;