use C4::Koha;
use C4::Biblio;
use C4::Auth;
-use C4::Dates qw/format_date format_date_in_iso/;
use C4::Acquisition;
use C4::Output;
use C4::Context;
use C4::Serials::Numberpattern;
use C4::Letters;
use Koha::AdditionalField;
+use Koha::DateUtils;
use Carp;
#use Smart::Comments;
my $dbh = C4::Context->dbh;
my $sub_length;
-my @budgets;
# Permission needed if it is a modification : edit_subscription
# Permission needed otherwise (nothing or dup) : create_subscription
sub get_letter_loop {
my ($selected_lettercode) = @_;
+ $selected_lettercode //= '';
my $letters = GetLetters({ module => 'serial' });
return [
map {
my $opacdisplaycount = $query->param('opacdisplaycount');
my $location = $query->param('location');
my $skip_serialseq = $query->param('skip_serialseq');
- my $startdate = format_date_in_iso( $query->param('startdate') );
- my $enddate = format_date_in_iso( $query->param('enddate') );
- my $firstacquidate = format_date_in_iso($query->param('firstacquidate'));
+
+ my $startdate = output_pref( { str => $query->param('startdate'), dateonly => 1, dateformat => 'iso' } );
+ my $enddate = output_pref( { str => $query->param('enddate'), dateonly => 1, dateformat => 'iso' } );
+ my $firstacquidate = output_pref( { str => $query->param('firstacquidate'), dateonly => 1, dateformat => 'iso' } );
+
if(!defined $enddate || $enddate eq '') {
if($subtype eq "issues") {
- $enddate = _guess_enddate($firstacquidate, $periodicity, $numberlength, $weeklength, $monthlength);
+ $enddate = _guess_enddate($firstacquidate, $periodicity, $numberlength, $weeklength, $monthlength)
} else {
- $enddate = _guess_enddate($startdate, $periodicity, $numberlength, $weeklength, $monthlength);
+ $enddate = _guess_enddate($startdate, $periodicity, $numberlength, $weeklength, $monthlength)
}
}
);
my $additional_fields = Koha::AdditionalField->all( { tablename => 'subscription' } );
- my @additional_field_values;
- for my $field ( @$additional_fields ) {
- my $af = Koha::AdditionalField->new({ id => $field->{id} });
- $af->{values} = {
- $subscriptionid => $query->param('additional_field_' . $field->{id})
- } if defined $query->param('additional_field_' . $field->{id});
- $af->insert_values;
- }
+ insert_additional_fields( $additional_fields, $biblionumber, $subscriptionid );
print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
return;
my $aqbooksellerid = $query->param('aqbooksellerid');
my $biblionumber = $query->param('biblionumber');
my $aqbudgetid = $query->param('aqbudgetid');
- my $startdate = format_date_in_iso($query->param('startdate'));
- my $firstacquidate = format_date_in_iso( $query->param('firstacquidate') );
- my $nextacquidate = $query->param('nextacquidate') ?
- format_date_in_iso($query->param('nextacquidate')):
- $firstacquidate;
- my $enddate = format_date_in_iso($query->param('enddate'));
+
+ my $startdate = output_pref( { str => $query->param('startdate'), dateonly => 1, dateformat => 'iso' } );
+ my $enddate = output_pref( { str => $query->param('enddate'), dateonly => 1, dateformat => 'iso' } );
+ my $firstacquidate = output_pref( { str => $query->param('firstacquidate'), dateonly => 1, dateformat => 'iso' } );
+
+ my $nextacquidate = $query->param('nextacquidate');
+ $nextacquidate = $nextacquidate
+ ? output_pref( { str => $nextacquidate, dateonly => 1, dateformat => 'iso' } )
+ : $firstacquidate;
+
my $periodicity = $query->param('frequency');
my $subtype = $query->param('subtype');
);
my $additional_fields = Koha::AdditionalField->all( { tablename => 'subscription' } );
- my @additional_field_values;
+ insert_additional_fields( $additional_fields, $biblionumber, $subscriptionid );
+
+ print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
+ return;
+}
+
+sub insert_additional_fields {
+ my ( $additional_fields, $biblionumber, $subscriptionid ) = @_;
+ my $record = GetMarcBiblio( $biblionumber, 1 );
for my $field ( @$additional_fields ) {
my $af = Koha::AdditionalField->new({ id => $field->{id} })->fetch;
if ( $af->{marcfield} ) {
- my $record = GetMarcBiblio( $biblionumber, 1 );
my ( $field, $subfield ) = split /\$/, $af->{marcfield};
- next unless $field and $subfield;
- my $value = $record->subfield( $field, $subfield );
- $af->{values} = {
- $subscriptionid => $value
- };
+ $af->{values} = undef;
+ if ( $field and $subfield ) {
+ my $value = $record->subfield( $field, $subfield );
+ $af->{values} = {
+ $subscriptionid => $value
+ };
+ }
} else {
$af->{values} = {
$subscriptionid => $query->param('additional_field_' . $field->{id})
- };
+ } if defined $query->param('additional_field_' . $field->{id});
}
$af->insert_values;
}
-
- print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
- return;
}