bug 2893: extend conditions handled by AllowNotForLoanOverride
[koha.git] / serials / subscription-add.pl
index 37a465e..9fd55d1 100755 (executable)
@@ -16,6 +16,8 @@
 # Suite 330, Boston, MA  02111-1307 USA
 
 use strict;
+use warnings;
+
 use CGI;
 use Date::Calc qw(Today Day_of_Year Week_of_Year Add_Delta_Days);
 use C4::Koha;
@@ -32,7 +34,7 @@ use C4::Letters;
 #use Smart::Comments;
 
 my $query = new CGI;
-my $op = $query->param('op');
+my $op = $query->param('op') || '';
 my $dbh = C4::Context->dbh;
 my ($subscriptionid,$auser,$branchcode,$librarian,$cost,$aqbooksellerid, $aqbooksellername,$aqbudgetid, $bookfundid, $startdate, $periodicity,
        $firstacquidate, $dow, $irregularity, $numberpattern, $numberlength, $weeklength, $monthlength, $sublength,
@@ -40,7 +42,7 @@ my ($subscriptionid,$auser,$branchcode,$librarian,$cost,$aqbooksellerid, $aqbook
        $add2,$every2,$whenmorethan2,$setto2,$lastvalue2,$innerloop2,
        $add3,$every3,$whenmorethan3,$setto3,$lastvalue3,$innerloop3,
        $numberingmethod, $status, $biblionumber, 
-       $bibliotitle, $callnumber, $notes, $hemisphere, $letter, $manualhistory,$serialsadditems);
+       $bibliotitle, $callnumber, $notes, $hemisphere, $letter, $manualhistory,$serialsadditems, $location);
 
        my @budgets;
 my ($template, $loggedinuser, $cookie)
@@ -60,19 +62,6 @@ my @subscription_types = (
         ); 
 my @sub_type_data;
 
-my $letters = GetLetters('serial');
-my @letterloop;
-foreach my $thisletter (keys %$letters) {
-    my $selected = 1 if $thisletter eq $letter;
-    my %row =(value => $thisletter,
-                selected => $selected,
-                lettername => $letters->{$thisletter},
-            );
-    push @letterloop, \%row;
-}
-$template->param(letterloop => \@letterloop);
-
-my $subscriptionid;
 my $subs;
 my $firstissuedate;
 my $nextexpected;
@@ -88,6 +77,7 @@ if ($op eq 'mod' || $op eq 'dup' || $op eq 'modsubscription') {
     } 
     $firstissuedate = $subs->{firstacquidate};  # in iso format.
     for (qw(startdate firstacquidate histstartdate enddate histenddate)) {
+        next unless defined $subs->{$_};
        # TODO : Handle date formats properly.
          if ($subs->{$_} eq '0000-00-00') {
             $subs->{$_} = ''
@@ -96,6 +86,7 @@ if ($op eq 'mod' || $op eq 'dup' || $op eq 'modsubscription') {
         }
          }
     $subs->{'letter'}='' unless($subs->{'letter'});
+    letter_loop($subs->{'letter'}, $template);
     $irregularity   = $subs->{'irregularity'};
     $numberpattern  = $subs->{'numberpattern'};
     $nextexpected = GetNextExpected($subscriptionid);
@@ -124,13 +115,13 @@ if ($op eq 'mod' || $op eq 'dup' || $op eq 'modsubscription') {
         }
     
         $template->param($subs);
+        $template->param("dow".$subs->{'dow'} => 1) if defined $subs->{'dow'};
         $template->param(
                     $op => 1,
                     subtype => \@sub_type_data,
                     sublength =>$sublength,
-                    history => ($op eq 'mod' && ($subs->{recievedlist}||$subs->{missinglist}||$subs->{opacnote}||$subs->{librariannote})),
+                    history => ($op eq 'mod' && $subs->{manualhistory} == 1 ),
                     "periodicity".$subs->{'periodicity'} => 1,
-                    "dow".$subs->{'dow'} => 1,
                     "numberpattern".$subs->{'numberpattern'} => 1,
                     firstacquiyear => substr($firstissuedate,0,4),
                     );
@@ -139,13 +130,14 @@ if ($op eq 'mod' || $op eq 'dup' || $op eq 'modsubscription') {
 
 my $onlymine=C4::Context->preference('IndependantBranches') && 
              C4::Context->userenv && 
-             C4::Context->userenv->{flags}!=1 && 
+             C4::Context->userenv->{flags} % 2 !=1 && 
              C4::Context->userenv->{branch};
 my $branches = GetBranches($onlymine);
 my @branchloop;
 for my $thisbranch (sort { $branches->{$a}->{branchname} cmp $branches->{$b}->{branchname} } keys %$branches) {
-    my $selected = 1 if ($thisbranch eq C4::Context->userenv->{'branch'});
-    my $selected = 1 if (defined($subs) && $thisbranch eq $subs->{'branchcode'});
+    my $selected = 0;
+    $selected = 1 if ($thisbranch eq C4::Context->userenv->{'branch'});
+    $selected = 1 if (defined($subs) && $thisbranch eq $subs->{'branchcode'});
     my %row =(value => $thisbranch,
                 selected => $selected,
                 branchname => $branches->{$thisbranch}->{'branchname'},
@@ -161,22 +153,24 @@ $template->param(  'dateformat_' . C4::Context->preference('dateformat') => 1 ,
                 );
 
 if ($op eq 'addsubscription') {
-    my $auser = $query->param('user');
-    my $branchcode = $query->param('branchcode');
-    my $aqbooksellerid = $query->param('aqbooksellerid');
-    my $cost = $query->param('cost');
-    my $aqbudgetid = $query->param('aqbudgetid'); 
-    my $startdate = $query->param('startdate');
-    my $firstacquidate = $query->param('firstacquidate');    
-    my $periodicity = $query->param('periodicity');
-    my $dow = $query->param('dow');
-    my @irregularity = $query->param('irregularity_select');
-    my $numberlength = 0;
-    my $weeklength = 0;
-    my $monthlength = 0;
-    my $numberpattern = $query->param('numbering_pattern');
-    my $sublength = $query->param('sublength');
-    my $subtype = $query->param('subtype');
+    my $auser           = $query->param('user');
+    my $branchcode      = $query->param('branchcode');
+    my $aqbooksellerid  = $query->param('aqbooksellerid');
+    my $cost            = $query->param('cost');
+    my $aqbudgetid      = $query->param('aqbudgetid'); 
+    my $startdate       = $query->param('startdate');
+    my $firstacquidate  = $query->param('firstacquidate');    
+    my $periodicity     = $query->param('periodicity');
+    my $dow             = $query->param('dow');
+    my @irregularity    = $query->param('irregularity_select');
+    my $numberlength    = 0;
+    my $weeklength      = 0;
+    my $monthlength     = 0;
+    my $numberpattern   = $query->param('numbering_pattern');
+    my $sublength       = $query->param('sublength');
+    my $subtype         = $query->param('subtype');
+    my $graceperiod     = $query->param('graceperiod') || 0;
+
     if ($subtype eq 'months'){
         $monthlength = $sublength;
     } elsif ($subtype eq 'weeks'){
@@ -213,6 +207,9 @@ if ($op eq 'addsubscription') {
     # ## BugFIX : hdl doesnot know what innerloops or letter stand for but it seems necessary. So he adds them.
     my $manualhistory = $query->param('manualhist');
     my $serialsadditems = $query->param('serialsadditems');
+       my $staffdisplaycount = $query->param('staffdisplaycount');
+       my $opacdisplaycount = $query->param('opacdisplaycount');
+    my $location = $query->param('location');
        my $subscriptionid = NewSubscription($auser,$branchcode,$aqbooksellerid,$cost,$aqbudgetid,$biblionumber,
                                        $startdate,$periodicity,$dow,$numberlength,$weeklength,$monthlength,
                                        $add1,$every1,$whenmorethan1,$setto1,$lastvalue1,$innerloop1,
@@ -220,7 +217,7 @@ if ($op eq 'addsubscription') {
                                        $add3,$every3,$whenmorethan3,$setto3,$lastvalue3,$innerloop3,
                                        $numberingmethod, $status, $notes,$letter,$firstacquidate,join(",",@irregularity),
                     $numberpattern, $callnumber, $hemisphere,($manualhistory?$manualhistory:0),$internalnotes,
-                    $serialsadditems,
+                    $serialsadditems,$staffdisplaycount,$opacdisplaycount,$graceperiod,$location
                                );
 
     print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
@@ -235,7 +232,9 @@ if ($op eq 'addsubscription') {
     my $biblionumber = $query->param('biblionumber');
     my $aqbudgetid = $query->param('aqbudgetid');
     my $startdate = format_date_in_iso($query->param('startdate'));
-    my $nextacquidate = format_date_in_iso($query->param('nextacquidate'));    
+    my $nextacquidate = $query->param('nextacquidate') ?
+                            format_date_in_iso($query->param('nextacquidate')):
+                            format_date_in_iso($query->param('startdate'));
     my $periodicity = $query->param('periodicity');
     my $dow = $query->param('dow');
     my $sublength = $query->param('sublength');
@@ -285,6 +284,10 @@ if ($op eq 'addsubscription') {
     my $opacnote = $query->param('opacnote');
     my $librariannote = $query->param('librariannote');
     my $history_only = $query->param('history_only');
+       my $staffdisplaycount = $query->param('staffdisplaycount');
+       my $opacdisplaycount = $query->param('opacdisplaycount');
+    my $graceperiod     = $query->param('graceperiod') || 0;
+    my $location = $query->param('location');
        #  If it's  a mod, we need to check the current 'expected' issue, and mod it in the serials table if necessary.
     if ( $nextacquidate ne $nextexpected->{planneddate}->output('iso') ) {
         ModNextExpected($subscriptionid,C4::Dates->new($nextacquidate,'iso'));
@@ -306,7 +309,7 @@ if ($op eq 'addsubscription') {
             $whenmorethan3,   $setto3,       $lastvalue3,     $innerloop3,
             $numberingmethod, $status,       $biblionumber,   $callnumber,
             $notes,           $letter,       $hemisphere,     $manualhistory,$internalnotes,
-            $serialsadditems, $subscriptionid,
+            $serialsadditems, $subscriptionid,$staffdisplaycount,$opacdisplaycount,$graceperiod,$location
         );
     }
     print $query->redirect("/cgi-bin/koha/serials/subscription-detail.pl?subscriptionid=$subscriptionid");
@@ -315,7 +318,7 @@ if ($op eq 'addsubscription') {
         while (@subscription_types) {
            my $sub_type = shift @subscription_types;
            my %row = ( 'name' => $sub_type );
-           if ( $sub_on eq $sub_type ) {
+           if ( defined $sub_on and $sub_on eq $sub_type ) {
             $row{'selected'} = ' selected';
            } else {
             $row{'selected'} = '';
@@ -335,3 +338,19 @@ if ($op eq 'addsubscription') {
     }
        output_html_with_http_headers $query, $cookie, $template->output;
 }
+
+sub letter_loop {
+    my ($selected_letter, $template) = @_;
+    my $letters = GetLetters('serial');
+    my @letterloop;
+    foreach my $thisletter (keys %$letters) {
+        my $selected = $thisletter eq $selected_letter ? 1 : 0;
+        push @letterloop, {
+            value => $thisletter,
+            selected => $selected,
+            lettername => $letters->{$thisletter},
+        };
+    }
+    $template->param(letterloop => \@letterloop) if @letterloop;
+}
+