Bug 22008: Add tests for new constraints

[koha.git] / t / 00-load.t

diff --git a/t/00-load.t b/t/00-load.t
index 88830b3..c45f21a 100644 (file)
--- a/t/00-load.t
+++ b/t/00-load.t
@@ -2,6 +2,8 @@
 
 # This file is part of Koha.
 #
+# Copyright (c) 2016   Mark Tompsett -- is_testable()
+#
 # Koha is free software; you can redistribute it and/or modify it
 # under the terms of the GNU General Public License as published by
 # the Free Software Foundation; either version 3 of the License, or
@@ -20,8 +22,7 @@ use Modern::Perl;
 use Test::More;
 use File::Spec;
 use File::Find;
-use Test::MockModule;
-use DBD::Mock;
+use English qw( -no_match_vars );
 
 =head1 DESCRIPTION
 
@@ -29,14 +30,6 @@ use DBD::Mock;
 
 =cut
 
-# Mock the DB connexion and C4::Context
-my $context = new Test::MockModule('C4::Context');
-$context->mock( '_new_dbh', sub {
-        my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
-          || die "Cannot create handle: $DBI::errstr\n";
-        return $dbh;
-});
-
 # Loop through the C4:: modules
 my $lib = File::Spec->rel2abs('C4');
 find({
@@ -45,10 +38,11 @@ find({
     wanted => sub {
         my $m = $_;
         return unless $m =~ s/[.]pm$//;
+
         $m =~ s{^.*/C4/}{C4/};
         $m =~ s{/}{::}g;
         return if $m =~ /Auth_with_ldap/; # Dont test this, it will fail on use
-        return if $m =~ /SIP/; # SIP modules will not load clean
+        return if $m =~ /SIPServer/; # SIP Server module has old package usage
         use_ok($m) || BAIL_OUT("***** PROBLEMS LOADING FILE '$m'");
     },
 }, $lib);
@@ -64,14 +58,50 @@ find(
             return unless $m =~ s/[.]pm$//;
             $m =~ s{^.*/Koha/}{Koha/};
             $m =~ s{/}{::}g;
-            return if $m =~ /Koha::NorwegianPatronDB/; # uses non-mandatory modules
-            use_ok($m) || BAIL_OUT("***** PROBLEMS LOADING FILE '$m'");
+            if ( is_testable($m) ) {
+                use_ok($m) || BAIL_OUT("***** PROBLEMS LOADING FILE '$m'");
+            }
         },
     },
     $lib
 );
 
+# Optional modules are causing checks to fail
+# This checks for the particular modules to determine
+# if the testing is possible or not.
+#
+# Returns 1 if possible, 0 if not.
+sub is_testable {
+    my ($module_name) = @_;
+    my @needed_module_names;
+    my $return_value = 1;
+    if ( $module_name =~ /Koha::SearchEngine::Elasticsearch::Indexer/xsm ) {
+        @needed_module_names =
+          ( 'Catmandu::Importer::MARC', 'Catmandu::Store::ElasticSearch' );
+    }
+    elsif ( $module_name =~ /Koha::SearchEngine::Elasticsearch::Search/xsm ) {
+        @needed_module_names = ( 'Catmandu::Store::ElasticSearch' );
+    }
+    elsif ( $module_name =~ /Koha::SearchEngine::Elasticsearch/xsm ) {
+        @needed_module_names = ( 'Search::Elasticsearch' );
+    }
+    elsif ( $module_name =~ /^Koha::ExternalContent/xsm ) {
+        @needed_module_names = ( 'WebService::ILS' );
+    }
+    foreach my $current_name (@needed_module_names) {
+        my $relative_pathname = $current_name;
+        $relative_pathname =~ s/::/\//gxsm;
+        $relative_pathname .= '.pm';
+        my $check_result = eval { require "$relative_pathname"; 1; };
+        if ($EVAL_ERROR) {
+            diag(
+"Skipping testing of $module_name, because $current_name is not installed."
+            );
+            $return_value = 0;
+        }
+    }
+    return $return_value;
+}
 
 done_testing();
 
-1;