Bug 19489: Koha::Account::Line->issue method and Unit test

[koha.git] / t / Auth_with_shibboleth.t

diff --git a/t/Auth_with_shibboleth.t b/t/Auth_with_shibboleth.t
index ab03248..9e96178 100644 (file)
--- a/t/Auth_with_shibboleth.t
+++ b/t/Auth_with_shibboleth.t
@@ -28,17 +28,22 @@ use C4::Context;
 
 BEGIN {
     if ( check_install( module => 'Test::DBIx::Class' ) ) {
-        plan tests => 11;
-    } else {
-        plan skip_all => "Need Test::DBIx::Class"
+        plan tests => 17;
+    }
+    else {
+        plan skip_all => "Need Test::DBIx::Class";
     }
 }
 
-use Test::DBIx::Class;
+use Test::DBIx::Class {
+    schema_class => 'Koha::Schema',
+    connect_info => [ 'dbi:SQLite:dbname=:memory:', '', '' ]
+};
 
 # Mock Variables
 my $matchpoint = 'userid';
 my $autocreate = 0;
+my $sync = 0;
 my %mapping    = (
     'userid'       => { 'is' => 'uid' },
     'surname'      => { 'is' => 'sn' },
@@ -63,8 +68,16 @@ $context->mock( 'config', \&mockedConfig );
 
 ### Mock ->preference
 my $OPACBaseURL = "testopac.com";
+my $staffClientBaseURL = "teststaff.com";
 $context->mock( 'preference', \&mockedPref );
 
+### Mock ->tz
+$context->mock( 'timezone', sub { return 'local'; } );
+
+### Mock ->interface
+my $interface = 'opac';
+$context->mock( 'interface', \&mockedInterface );
+
 ## Mock Database
 my $database = new Test::MockModule('Koha::Database');
 
@@ -153,7 +166,7 @@ subtest "get_login_shib tests" => sub {
 
 ## checkpw_shib
 subtest "checkpw_shib tests" => sub {
-    plan tests => 18;
+    plan tests => 21;
 
     my $shib_login;
     my ( $retval, $retcard, $retuserid );
@@ -211,6 +224,22 @@ subtest "checkpw_shib tests" => sub {
       'Found $new_users surname';
     $autocreate = 0;
 
+    # sync user
+    $sync = 1;
+    $ENV{'city'} = 'AnotherCity';
+    warnings_are {
+        ( $retval, $retcard, $retuserid ) = checkpw_shib($shib_login);
+    }
+    [], "good user with sync";
+
+    ok my $sync_user = ResultSet('Borrower')
+      ->search( { 'userid' => 'test4321' }, { rows => 1 } ), "sync user found";
+
+    is_fields [qw/surname dateexpiry address city/], $sync_user->next,
+      [qw/pika 2017 Address AnotherCity/],
+      'Found $sync_user synced city';
+    $sync = 0;
+
     # debug on
     $C4::Auth_with_shibboleth::debug = '1';
 
@@ -247,15 +276,17 @@ subtest "checkpw_shib tests" => sub {
 
 };
 
-## _get_uri
+## _get_uri - opac
 $OPACBaseURL = "testopac.com";
 is( C4::Auth_with_shibboleth::_get_uri(),
     "https://testopac.com", "https opac uri returned" );
 
 $OPACBaseURL = "http://testopac.com";
 my $result;
-warning_like { $result = C4::Auth_with_shibboleth::_get_uri() }
-[qr/Shibboleth requires OPACBaseURL to use the https protocol!/],
+warnings_are { $result = C4::Auth_with_shibboleth::_get_uri() }[
+    "shibboleth interface: $interface",
+"Shibboleth requires OPACBaseURL/staffClientBaseURL to use the https protocol!"
+],
   "improper protocol - received expected warning";
 is( $result, "https://testopac.com", "https opac uri returned" );
 
@@ -264,10 +295,34 @@ is( C4::Auth_with_shibboleth::_get_uri(),
     "https://testopac.com", "https opac uri returned" );
 
 $OPACBaseURL = undef;
-warning_like { $result = C4::Auth_with_shibboleth::_get_uri() }
-[qr/OPACBaseURL not set!/],
+warnings_are { $result = C4::Auth_with_shibboleth::_get_uri() }
+[ "shibboleth interface: $interface", "OPACBaseURL not set!" ],
   "undefined OPACBaseURL - received expected warning";
-is( $result, "https://", "https opac uri returned" );
+is( $result, "https://", "https $interface uri returned" );
+
+## _get_uri - intranet
+$interface = 'intranet';
+$staffClientBaseURL = "teststaff.com";
+is( C4::Auth_with_shibboleth::_get_uri(),
+    "https://teststaff.com", "https $interface uri returned" );
+
+$staffClientBaseURL = "http://teststaff.com";
+warnings_are { $result = C4::Auth_with_shibboleth::_get_uri() }[
+    "shibboleth interface: $interface",
+"Shibboleth requires OPACBaseURL/staffClientBaseURL to use the https protocol!"
+],
+  "improper protocol - received expected warning";
+is( $result, "https://teststaff.com", "https $interface uri returned" );
+
+$staffClientBaseURL = "https://teststaff.com";
+is( C4::Auth_with_shibboleth::_get_uri(),
+    "https://teststaff.com", "https $interface uri returned" );
+
+$staffClientBaseURL = undef;
+warnings_are { $result = C4::Auth_with_shibboleth::_get_uri() }
+[ "shibboleth interface: $interface", "staffClientBaseURL not set!" ],
+  "undefined staffClientBaseURL - received expected warning";
+is( $result, "https://", "https $interface uri returned" );
 
 ## _get_shib_config
 # Internal helper function, covered in tests above
@@ -277,6 +332,7 @@ sub mockedConfig {
 
     my %shibboleth = (
         'autocreate' => $autocreate,
+        'sync'       => $sync,
         'matchpoint' => $matchpoint,
         'mapping'    => \%mapping
     );
@@ -292,9 +348,17 @@ sub mockedPref {
         $return = $OPACBaseURL;
     }
 
+    if ( $param eq 'staffClientBaseURL' ) {
+        $return = $staffClientBaseURL;
+    }
+
     return $return;
 }
 
+sub mockedInterface {
+    return $interface;
+}
+
 sub mockedSchema {
     return Schema();
 }
@@ -303,6 +367,7 @@ sub mockedSchema {
 sub reset_config {
     $matchpoint = 'userid';
     $autocreate = 0;
+    $sync = 0;
     %mapping    = (
         'userid'       => { 'is' => 'uid' },
         'surname'      => { 'is' => 'sn' },
@@ -321,4 +386,3 @@ sub reset_config {
     return 1;
 }
 
-1;