Bug 21832: add unit test

[koha.git] / t / Biblio.t

diff --git a/t/Biblio.t b/t/Biblio.t
index 3217e77..0d140be 100755 (executable)
--- a/t/Biblio.t
+++ b/t/Biblio.t
@@ -17,24 +17,16 @@
 
 use Modern::Perl;
 
-use Test::More tests => 46;
+use Test::More;
 use Test::MockModule;
 use Test::Warn;
-use DBD::Mock;
-
-BEGIN {
-        use_ok('C4::Biblio');
-}
-
-my $context = new Test::MockModule('C4::Context');
-$context->mock(
-    '_new_dbh',
-    sub {
-        my $dbh = DBI->connect( 'DBI:Mock:', '', '' )
-          || die "Cannot create handle: $DBI::errstr\n";
-        return $dbh;
-    }
-);
+
+plan tests => 47;
+
+use_ok('C4::Biblio');
+
+my $db = Test::MockModule->new('Koha::Database');
+$db->mock( _new_schema => sub { return Schema(); } );
 
 my @arr;
 my $ret;
@@ -145,7 +137,7 @@ ok( !defined $ret, 'GetMarcHosts returns undef if not passed rec');
 
 my $hash_ref;
 
-warning_is { $hash_ref = TransformMarcToKoha(undef, undef) }
+warning_is { $hash_ref = TransformMarcToKoha( undef) }
            { carped => 'TransformMarcToKoha called with undefined record'},
            "TransformMarcToKoha returns carped warning on undef record";
 
@@ -168,6 +160,10 @@ warning_is { $ret = RemoveAllNsb() }
 ok( !defined $ret, 'RemoveAllNsb returns undef if not passed rec');
 
 warning_is { $ret = GetMarcBiblio() }
+           { carped => 'GetMarcBiblio called without parameters'},
+           "GetMarcBiblio returns carped warning on no parameters";
+
+warning_is { $ret = GetMarcBiblio({ biblionumber => undef }) }
            { carped => 'GetMarcBiblio called with undefined biblionumber'},
            "GetMarcBiblio returns carped warning on undef biblionumber";
 
@@ -180,4 +176,3 @@ warnings_like { $ret = UpdateTotalIssues() }
 
 ok( !defined $ret, 'UpdateTotalIssues returns carped warning if biblio record does not exist');
 
-1;