Bug 2720 - Overdues which debar automatically should undebar automatically when returned

[koha.git] / t / Letters.t

diff --git a/t/Letters.t b/t/Letters.t
index b269e86..7cbf6c8 100755 (executable)
--- a/t/Letters.t
+++ b/t/Letters.t
@@ -3,15 +3,11 @@
 # This Koha test module is a stub!
 # Add more tests here!!!
 
-use strict;
-use warnings;
+use Modern::Perl;
+use DBI;
 use Test::MockModule;
-use Test::More tests => 2;
-
-BEGIN {
-    use_ok('C4::Letters');
-}
-
+use Test::More tests => 4;
+use t::lib::Mocks;
 my $module = new Test::MockModule('C4::Context');
 $module->mock(
     '_new_dbh',
@@ -27,6 +23,8 @@ my $mock_letters = [
     [ 'bleh',   'ISSN', 'NSSI',       'page', 0,         'blue',  'blehbleh' ]
 ];
 
+use_ok('C4::Letters');
+
 my $dbh = C4::Context->dbh();
 
 $dbh->{mock_add_resultset} = $mock_letters;
@@ -34,3 +32,13 @@ $dbh->{mock_add_resultset} = $mock_letters;
 my $letters = C4::Letters::GetLetters();
 
 is( $letters->{ISBN}, 'book', 'HASH ref of ISBN is book' );
+
+# Regression test for bug 10843
+# $dt->add takes a scalar, not undef
+my $letter;
+t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', undef);
+$letter = C4::Letters::_parseletter( undef, 'reserves', {waitingdate => "2013-01-01"} );
+is( ref($letter), 'HASH');
+t::lib::Mocks::mock_preference('ReservesMaxPickUpDelay', 1);
+$letter = C4::Letters::_parseletter( undef, 'reserves', {waitingdate => "2013-01-01"} );
+is( ref($letter), 'HASH');