Bug 18925: (QA follow-up) Remove weird 'Null' values for integer column

[koha.git] / t / SuggestionEngine_AuthorityFile.t

diff --git a/t/SuggestionEngine_AuthorityFile.t b/t/SuggestionEngine_AuthorityFile.t
index b9ab35b..eab5fb6 100755 (executable)
--- a/t/SuggestionEngine_AuthorityFile.t
+++ b/t/SuggestionEngine_AuthorityFile.t
@@ -1,28 +1,57 @@
 #!/usr/bin/perl
+
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
 #
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
 # This Koha test module uses Test::MockModule to get around the need for known
 # contents in the authority file by returning a single known authority record
 # for every call to SearchAuthorities
 
-use strict;
-use warnings;
+use Modern::Perl;
+
 use File::Spec;
 use MARC::Record;
 
 use Test::More;
 use Test::MockModule;
+use t::lib::Mocks;
+
+use Module::Load::Conditional qw/check_install/;
 
 BEGIN {
-        use_ok('Koha::SuggestionEngine');
+    if ( check_install( module => 'Test::DBIx::Class' ) ) {
+        plan tests => 3;
+    } else {
+        plan skip_all => "Need Test::DBIx::Class"
+    }
 }
 
+# Mock the DB connexion
+use Test::DBIx::Class;
+my $db = Test::MockModule->new('Koha::Database');
+$db->mock( _new_schema => sub { return Schema(); } );
+
+use_ok('Koha::SuggestionEngine');
+
 my $module = new Test::MockModule('C4::AuthoritiesMarc');
 $module->mock('SearchAuthorities', sub {
         return [ { 'authid' => '1234',
                     'reported_tag' => undef,
                     'even' => 0,
                     'summary' => {
-                        'authorized' => [ 'Cooking' ],
+                        'authorized' => [ { 'heading' => 'Cooking' } ],
                         'otherscript' => [],
                         'seefrom' => [ 'Cookery' ],
                         'notes' => [ 'Your quintessential poor heading selection' ],
@@ -33,11 +62,12 @@ $module->mock('SearchAuthorities', sub {
                 } ], 1
 });
 
-my $suggestor = Koha::SuggestionEngine->new( { plugins => ( 'AuthorityFile' ) } );
+my $suggestor = Koha::SuggestionEngine->new( { plugins => [ 'AuthorityFile' ] } );
 is(ref($suggestor), 'Koha::SuggestionEngine', 'Created suggestion engine');
 
 my $result = $suggestor->get_suggestions({search => 'Cookery'});
 
-is_deeply($result, [ { 'search' => 'an=1234', 'relevance' => 1, 'label' => 'Cooking' } ], "Suggested correct alternative to 'Cookery'");
+is_deeply($result, [ { 'search' => 'an:1234', 'relevance' => 1, 'label' => 'Cooking' } ], "Suggested correct alternative to 'Cookery'");
 
 done_testing();
+