Bug 16423: [QA Follow-up] Remove $opac

[koha.git] / t / db_dependent / AudioAlerts.t

diff --git a/t/db_dependent/AudioAlerts.t b/t/db_dependent/AudioAlerts.t
index 3f42885..f7cc825 100755 (executable)
--- a/t/db_dependent/AudioAlerts.t
+++ b/t/db_dependent/AudioAlerts.t
@@ -32,9 +32,8 @@ $dbh->{RaiseError} = 1;
 
 map { $_->delete() } Koha::AudioAlerts->search();
 
-# Check the basics
-diag("Creating 3 audio alerts named a, b and c");
-
+## Check the basics
+# Creating 3 audio alerts named a, b and c
 my $a = Koha::AudioAlert->new( { selector => 'A', sound => 'test.wav' } )->store();
 is( $a->precedence, 1, "First alert has a precedence of 1" );
 
@@ -44,13 +43,14 @@ is( $b->precedence, 2, "Second alert has a precedence of 2" );
 my $c = Koha::AudioAlert->new( { selector => 'C', sound => 'test.ogg' } )->store();
 is( $c->precedence, 3, "Third alert has a precedence of 3" );
 
-# Check precedence getting methods
-diag('Testing get_last_precedence and get_next_precedence');
+## Check precedence getting methods
+# Testing get_last_precedence and get_next_precedence
+
 is( Koha::AudioAlerts->get_last_precedence(), 3, "Last prececence should be 3" );
 is( Koha::AudioAlerts->get_next_precedence(), 4, "Next prececence should be 4" );
 
-# Check edge cases
-diag('Testing edge cases for moving ( up from 1, down from the last precedence )');
+## Check edge cases
+# Testing edge cases for moving ( up from 1, down from the last precedence )
 
 $a->move('up');
 is( $a->precedence, 1, "First alert still has a precedence of 1" );
@@ -58,8 +58,8 @@ is( $a->precedence, 1, "First alert still has a precedence of 1" );
 $c->move('down');
 is( $c->precedence, 3, "Third alert still has a precedence of 3" );
 
-# Check moving
-diag("Moving A down by one");
+## Check moving
+# Moving A down by one
 $a->move('down');
 $a = Koha::AudioAlerts->find( $a->id );
 $b = Koha::AudioAlerts->find( $b->id );
@@ -68,7 +68,7 @@ is( $a->precedence, 2, "Alert A has a precedence of 2" );
 is( $b->precedence, 1, "Alert B has a precedence of 1" );
 is( $c->precedence, 3, "Alert C has a precedence of 3" );
 
-diag("Moving A up by one, should restore original order");
+# Moving A up by one, should restore original order
 $a->move('up');
 $a = Koha::AudioAlerts->find( $a->id );
 $b = Koha::AudioAlerts->find( $b->id );
@@ -77,7 +77,7 @@ is( $a->precedence, 1, "Alert A has a precedence of 1" );
 is( $b->precedence, 2, "Alert B has a precedence of 2" );
 is( $c->precedence, 3, "Alert C has a precedence of 3" );
 
-diag("Moving A to the bottom");
+# Moving A to the bottom
 $a->move('bottom');
 $a = Koha::AudioAlerts->find( $a->id );
 $b = Koha::AudioAlerts->find( $b->id );
@@ -86,7 +86,7 @@ is( $a->precedence, 3, "Alert A has a precedence of 3" );
 is( $b->precedence, 1, "Alert B has a precedence of 1" );
 is( $c->precedence, 2, "Alert C has a precedence of 2" );
 
-diag("Moving A to the top, should restore original order");
+# Moving A to the top, should restore original order
 $a->move('top');
 $a = Koha::AudioAlerts->find( $a->id );
 $b = Koha::AudioAlerts->find( $b->id );
@@ -95,11 +95,11 @@ is( $a->precedence, 1, "Alert A has a precedence of 1" );
 is( $b->precedence, 2, "Alert B has a precedence of 2" );
 is( $c->precedence, 3, "Alert C has a precedence of 3" );
 
-# Test searching, should be ordered by precedence by default
-diag("Test searching, default search should be ordered by precedence");
+## Test searching, should be ordered by precedence by default
+# Test searching, default search should be ordered by precedence
 $a->move('bottom');
-diag("Changed precedence order from database insert order");
-diag("Insert order was a, b, c. Precedence order is now b, c, a.");
+# Changed precedence order from database insert order
+# Insert order was a, b, c. Precedence order is now b, c, a.
 ( $b, $c, $a ) = Koha::AudioAlerts->search();
 
 is( $b->selector,   'B', 'First sound is indeed B' );
@@ -111,8 +111,8 @@ is( $c->precedence, 2,   "Alert C has a precedence of 2" );
 is( $a->selector,   'A', 'Third sound is indeed A' );
 is( $a->precedence, 3,   "Alert A has a precedence of 3" );
 
-# Test fix precedences, should remove gaps in precedences
-diag("Testing precedence fixing. Should remove gaps from precedence list.");
+## Test fix precedences, should remove gaps in precedences
+# Testing precedence fixing. Should remove gaps from precedence list.
 $a->precedence( 0 )->store();
 $b->precedence( 50 )->store();
 $c->precedence( 100 )->store();
@@ -120,7 +120,7 @@ is( $a->precedence, 0, "Alert A has a precedence of 0" );
 is( $b->precedence, 50, "Alert B has a precedence of 50" );
 is( $c->precedence, 100, "Alert C has a precedence of 100" );
 
-diag("Running fix_precedences()");
+# Running fix_precedences()
 Koha::AudioAlerts->fix_precedences();
 $a = Koha::AudioAlerts->find( $a->id );
 $b = Koha::AudioAlerts->find( $b->id );