use Modern::Perl;
-use CGI;
+use CGI qw ( -utf8 );
+
+use Test::MockObject;
use Test::MockModule;
use List::MoreUtils qw/all any none/;
-use Test::More tests => 6;
+use Test::More tests => 21;
+use Test::Warn;
+use t::lib::Mocks;
+use t::lib::TestBuilder;
+
+use C4::Auth qw(checkpw);
use C4::Members;
use Koha::AuthUtils qw/hash_password/;
+use Koha::Database;
+use Koha::Patrons;
BEGIN {
- use_ok('C4::Auth');
+ use_ok('C4::Auth');
}
-my $dbh = C4::Context->dbh;
+my $schema = Koha::Database->schema;
+my $builder = t::lib::TestBuilder->new;
+my $dbh = C4::Context->dbh;
+
+# FIXME: SessionStorage defaults to mysql, but it seems to break transaction
+# handling
+t::lib::Mocks::mock_preference( 'SessionStorage', 'tmp' );
+
+$schema->storage->txn_begin;
+
+subtest 'checkauth() tests' => sub {
+
+ plan tests => 2;
+
+ my $patron = $builder->build({ source => 'Borrower', value => { flags => undef } })->{userid};
+
+ # Mock a CGI object with real userid param
+ my $cgi = Test::MockObject->new();
+ $cgi->mock( 'param', sub { return $patron; } );
+ $cgi->mock( 'cookie', sub { return; } );
+
+ my $authnotrequired = 1;
+ my ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
-# Start transaction
-$dbh->{AutoCommit} = 0;
-$dbh->{RaiseError} = 1;
+ is( $userid, undef, 'checkauth() returns undef for userid if no logged in user (Bug 18275)' );
+ my $db_user_id = C4::Context->config('user');
+ my $db_user_pass = C4::Context->config('pass');
+ $cgi = Test::MockObject->new();
+ $cgi->mock( 'cookie', sub { return; } );
+ $cgi->mock( 'param', sub {
+ my ( $self, $param ) = @_;
+ if ( $param eq 'userid' ) { return $db_user_id; }
+ elsif ( $param eq 'password' ) { return $db_user_pass; }
+ else { return; }
+ });
+ ( $userid, $cookie, $sessionID, $flags ) = C4::Auth::checkauth( $cgi, $authnotrequired );
+ is ( $userid, $db_user_id, 'If DB user is logging in, it should be considered as logged in, i.e. checkauth return the relevant userid' );
+ C4::Context->_new_userenv; # For next tests
+
+};
+
+my $hash1 = hash_password('password');
+my $hash2 = hash_password('password');
+
+{ # tests no_set_userenv parameter
+ my $patron = $builder->build( { source => 'Borrower' } );
+ Koha::Patrons->find( $patron->{borrowernumber} )->update_password( $patron->{userid}, $hash1 );
+ my $library = $builder->build(
+ {
+ source => 'Branch',
+ }
+ );
+
+ ok( checkpw( $dbh, $patron->{userid}, 'password', undef, undef, 1 ), 'checkpw returns true' );
+ is( C4::Context->userenv, undef, 'Userenv should be undef as required' );
+ C4::Context->_new_userenv('DUMMY SESSION');
+ C4::Context->set_userenv(0,0,0,'firstname','surname', $library->{branchcode}, 'Library 1', 0, '', '');
+ is( C4::Context->userenv->{branch}, $library->{branchcode}, 'Userenv gives correct branch' );
+ ok( checkpw( $dbh, $patron->{userid}, 'password', undef, undef, 1 ), 'checkpw returns true' );
+ is( C4::Context->userenv->{branch}, $library->{branchcode}, 'Userenv branch is preserved if no_set_userenv is true' );
+ ok( checkpw( $dbh, $patron->{userid}, 'password', undef, undef, 0 ), 'checkpw still returns true' );
+ isnt( C4::Context->userenv->{branch}, $library->{branchcode}, 'Userenv branch is overwritten if no_set_userenv is false' );
+}
# get_template_and_user tests
# we don't need to bother about permissions for this test
my $flags = {
superlibrarian => 1, acquisition => 0,
- borrow => 0, borrowers => 0,
+ borrowers => 0,
catalogue => 1, circulate => 0,
coursereserves => 0, editauthorities => 0,
editcatalogue => 0, management => 0,
$auth->mock( 'checkauth', \&MockedCheckauth );
# Make sure 'EnableOpacSearchHistory' is set
- C4::Context->set_preference('EnableOpacSearchHistory',1);
+ t::lib::Mocks::mock_preference('EnableOpacSearchHistory',1);
# Enable es-ES for the OPAC and staff interfaces
- C4::Context->set_preference('opaclanguages','en,es-ES');
- C4::Context->set_preference('language','en,es-ES');
+ t::lib::Mocks::mock_preference('opaclanguages','en,es-ES');
+ t::lib::Mocks::mock_preference('language','en,es-ES');
# we need a session cookie
$ENV{"SERVER_PORT"} = 80;
my ( $template, $loggedinuser, $cookies ) = get_template_and_user(
{
- template_name => "about.tmpl",
+ template_name => "about.tt",
query => $query,
type => "opac",
authnotrequired => 1,
( $template, $loggedinuser, $cookies ) = get_template_and_user(
{
- template_name => "about.tmpl",
+ template_name => "about.tt",
query => $query,
type => "opac",
authnotrequired => 1,
ok( ( any { $_->name eq 'KohaOpacLanguage' and $_->value eq 'en' } @$cookies ),
'BZ9735: invalid language, then default to en');
+
+ for my $template_name (
+ qw(
+ ../../../../../../../../../../../../../../../etc/passwd
+ test/../../../../../../../../../../../../../../etc/passwd
+ /etc/passwd
+ test/does_not_finished_by_tt_t
+ )
+ ) {
+ eval {
+ ( $template, $loggedinuser, $cookies ) = get_template_and_user(
+ {
+ template_name => $template_name,
+ query => $query,
+ type => "intranet",
+ authnotrequired => 1,
+ flagsrequired => { catalogue => 1 },
+ }
+ );
+ };
+ like ( $@, qr(^bad template path), "The file $template_name should not be accessible" );
+ }
+ ( $template, $loggedinuser, $cookies ) = get_template_and_user(
+ {
+ template_name => 'errors/errorpage.tt',
+ query => $query,
+ type => "intranet",
+ authnotrequired => 1,
+ flagsrequired => { catalogue => 1 },
+ }
+ );
+ my $file_exists = ( -f $template->{filename} ) ? 1 : 0;
+ is ( $file_exists, 1, 'The file errors/errorpage.tt should be accessible (contains integers)' );
}
-my $hash1 = hash_password('password');
-my $hash2 = hash_password('password');
+# Check that there is always an OPACBaseURL set.
+my $input = CGI->new();
+my ( $template1, $borrowernumber, $cookie );
+( $template1, $borrowernumber, $cookie ) = get_template_and_user(
+ {
+ template_name => "opac-detail.tt",
+ type => "opac",
+ query => $input,
+ authnotrequired => 1,
+ }
+);
+
+ok( ( any { 'OPACBaseURL' eq $_ } keys %{$template1->{VARS}} ),
+ 'OPACBaseURL is in OPAC template' );
+
+my ( $template2 );
+( $template2, $borrowernumber, $cookie ) = get_template_and_user(
+ {
+ template_name => "catalogue/detail.tt",
+ type => "intranet",
+ query => $input,
+ authnotrequired => 1,
+ }
+);
+
+ok( ( any { 'OPACBaseURL' eq $_ } keys %{$template2->{VARS}} ),
+ 'OPACBaseURL is in Staff template' );
ok(C4::Auth::checkpw_hash('password', $hash1), 'password validates with first hash');
ok(C4::Auth::checkpw_hash('password', $hash2), 'password validates with second hash');
-
-$dbh->rollback;
projects / koha.git / blobdiff