Bug 15548: Move new patron related code to Patron*

[koha.git] / t / db_dependent / Hold.t

diff --git a/t/db_dependent/Hold.t b/t/db_dependent/Hold.t
index ccd24cd..1395419 100755 (executable)
--- a/t/db_dependent/Hold.t
+++ b/t/db_dependent/Hold.t
@@ -18,9 +18,14 @@
 use Modern::Perl;
 
 use C4::Context;
+use C4::Biblio qw( AddBiblio );
 use Koha::Database;
+use Koha::Libraries;
+use Koha::Patrons;
+use Koha::Item;
+use Koha::DateUtils;
 
-use Test::More tests => 8;
+use Test::More tests => 31;
 
 use_ok('Koha::Hold');
 
@@ -30,27 +35,106 @@ $schema->storage->txn_begin();
 my $dbh = C4::Context->dbh;
 $dbh->{RaiseError} = 1;
 
-my $hold = Koha::Hold->new({ found => 'W', waitingdate => '2000-01-01'});
+my @branches = Koha::Libraries->search();
+my $borrower = Koha::Patrons->search()->next();
+
+my $biblio = MARC::Record->new();
+my $title  = 'Silence in the library';
+$biblio->append_fields(
+    MARC::Field->new( '100', ' ', ' ', a => 'Moffat, Steven' ),
+    MARC::Field->new( '245', ' ', ' ', a => $title ),
+);
+my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $biblio, '' );
+
+my $item = Koha::Item->new(
+    {
+        biblionumber     => $biblionumber,
+        biblioitemnumber => $biblioitemnumber,
+        holdingbranch    => $branches[0]->branchcode(),
+        homebranch       => $branches[0]->branchcode(),
+    }
+);
+$item->store();
+
+my $hold = Koha::Hold->new(
+    {
+        biblionumber   => $biblionumber,
+        itemnumber     => $item->id(),
+        waitingdate    => '2000-01-01',
+        borrowernumber => $borrower->borrowernumber(),
+        branchcode     => $branches[1]->branchcode(),
+        suspend        => 0,
+    }
+);
+$hold->store();
+
+is( $hold->suspend, 0, "Hold is not suspended" );
+$hold->suspend_hold();
+is( $hold->suspend, 1, "Hold is suspended" );
+$hold->resume();
+is( $hold->suspend, 0, "Hold is not suspended" );
+my $dt = dt_from_string();
+$hold->suspend_hold( $dt );
+$dt->truncate( to => 'day' );
+is( $hold->suspend, 1, "Hold is suspended" );
+is( $hold->suspend_until, "$dt", "Hold is suspended with a date, truncation takes place automatically" );
+$hold->resume();
+is( $hold->suspend, 0, "Hold is not suspended" );
+is( $hold->suspend_until, undef, "Hold no longer has suspend_until date" );
+$hold->found('W');
+$hold->suspend_hold();
+is( $hold->suspend, 0, "Waiting hold cannot be suspended" );
+
+$item = $hold->item();
+
+my $hold_borrower = $hold->borrower();
+ok( $hold_borrower, 'Got hold borrower' );
+is( $hold_borrower->borrowernumber(), $borrower->borrowernumber(), 'Hold borrower matches correct borrower' );
 
 C4::Context->set_preference( 'ReservesMaxPickUpDelay', '' );
-my $dt = $hold->waiting_expires_on();
-is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if ReservesMaxPickUpDelay is not set");
+$dt = $hold->waiting_expires_on();
+is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if ReservesMaxPickUpDelay is not set" );
 
 is( $hold->is_waiting, 1, 'The hold is waiting' );
+is( $hold->is_found, 1, 'The hold is found');
+ok( !$hold->is_in_transit, 'The hold is not in transit' );
 
 C4::Context->set_preference( 'ReservesMaxPickUpDelay', '5' );
 $dt = $hold->waiting_expires_on();
-is( $dt->ymd, "2000-01-06", "Koha::Hold->waiting_expires_on returns DateTime of waitingdate + ReservesMaxPickUpDelay if set");
+is( $dt->ymd, "2000-01-06",
+    "Koha::Hold->waiting_expires_on returns DateTime of waitingdate + ReservesMaxPickUpDelay if set" );
 
 $hold->found('T');
 $dt = $hold->waiting_expires_on();
-is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to 'T' )");
+is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to 'T' )" );
 isnt( $hold->is_waiting, 1, 'The hold is not waiting (T)' );
+is( $hold->is_found, 1, 'The hold is found');
+is( $hold->is_in_transit, 1, 'The hold is in transit' );
 
 $hold->found(q{});
 $dt = $hold->waiting_expires_on();
-is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to empty string )");
+is( $dt, undef, "Koha::Hold->waiting_expires_on returns undef if found is not 'W' ( Set to empty string )" );
 isnt( $hold->is_waiting, 1, 'The hold is not waiting (W)' );
+is( $hold->is_found, 0, 'The hold is not found' );
+ok( !$hold->is_in_transit, 'The hold is not in transit' );
+
+# Test method is_cancelable
+$hold->found(undef);
+ok( $hold->is_cancelable(), "Unfound hold is cancelable" );
+$hold->found('W');
+ok( $hold->is_cancelable, "Waiting hold is cancelable" );
+$hold->found('T');
+ok( !$hold->is_cancelable, "In transit hold is not cancelable" );
+
+# Test method is_at_destination
+$hold->found(undef);
+ok( !$hold->is_at_destination(), "Unfound hold cannot be at destination" );
+$hold->found('T');
+ok( !$hold->is_at_destination(), "In transit hold cannot be at destination" );
+$hold->found('W');
+ok( !$hold->is_at_destination(), "Waiting hold where hold branchcode is not the same as the item's holdingbranch is not at destination" );
+$item->holdingbranch( $branches[1]->branchcode() );
+ok( $hold->is_at_destination(), "Waiting hold where hold branchcode is the same as the item's holdingbranch is at destination" );
 
 $schema->storage->txn_rollback();