Bug 15009: QA follow-up

[koha.git] / t / db_dependent / Log.t

diff --git a/t/db_dependent/Log.t b/t/db_dependent/Log.t
index 8a25c18..3904cf0 100644 (file)
--- a/t/db_dependent/Log.t
+++ b/t/db_dependent/Log.t
@@ -4,12 +4,16 @@
 # This Koha test module is a stub!  
 # Add more tests here!!!
 
-use strict;
-use warnings;
-use Test::More tests => 5;
+use Modern::Perl;
+use Test::More tests => 8;
 
-# We need C4::Dates to handle the dates
-use C4::Dates;
+use C4::Context;
+use Koha::DateUtils;
+
+use t::lib::Mocks qw/mock_preference/; # to mock CronjobLog
+use Data::Dumper;
+
+$| = 1;
 
 BEGIN {
        use_ok('C4::Log');
@@ -38,8 +42,8 @@ ok($success, "GetLogs returns results for an open search");
 
 eval {
     # FIXME: US formatted date hardcoded into test for now
-    my $date = C4::Dates->new();
-    $success = scalar(@{GetLogs($date->today(),$date->today(),"",undef,undef,"","")});
+    my $date = output_pref( { dt => dt_from_string, datenonly => 1, dateformat => 'iso' } );
+    $success = scalar(@{GetLogs( $date, $date, "", undef, undef, "", "") } );
 } or do {
     diag($@);
     $success = 0;
@@ -53,3 +57,39 @@ eval {
     $success = 0;
 };
 ok($success, "GetLogs seemed to find ".$success." like our test record in a tighter search");
+
+# Make sure we can rollback.
+my $dbh = C4::Context->dbh;
+$dbh->{AutoCommit} = 0;
+$dbh->{RaiseError} = 1;
+
+# We want numbers to be the same between runs.
+$dbh->do("DELETE FROM action_logs;");
+
+t::lib::Mocks::mock_preference('CronjobLog',0);
+cronlogaction();
+my $cronJobCount = $dbh->selectrow_array("SELECT COUNT(*) FROM action_logs WHERE module='CRONJOBS';",{});
+is($cronJobCount,0,"Cronjob not logged as expected.");
+
+t::lib::Mocks::mock_preference('CronjobLog',1);
+cronlogaction();
+$cronJobCount = $dbh->selectrow_array("SELECT COUNT(*) FROM action_logs WHERE module='CRONJOBS';",{});
+is($cronJobCount,1,"Cronjob logged as expected.");
+
+subtest "GetLogs should return all logs if dates are not set" => sub {
+    plan tests => 2;
+    my $today = dt_from_string->add(minutes => -1);
+    my $yesterday = dt_from_string->add( days => -1 );
+    $dbh->do(q|
+        INSERT INTO action_logs (timestamp, user, module, action, object, info)
+        VALUES
+        (?, 42, 'CATALOGUING', 'MODIFY', 4242, 'Record 42 has been modified by patron 4242 yesterday'),
+        (?, 43, 'CATALOGUING', 'MODIFY', 4242, 'Record 43 has been modified by patron 4242 today')
+    |, undef, output_pref({dt =>$yesterday, dateformat => 'iso'}), output_pref({dt => $today, dateformat => 'iso'}));
+    my $logs = GetLogs( undef, undef, undef, ['CATALOGUING'], ['MODIFY'], 4242 );
+    is( scalar(@$logs), 2, 'GetLogs should return all logs regardless the dates' );
+    $logs = GetLogs( output_pref($today), undef, undef, ['CATALOGUING'], ['MODIFY'], 4242 );
+    is( scalar(@$logs), 1, 'GetLogs should return the logs for today' );
+};
+
+$dbh->rollback();