Bug 17664: Silence non-zebra warnings in t/db_dependent/Search.t

[koha.git] / t / db_dependent / Plugins.t

diff --git a/t/db_dependent/Plugins.t b/t/db_dependent/Plugins.t
index 1b87d2a..dffcea7 100755 (executable)
--- a/t/db_dependent/Plugins.t
+++ b/t/db_dependent/Plugins.t
@@ -1,15 +1,16 @@
 #!/usr/bin/perl
 
-use strict;
-use warnings;
+use Modern::Perl;
 
-use Test::More tests => 20;
+use Test::More tests => 31;
 use File::Basename;
+use File::Temp qw( tempdir );
 use FindBin qw($Bin);
 use Archive::Extract;
 use Module::Load::Conditional qw(can_load);
 
 use C4::Context;
+use t::lib::Mocks;
 
 BEGIN {
     push( @INC, dirname(__FILE__) . '/..' );
@@ -29,34 +30,73 @@ isa_ok( $plugin, "Koha::Plugins::Base", 'Test plugin parent class' );
 
 ok( $plugin->can('report'), 'Test plugin can report' );
 ok( $plugin->can('tool'), 'Test plugin can tool' );
+ok( $plugin->can('to_marc'), 'Test plugin can to_marc' );
+ok( $plugin->can('opac_online_payment'), 'Test plugin can opac_online_payment' );
+ok( $plugin->can('opac_online_payment_begin'), 'Test plugin can opac_online_payment_begin' );
+ok( $plugin->can('opac_online_payment_end'), 'Test plugin can opac_online_payment_end' );
 ok( $plugin->can('configure'), 'Test plugin can configure' );
 ok( $plugin->can('install'), 'Test plugin can install' );
 ok( $plugin->can('uninstall'), 'Test plugin can install' );
 
-ok( Koha::Plugins::Handler->run({ class => "Koha::Plugin::Test", method => 'report', enable_plugins => 1 }) eq "Koha::Plugin::Test::report", 'Test run plugin report method' );
+is( Koha::Plugins::Handler->run({ class => "Koha::Plugin::Test", method => 'report', enable_plugins => 1 }), "Koha::Plugin::Test::report", 'Test run plugin report method' );
 
 my $metadata = $plugin->get_metadata();
-ok( $metadata->{'name'} eq 'Test Plugin', 'Test $plugin->get_metadata()' );
-
-ok( $plugin->get_qualified_table_name('mytable') eq 'koha_plugin_test_mytable', 'Test $plugin->get_qualified_table_name()' );
-ok( $plugin->get_plugin_http_path() eq '/plugin/Koha/Plugin/Test', 'Test $plugin->get_plugin_http_path()' );
-
-my @plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins( 'report' );
-ok( $plugins[0]->get_metadata()->{'name'} eq 'Test Plugin', "Koha::Plugins::GetPlugins functions correctly" );
-
-SKIP: {
-    skip "plugindir not set", 3 unless C4::Context->config("pluginsdir");
+is( $metadata->{'name'}, 'Test Plugin', 'Test $plugin->get_metadata()' );
+
+is( $plugin->get_qualified_table_name('mytable'), 'koha_plugin_test_mytable', 'Test $plugin->get_qualified_table_name()' );
+is( $plugin->get_plugin_http_path(), '/plugin/Koha/Plugin/Test', 'Test $plugin->get_plugin_http_path()' );
+
+# testing GetPlugins
+my @plugins = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins({
+    method => 'report'
+});
+my @names = map { $_->get_metadata()->{'name'} } @plugins;
+is( scalar grep( /^Test Plugin$/, @names), 1, "Koha::Plugins::GetPlugins functions correctly" );
+@plugins =  Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins({
+    metadata => { my_example_tag  => 'find_me' },
+});
+@names = map { $_->get_metadata()->{'name'} } @plugins;
+is( scalar grep( /^Test Plugin$/, @names), 1, "GetPlugins also found Test Plugin via a metadata tag" );
+# Test two metadata conditions; one does not exist for Test.pm
+# Since it is a required key, we should not find the same results
+my @plugins2 = Koha::Plugins->new({ enable_plugins => 1 })->GetPlugins({
+    metadata => { my_example_tag  => 'find_me', not_there => '1' },
+});
+isnt( scalar @plugins2, scalar @plugins, 'GetPlugins with two metadata conditions' );
+
+for my $pass ( 1 .. 2 ) {
+    my $plugins_dir;
+    my $module_name = 'Koha::Plugin::Com::ByWaterSolutions::KitchenSink';
+    my $pm_path = 'Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm';
+    if ( $pass == 1 ) {
+        my $plugins_dir1 = tempdir( CLEANUP => 1 );
+        t::lib::Mocks::mock_config('pluginsdir', $plugins_dir1);
+        $plugins_dir = $plugins_dir1;
+        push @INC, $plugins_dir1;
+    } else {
+        my $plugins_dir1 = tempdir( CLEANUP => 1 );
+        my $plugins_dir2 = tempdir( CLEANUP => 1 );
+        t::lib::Mocks::mock_config('pluginsdir', [ $plugins_dir2, $plugins_dir1 ]);
+        $plugins_dir = $plugins_dir2;
+        pop @INC;
+        push @INC, $plugins_dir2;
+        push @INC, $plugins_dir1;
+    }
+    my $full_pm_path = $plugins_dir . '/' . $pm_path;
 
-    my $plugins_dir = C4::Context->config("pluginsdir");
     my $ae = Archive::Extract->new( archive => "$Bin/KitchenSinkPlugin.kpz", type => 'zip' );
     unless ( $ae->extract( to => $plugins_dir ) ) {
         warn "ERROR: " . $ae->error;
     }
     use_ok('Koha::Plugin::Com::ByWaterSolutions::KitchenSink');
     $plugin = Koha::Plugin::Com::ByWaterSolutions::KitchenSink->new({ enable_plugins => 1});
+    my $table = $plugin->get_qualified_table_name( 'mytable' );
 
     ok( -f $plugins_dir . "/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm", "KitchenSink plugin installed successfully" );
-    Koha::Plugins::Handler->delete({ class => "Koha::Plugin::Com::ByWaterSolutions::KitchenSink" });
-    ok( !( -f $plugins_dir . "/Koha/Plugin/Com/ByWaterSolutions/KitchenSink.pm" ), "Koha::Plugins::Handler::delete works correctly." );
+    $INC{$pm_path} = $full_pm_path; # FIXME I do not really know why, but if this is moved before the $plugin constructor, it will fail with Can't locate object method "new" via package "Koha::Plugin::Com::ByWaterSolutions::KitchenSink"
+    Koha::Plugins::Handler->delete({ class => "Koha::Plugin::Com::ByWaterSolutions::KitchenSink", enable_plugins => 1 });
+    my $sth = C4::Context->dbh->table_info( undef, undef, $table, 'TABLE' );
+    my $info = $sth->fetchall_arrayref;
+    is( @$info, 0, "Table $table does no longer exist" );
+    ok( !( -f $full_pm_path ), "Koha::Plugins::Handler::delete works correctly." );
 }
-