use Modern::Perl;
+use t::lib::Mocks;
use C4::Context;
use C4::Members;
use C4::Letters;
-use C4::Branch;
use C4::Budgets qw( AddBudgetPeriod AddBudget );
use Koha::DateUtils qw( dt_from_string );
+use Koha::Library;
+use Koha::Libraries;
+
+use t::lib::TestBuilder;
use DateTime::Duration;
-use Test::More tests => 105;
+use Test::More tests => 102;
use Test::Warn;
BEGIN {
use_ok('C4::Suggestions');
- use_ok('C4::Koha');
}
my $dbh = C4::Context->dbh;
$dbh->{AutoCommit} = 0;
$dbh->{RaiseError} = 1;
+my $builder = t::lib::TestBuilder->new;
# Reset item types to only the default ones
$dbh->do(q|DELETE FROM itemtypes;|);
$sql = "
$dbh->do(q|INSERT INTO letter(module, code, content) VALUES ('suggestions', 'CHECKED', 'my content')|);
# Add CPL if missing.
-if (not defined GetBranchDetail('CPL')) {
- ModBranch({add => 1, branchcode => 'CPL', branchname => 'Centerville'});
+if (not defined Koha::Libraries->find('CPL')) {
+ Koha::Library->new({ branchcode => 'CPL', branchname => 'Centerville' })->store;
}
-my $sth = $dbh->prepare("SELECT * FROM categories WHERE categorycode='S';");
-$sth->execute();
-if (!$sth->fetchrow_hashref) {
- $sql = "INSERT INTO categories
- (categorycode,description,enrolmentperiod,upperagelimit,
- dateofbirthrequired,finetype,bulk,enrolmentfee,
- overduenoticerequired,issuelimit,reservefee,category_type)
- VALUES
- ('S','Staff',99,999,
- 18,NULL,NULL,'0.000000',
- 0,NULL,'0.000000','S');";
- $dbh->do($sql);
-}
+my $patron_category = $builder->build({ source => 'Category' });
my $member = {
firstname => 'my firstname',
surname => 'my surname',
- categorycode => 'S',
+ categorycode => $patron_category->{categorycode},
branchcode => 'CPL',
};
my $borrowernumber = AddMember(%$member);
STATUS => $mod_suggestion3->{STATUS},
});
is( @$search_suggestion, 1, 'SearchSuggestion returns the correct number of suggestions' );
+
+$search_suggestion = SearchSuggestion({
+ STATUS => q||
+});
+is( @$search_suggestion, 0, 'SearchSuggestion should not return all suggestions if we want the suggestions with a STATUS=""' );
$search_suggestion = SearchSuggestion({
STATUS => 'REJECTED',
});
is( @$suggestions, 1, 'DelSuggestion deletes one suggestion' );
is( $suggestions->[0]->{title}, $del_suggestion->{title}, 'DelSuggestion deletes the correct suggestion' );
-## Bug 11466, making sure GetSupportList() returns itemtypes, even if AdvancedSearchTypes has multiple values
-C4::Context->set_preference("AdvancedSearchTypes", 'itemtypes|loc|ccode');
-my $itemtypes1 = C4::Koha::GetSupportList();
-is(@$itemtypes1, 8, "Purchase suggestion itemtypes collected, multiple AdvancedSearchTypes");
-
-C4::Context->set_preference("AdvancedSearchTypes", 'itemtypes');
-my $itemtypes2 = C4::Koha::GetSupportList();
-is(@$itemtypes2, 8, "Purchase suggestion itemtypes collected, default AdvancedSearchTypes");
-
-is_deeply($itemtypes1, $itemtypes2, 'same set of purchase suggestion formats retrieved');
-
# Test budgetid fk
$my_suggestion->{budgetid} = ''; # If budgetid == '', NULL should be set in DB
my $my_suggestionid_test_budgetid = NewSuggestion($my_suggestion);
is( $suggestion->{budgetid}, undef, 'NewSuggestion Should set budgetid to NULL if equals an empty string' );
subtest 'GetUnprocessedSuggestions' => sub {
- plan tests => 9;
+ plan tests => 11;
$dbh->do(q|DELETE FROM suggestions|);
my $my_suggestionid = NewSuggestion($my_suggestion);
my $unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
$unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
is( scalar(@$unprocessed_suggestions), 1, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
- ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } );
+ warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'REJECTED' } ) }
+ 'No suggestions REJECTED letter transported by email',
+ 'Warning raised if no REJECTED letter by email';
$unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should return the suggestion if the suggestion is linked to a fund and has not been processed yet' );
- ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } );
+ warning_is { ModSuggestion( { suggestionid => $my_suggestionid, STATUS => 'ASKED', suggesteddate => dt_from_string->add_duration( DateTime::Duration->new( days => -4 ) ) } ); }
+ 'No suggestions ASKED letter transported by email',
+ 'Warning raised if no ASKED letter by email';
$unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions;
is( scalar(@$unprocessed_suggestions), 0, 'GetUnprocessedSuggestions should use 0 as default value for days' );
$unprocessed_suggestions = C4::Suggestions::GetUnprocessedSuggestions(4);