Bug 15009: QA follow-up

[koha.git] / t / db_dependent / UsageStats.t

diff --git a/t/db_dependent/UsageStats.t b/t/db_dependent/UsageStats.t
index ad2dd15..dc69bbb 100644 (file)
--- a/t/db_dependent/UsageStats.t
+++ b/t/db_dependent/UsageStats.t
@@ -15,7 +15,7 @@
 # with Koha; if not, see <http://www.gnu.org/licenses>.
 
 use Modern::Perl;
-use Test::More tests => 551;
+use Test::More tests => 549;
 use t::lib::Mocks qw(mock_preference);
 use POSIX qw(strftime);
 
@@ -150,7 +150,6 @@ mocking_systempreferences_to_a_set_value(0);
 $report = C4::UsageStats->BuildReport();
 isa_ok( $report,                      'HASH', '$report is a HASH' );
 isa_ok( $report->{systempreferences}, 'HASH', '$report->{systempreferences} is a HASH' );
-is( scalar( keys %{$report->{systempreferences}} ), 248, "There are 248 fields in $report->{systempreferences}" );
 verif_systempreferences_values( $report, 0 );
 
 #mock with values
@@ -159,9 +158,12 @@ mocking_systempreferences_to_a_set_value(1);
 $report = C4::UsageStats->BuildReport();
 isa_ok( $report,                      'HASH', '$report is a HASH' );
 isa_ok( $report->{systempreferences}, 'HASH', '$report->{systempreferences} is a HASH' );
-is( scalar( keys %{$report->{systempreferences}} ), 248, "There are 248 fields in $report->{systempreferences}" );
 verif_systempreferences_values( $report, 1 );
 
+#Test if unwanted syspref are not sent
+is( $report->{systempreferences}->{useDischarge}, undef, 'useDischarge should not be shared');
+is( $report->{systempreferences}->{OpacUserJS},   undef, 'OpacUserJS   should not be shared');
+
 # ---------- Testing ReportToCommunity ----------
 
 # ---------- Testing _count ---------------------
@@ -286,7 +288,7 @@ sub construct_objects_needed {
     my $issue_id1 = $dbh->last_insert_id( undef, undef, 'old_issues', undef );
 
     # ---------- Add 1 old_reserves
-    AddReserve( $branchcode, $borrowernumber1, $biblionumber1, 'a', '', 1, undef, undef, '', 'Title', undef, undef );
+    AddReserve( $branchcode, $borrowernumber1, $biblionumber1, '', 1, undef, undef, '', 'Title', undef, undef );
     my $reserves1   = GetReservesFromBiblionumber( { biblionumber => $biblionumber1 } );
     my $reserve_id1 = $reserves1->[0]->{reserve_id};
     my $reserve1    = CancelReserve( { reserve_id => $reserve_id1 } );
@@ -333,7 +335,7 @@ sub mocking_systempreferences_to_a_set_value {
         OrderPdfFormat
         casAuthentication
         casLogout
-        AllowPkiAuth
+        AllowPKIAuth
         DebugLevel
         delimiter
         noItemTypeImages
@@ -453,6 +455,7 @@ sub mocking_systempreferences_to_a_set_value {
         NovelistSelectEnabled
         XISBN
         OpenLibraryCovers
+        OpenLibrarySearch
         UseKohaPlugins
         SyndeticsEnabled
         TagsEnabled
@@ -574,6 +577,7 @@ sub mocking_systempreferences_to_a_set_value {
         ILS-DI
         OAI-PMH
         version
+        AudioAlerts
         /
       ) {
         t::lib::Mocks::mock_preference( $_, $set_value );