# Author : Antoine Farnault, antoine@koha-fr.org
#
-use Test;
-use strict;
-#use warnings; FIXME - Bug 2505
-use C4::Context;
+use Modern::Perl;
+use Test::More tests => 82;
+use MARC::Record;
-# Making 30 tests.
-BEGIN { plan tests => 112 }
+use C4::Biblio qw( AddBiblio DelBiblio );
+use C4::Context;
# Getting some borrowers from database.
my $dbh = C4::Context->dbh;
-my $query = qq/
+my $query = q{
SELECT borrowernumber
FROM borrowers
LIMIT 10
-/;
+};
my $sth = $dbh->prepare($query);
$sth->execute;
my @borrowers;
push @borrowers, $borrower;
}
-# Getting some itemnumber from database
-my $query = qq/
- SELECT itemnumber
- FROM items
- LIMIT 10
-/;
-my $sth = $dbh->prepare($query);
-$sth->execute;
-my @items;
-while(my $item = $sth->fetchrow){
- push @items, $item;
-}
-
-# Getting some biblionumbers from database
-my $query = qq/
- SELECT biblionumber
- FROM biblio
- LIMIT 10
-/;
-my $sth = $dbh->prepare($query);
-$sth->execute;
-my @biblionumbers;
-while(my $biblionumber = $sth->fetchrow){
- push @biblionumbers, $biblionumber;
-}
+# Creating some biblios
+my ($biblionumber1, $biblioitemnumber1) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber2, $biblioitemnumber2) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber3, $biblioitemnumber3) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber4, $biblioitemnumber4) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber5, $biblioitemnumber5) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber6, $biblioitemnumber6) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber7, $biblioitemnumber7) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber8, $biblioitemnumber8) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber9, $biblioitemnumber9) = AddBiblio(MARC::Record->new, '');
+my ($biblionumber10, $biblioitemnumber10) = AddBiblio(MARC::Record->new, '');
+my @biblionumbers = (
+ $biblionumber1, $biblionumber2, $biblionumber3, $biblionumber4, $biblionumber5,
+ $biblionumber6, $biblionumber7, $biblionumber8, $biblionumber9, $biblionumber10,
+);
# ---
-my $delete_virtualshelf = qq/
+my $delete_virtualshelf = q{
DELETE FROM virtualshelves WHERE 1
-/;
-my $delete_virtualshelfcontent =qq/
+};
+my $delete_virtualshelfcontent = q{
DELETE FROM virtualshelfcontents WHERE 1
-/;
+};
-my $sth = $dbh->prepare($delete_virtualshelf);
+$sth = $dbh->prepare($delete_virtualshelf);
$sth->execute;
-my $sth = $dbh->prepare($delete_virtualshelfcontent);
+$sth = $dbh->prepare($delete_virtualshelfcontent);
$sth->execute;
# ---
#
#----------------------------------------------------------------------#
-use C4::VirtualShelves;
-my $version = C4::VirtualShelves->VERSION;
-print "\n----------Testing C4::VirtualShelves version ".$version."--------\n";
-
-ok($version); # First test: the module is loaded & the version is readable.
-
+use_ok('C4::VirtualShelves');
#-----------------------TEST AddShelf function------------------------#
# usage : $shelfnumber = &AddShelf( $shelfname, $owner, $category);
# creating 10 good shelves.
my @shelves;
for(my $i=0; $i<10;$i++){
- my $ShelfNumber = AddShelf("Shelf_".$i,$borrowers[$i] || '',int(rand(3))+1);
+ my $ShelfNumber = AddShelf(
+ {shelfname=>"Shelf_".$i, category=>int(rand(2))+1 }, $borrowers[$i] );
die "test Not ok, remove some shelves before" if ($ShelfNumber == -1);
- ok($ShelfNumber); # Shelf creation successful;
- push @shelves, $ShelfNumber if ok($ShelfNumber);
+ ok($ShelfNumber > -1, "created shelf"); # Shelf creation successful;
+ push @shelves, $ShelfNumber if $ShelfNumber > -1;
}
-ok(10,scalar @shelves); # 10 shelves in @shelves;
+ok(10 == scalar @shelves, 'created 10 lists'); # 10 shelves in @shelves;
# try to create some shelf which already exists.
for(my $i=0;$i<10;$i++){
- my $badNumShelf = AddShelf("Shelf_".$i,$borrowers[$i] || '','');
- ok(-1,$badNumShelf); # AddShelf returns -1 if name already exist.
+ my @shlf=GetShelf($shelves[$i]);
+ my $badNumShelf = AddShelf(
+ {shelfname=>"Shelf_".$i, category=>$shlf[3] }, $borrowers[$i]);
+ ok(-1 == $badNumShelf, 'do not create lists with duplicate names'); # AddShelf returns -1 if name already exist.
}
-#-----------TEST AddToShelf & &AddToShelfFromBiblio & GetShelfContents & DelFromShelf functions--------------#
-# usage : &AddToShelf($itemnumber, $shelfnumber);
-# usage : $itemlist = &GetShelfContents($shelfnumber);
-# usage : $itemlist = GetShelfContents($shelfnumber);
+#-----------TEST AddToShelf & GetShelfContents & DelFromShelf functions--------------#
+# usage : &AddToShelf($biblionumber, $shelfnumber);
+# usage : $biblist = &GetShelfContents($shelfnumber);
+# usage : $biblist = GetShelfContents($shelfnumber);
+my %used = ();
for(my $i=0; $i<10;$i++){
- my $item = $items[int(rand(9))];
+ my $bib = $biblionumbers[int(rand(9))];
my $shelfnumber = $shelves[int(rand(9))];
-
- my ($itemlistBefore,$countbefore) = GetShelfContents($shelfnumber);
- AddToShelf($item,$shelfnumber);
- my ($itemlistAfter,$countafter) = GetShelfContents($shelfnumber);
- ok($countbefore,$countafter - 1); # the item has been successfuly added.
-
-
- # same thing with AddToShelfFromBiblio
- my $biblionumber = $biblionumbers[int(rand(9))];
- &AddToShelfFromBiblio($biblionumber, $shelfnumber);
- my ($AfterAgain,$countagain) = GetShelfContents($shelfnumber);
- ok($countafter, $countagain -1);
+
+ my $key = "$bib\t$shelfnumber";
+ my $should_fail = exists($used{$key}) ? 1 : 0;
+
+ my ($biblistBefore,$countbefore) = GetShelfContents($shelfnumber);
+ my $status = AddToShelf($bib,$shelfnumber,$borrowers[$i]);
+ my ($biblistAfter,$countafter) = GetShelfContents($shelfnumber);
+
+ if ($should_fail) {
+ ok(!defined($status), 'failed to add to list when we should');
+ } else {
+ ok(defined($status), 'added to list when we should');
+ }
+
+ if (defined $status) {
+ ok($countbefore == $countafter - 1, 'added bib to list'); # the bib has been successfuly added.
+ } else {
+ ok($countbefore == $countafter, 'did not add duplicate bib to list'); # the bib has been successfuly added.
+ }
+
+ $used{$key}++;
+
}
#-----------------------TEST ModShelf & GetShelf functions------------------------#
my $rand = int(rand(9));
my $numA = $shelves[$rand];
my $shelf = { shelfname => "NewName_".$rand,
- owner => $borrowers[$rand],
- category => int(rand(3))+1 };
-
+ category => int(rand(2))+1 };
+
ModShelf($numA,$shelf);
my ($numB,$nameB,$ownerB,$categoryB) = GetShelf($numA);
-
- ok($numA,$numB);
- ok($shelf->{shelfname},$nameB);
- ok($shelf->{owner},$ownerB);
- ok($shelf->{category},$categoryB);
+
+ ok($numA == $numB, 'modified shelf');
+ ok($shelf->{shelfname} eq $nameB, '... and name change took');
+ ok($shelf->{category} eq $categoryB, '... and category change took');
}
#-----------------------TEST DelShelf & DelFromShelf functions------------------------#
# usage : ($status) = &DelShelf($shelfnumber);
-# usage : &DelFromShelf( $itemnumber, $shelfnumber);
for(my $i=0; $i<10;$i++){
my $shelfnumber = $shelves[$i];
my $status = DelShelf($shelfnumber);
- if($status){
- my ($items,$count) = GetShelfContents($shelfnumber);
- ok($status,$count);
- foreach (@$items){ # delete all the item in this shelf
- DelFromShelf($_{'itemnumber'},$shelfnumber);
- }
- ok(DelShelf($shelfnumber));
- }
+ ok(1 == $status, "deleted shelf $shelfnumber and its contents");
}
+
+END {
+ DelBiblio( $biblionumber1 );
+ DelBiblio( $biblionumber2 );
+ DelBiblio( $biblionumber3 );
+ DelBiblio( $biblionumber4 );
+ DelBiblio( $biblionumber5 );
+ DelBiblio( $biblionumber6 );
+ DelBiblio( $biblionumber7 );
+ DelBiblio( $biblionumber8 );
+ DelBiblio( $biblionumber9 );
+ DelBiblio( $biblionumber10 );
+};
projects / koha.git / blobdiff