Bug 17006: Unit tests

[koha.git] / t / db_dependent / XISBN.t

diff --git a/t/db_dependent/XISBN.t b/t/db_dependent/XISBN.t
index 55f25a1..803743a 100755 (executable)
--- a/t/db_dependent/XISBN.t
+++ b/t/db_dependent/XISBN.t
@@ -5,25 +5,27 @@
 
 use Modern::Perl;
 
-use Test::More tests => 5;
+use Test::More tests => 3;
 use MARC::Record;
 use C4::Biblio;
 use C4::XISBN;
 use C4::Context;
+use C4::Search;
+use Koha::Database;
+use t::lib::Mocks;
 use Test::MockModule;
 
 BEGIN {
     use_ok('C4::XISBN');
 }
 
-my $dbh = C4::Context->dbh;
-$dbh->{RaiseError} = 1;
-$dbh->{AutoCommit} = 0;
+my $schema = Koha::Database->new->schema;
+$schema->storage->txn_begin;
 
 my $search_module = new Test::MockModule('C4::Search');
 
 $search_module->mock('SimpleSearch', \&Mock_SimpleSearch );
-
+my $errors;
 my $context = C4::Context->new;
 
 my ( $biblionumber_tag, $biblionumber_subfield ) =
@@ -35,35 +37,30 @@ my ( $isbn_tag, $isbn_subfield ) =
 my $isbn1 = '0590353403';
 # ThingISBN match : Silent Wing, First Edition 1998
 my $isbn2 = '0684843897';
-# XISBN match : Harry Potter and the Philosopher's Stone, Magic ed. 2000
-my $isbn3 = '1551923963';
+# XISBN match : Harry Potter and the Sorcerer's Stone,
+# 1. Scholastic mass market paperback printing1.
+my $isbn3 = '043936213X';
 
 my $biblionumber1 = _add_biblio_with_isbn($isbn1);
 my $biblionumber2 = _add_biblio_with_isbn($isbn2);
 my $biblionumber3 = _add_biblio_with_isbn($isbn3);
 
-my $trial = C4::XISBN::get_biblionumber_from_isbn($isbn1);
-is( $trial->[0]->{biblionumber},
-    $biblionumber1,
-    "It gets the correct biblionumber from the only isbn we have added." );
-
-$trial = C4::XISBN::_get_biblio_from_xisbn($isbn1);
+my $trial = C4::XISBN::_get_biblio_from_xisbn($isbn1);
 is( $trial->{biblionumber},
     $biblionumber1, "Gets biblionumber like the previous test." );
 
-$context->set_preference( 'ThingISBN', 1 );
-$context->set_preference( 'XISBN', 0 );
-my $results_thingisbn = C4::XISBN::get_xisbns($isbn1);
-is( $results_thingisbn->[0]->{biblionumber},
-    $biblionumber3,
-    "Gets correct biblionumber from a book with a similar isbn using ThingISBN." );
-
-$context->set_preference( 'ThingISBN', 0 );
-$context->set_preference( 'XISBN', 1 );
-my $results_xisbn = C4::XISBN::get_xisbns($isbn1);
-is( $results_xisbn->[0]->{biblionumber},
-    $biblionumber3,
-    "Gets correct biblionumber from a book with a similar isbn using XISBN." );
+## Test ThingISBN
+t::lib::Mocks::mock_preference( 'ThingISBN', 1 );
+
+my $results_thingisbn;
+eval { $results_thingisbn = C4::XISBN::get_xisbns($isbn1); };
+SKIP: {
+    skip "Problem retrieving ThingISBN", 1
+        unless $@ eq '';
+    is( $results_thingisbn->[0]->{biblionumber},
+        $biblionumber3,
+        "Gets correct biblionumber from a book with a similar isbn using ThingISBN." );
+}
 
 # Util subs
 
@@ -110,6 +107,7 @@ sub Mock_SimpleSearch {
     }
     $record->append_fields($biblionumber_field);
 
-    push @results, $record->as_usmarc;
+    push @results, $record->as_xml();
+
     return ( undef, \@results, 1 );
 }