Bug 17006: Unit tests

[koha.git] / t / db_dependent / XISBN.t

diff --git a/t/db_dependent/XISBN.t b/t/db_dependent/XISBN.t
index a3c5c6d..803743a 100755 (executable)
--- a/t/db_dependent/XISBN.t
+++ b/t/db_dependent/XISBN.t
@@ -1,51 +1,113 @@
 #!/usr/bin/perl
 #
-# This Koha test module is a stub!  
+# This Koha test module is a stub!
 # Add more tests here!!!
 
-use strict;
-use warnings;
-# use Test::Class::Load qw ( t/db_dependent/ );
-use Test::More tests => 4;
+use Modern::Perl;
+
+use Test::More tests => 3;
 use MARC::Record;
 use C4::Biblio;
 use C4::XISBN;
-use Data::Dumper;
 use C4::Context;
+use C4::Search;
+use Koha::Database;
+use t::lib::Mocks;
+use Test::MockModule;
 
 BEGIN {
-       use_ok('C4::XISBN');
+    use_ok('C4::XISBN');
 }
 
-# KohaTest::clear_test_database();
-# KohaTest::create_test_database();
+my $schema = Koha::Database->new->schema;
+$schema->storage->txn_begin;
+
+my $search_module = new Test::MockModule('C4::Search');
 
-my $isbn = '0590353403';
-my $isbn2 = '0747554560';
+$search_module->mock('SimpleSearch', \&Mock_SimpleSearch );
+my $errors;
+my $context = C4::Context->new;
 
-my $marc_record=MARC::Record->new;
-my $field = MARC::Field->new('020','','','a' => $isbn);
-$marc_record->append_fields($field);
-my($biblionumber,$biblioitemnumber) = AddBiblio($marc_record,'');
+my ( $biblionumber_tag, $biblionumber_subfield ) =
+  GetMarcFromKohaField( 'biblio.biblionumber', '' );
+my ( $isbn_tag, $isbn_subfield ) =
+  GetMarcFromKohaField( 'biblioitems.isbn', '' );
 
-my $marc_record=MARC::Record->new;
-my $field = MARC::Field->new('020','','','a' => $isbn2);
-$marc_record->append_fields($field);
-my($biblionumber2,$biblioitemnumber2) = AddBiblio($marc_record,'');
+# Harry Potter and the Sorcerer's Stone, 1st American ed. 1997
+my $isbn1 = '0590353403';
+# ThingISBN match : Silent Wing, First Edition 1998
+my $isbn2 = '0684843897';
+# XISBN match : Harry Potter and the Sorcerer's Stone,
+# 1. Scholastic mass market paperback printing1.
+my $isbn3 = '043936213X';
 
+my $biblionumber1 = _add_biblio_with_isbn($isbn1);
+my $biblionumber2 = _add_biblio_with_isbn($isbn2);
+my $biblionumber3 = _add_biblio_with_isbn($isbn3);
 
-my $trial = C4::XISBN::get_biblionumber_from_isbn($isbn);
-is($trial->[0]->{biblionumber},$biblionumber,"It gets the correct biblionumber from the only isbn we have added.");
+my $trial = C4::XISBN::_get_biblio_from_xisbn($isbn1);
+is( $trial->{biblionumber},
+    $biblionumber1, "Gets biblionumber like the previous test." );
 
-$trial = C4::XISBN::_get_biblio_from_xisbn($isbn);
-is($trial->{biblionumber},$biblionumber,"Gets biblionumber like the previous test.");
+## Test ThingISBN
+t::lib::Mocks::mock_preference( 'ThingISBN', 1 );
+
+my $results_thingisbn;
+eval { $results_thingisbn = C4::XISBN::get_xisbns($isbn1); };
+SKIP: {
+    skip "Problem retrieving ThingISBN", 1
+        unless $@ eq '';
+    is( $results_thingisbn->[0]->{biblionumber},
+        $biblionumber3,
+        "Gets correct biblionumber from a book with a similar isbn using ThingISBN." );
+}
 
-my $context = C4::Context->new();
-$context->set_preference('ThingISBN','on');
-diag C4::Context::preference('ThingISBN');
-my $var = C4::XISBN::get_xisbns($isbn);
-is($var->[0]->{biblionumber},$biblionumber2,"Gets correct biblionumber from a book with a similar isbn.");
+# Util subs
+
+# Add new biblio with isbn and return biblionumber
+sub _add_biblio_with_isbn {
+    my $isbn = shift;
+
+    my $marc_record = MARC::Record->new;
+    my $field = MARC::Field->new( $isbn_tag, '', '', $isbn_subfield => $isbn );
+    $marc_record->append_fields($field);
+    my ( $biblionumber, $biblioitemnumber ) = AddBiblio( $marc_record, '' );
+    return $biblionumber;
+}
 
-# clean up after ourselves
-DelBiblio($biblionumber);
-DelBiblio($biblionumber2);
\ No newline at end of file
+# Mocked subs
+
+# C4::Search::SimpleSearch
+sub Mock_SimpleSearch {
+    my $query = shift;
+    my @results;
+
+    $query =~ s/-//g;
+    my $ret_biblionumber;
+    if ( $query =~ /$isbn1/ ) {
+        $ret_biblionumber = $biblionumber1;
+    }
+    elsif ( $query =~ /$isbn2/ ) {
+        $ret_biblionumber = $biblionumber2;
+    }
+    elsif ( $query =~ /$isbn3/ ) {
+        $ret_biblionumber = $biblionumber3;
+    }
+
+    my $record = MARC::Record->new;
+    $record->leader('     ngm a22     7a 4500');
+    my $biblionumber_field;
+    if ( $biblionumber_tag < 10 ) {
+        $biblionumber_field =
+          MARC::Field->new( $biblionumber_tag, $ret_biblionumber );
+    }
+    else {
+        $biblionumber_field = MARC::Field->new( $biblionumber_tag, '', '',
+            $biblionumber_subfield => $ret_biblionumber );
+    }
+    $record->append_fields($biblionumber_field);
+
+    push @results, $record->as_xml();
+
+    return ( undef, \@results, 1 );
+}