Bugfix: Removing Dumper() call

[koha.git] / tools / letter.pl

diff --git a/tools/letter.pl b/tools/letter.pl
index ecc7634..5429b24 100755 (executable)
--- a/tools/letter.pl
+++ b/tools/letter.pl
@@ -88,19 +88,16 @@ my ( $template, $borrowernumber, $cookie ) = get_template_and_user(
 );
 
 if ($op) {
-    $template->param(
-        script_name => $script_name,
-        $op         => 1
-    );    # we show only the TMPL_VAR names $op
-}
-else {
-    $template->param(
-        script_name => $script_name,
-        else        => 1
-    );    # we show only the TMPL_VAR names $op
+       $template->param($op  => 1);
+} else {
+       $template->param(else => 1);
 }
+# we show only the TMPL_VAR names $op
 
-$template->param( action => $script_name );
+$template->param(
+       script_name => $script_name,
+       action => $script_name
+);
 ################## ADD_FORM ##################################
 # called by default. Used to create form to add or  modify a record
 if ( $op eq 'add_form' ) {
@@ -116,125 +113,98 @@ if ( $op eq 'add_form' ) {
 
     # build field list
     my @SQLfieldname;
-    my %line = ( 'value' => "LibrarianFirstname", 'text' => 'LibrarianFirstname' );
-    push @SQLfieldname, \%line;
-    %line = ( 'value' => "LibrarianSurname", 'text' => 'LibrarianSurname' );
-    push @SQLfieldname, \%line;
-    %line = ( 'value' => "LibrarianEmailaddress", 'text' => 'LibrarianEmailaddress' );
-    push @SQLfieldname, \%line;
+    push @SQLfieldname, { 'value' => "LibrarianFirstname",    'text' => 'LibrarianFirstname'    };
+    push @SQLfieldname, { 'value' => "LibrarianSurname",      'text' => 'LibrarianSurname'      };
+    push @SQLfieldname, { 'value' => "LibrarianEmailaddress", 'text' => 'LibrarianEmailaddress' };
     my $sth2 = $dbh->prepare("SHOW COLUMNS from branches");
     $sth2->execute;
-    %line = ( 'value' => "", 'text' => '---BRANCHES---' );
-    push @SQLfieldname, \%line;
+    push @SQLfieldname, { 'value' => "", 'text' => '---BRANCHES---' };
 
     while ( ( my $field ) = $sth2->fetchrow_array ) {
-        %line = ( 'value' => "branches." . $field, 'text' => "branches." . $field );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "branches." . $field, 'text' => "branches." . $field };
     }
 
     # add acquisition specific tables
-    if ( index( $module, "acquisition" ) > 0 ) {
+    if ( index( $module, "acquisition" ) > 0 ) {       # FIXME: imprecise comparison
         $sth2 = $dbh->prepare("SHOW COLUMNS from aqbooksellers");
         $sth2->execute;
-        %line = ( 'value' => "", 'text' => '---BOOKSELLERS---' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "", 'text' => '---BOOKSELLERS---' };
         while ( ( my $field ) = $sth2->fetchrow_array ) {
-            %line = (
+            push @SQLfieldname, {
                 'value' => "aqbooksellers." . $field,
                 'text'  => "aqbooksellers." . $field
-            );
-            push @SQLfieldname, \%line;
+            };
         }
         $sth2 = $dbh->prepare("SHOW COLUMNS from aqorders");
         $sth2->execute;
-        %line = ( 'value' => "", 'text' => '---ORDERS---' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "", 'text' => '---ORDERS---' };
         while ( ( my $field ) = $sth2->fetchrow_array ) {
-            %line = (
+            push @SQLfieldname, {
                 'value' => "aqorders." . $field,
                 'text'  => "aqorders." . $field
-            );
-            push @SQLfieldname, \%line;
+            };
         }
 
         # add issues specific tables
     }
-    elsif ( index( $module, "issues" ) > 0 ) {
+    elsif ( index( $module, "issues" ) > 0 ) { # FIXME: imprecise comparison
         $sth2 = $dbh->prepare("SHOW COLUMNS from aqbooksellers");
         $sth2->execute;
-        %line = ( 'value' => "", 'text' => '---BOOKSELLERS---' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "", 'text' => '---BOOKSELLERS---' };
         while ( ( my $field ) = $sth2->fetchrow_array ) {
-            %line = (
+            push @SQLfieldname, {
                 'value' => "aqbooksellers." . $field,
                 'text'  => "aqbooksellers." . $field
-            );
-            push @SQLfieldname, \%line;
+            };
         }
         $sth2 = $dbh->prepare("SHOW COLUMNS from serial");
         $sth2->execute;
-        %line = ( 'value' => "", 'text' => '---SERIALS---' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "", 'text' => '---SERIALS---' };
         while ( ( my $field ) = $sth2->fetchrow_array ) {
-            %line = ( 'value' => "serial." . $field, 'text' => "serial." . $field );
-            push @SQLfieldname, \%line;
+            push @SQLfieldname, { 'value' => "serial." . $field, 'text' => "serial." . $field };
         }
         $sth2 = $dbh->prepare("SHOW COLUMNS from subscription");
         $sth2->execute;
-        %line = ( 'value' => "", 'text' => '---SUBSCRIPTION---' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "", 'text' => '---SUBSCRIPTION---' };
         while ( ( my $field ) = $sth2->fetchrow_array ) {
-            %line = (
+            push @SQLfieldname, {
                 'value' => "subscription." . $field,
                 'text'  => "subscription." . $field
-            );
-            push @SQLfieldname, \%line;
+            };
         }
-        %line = ('value' => "",             'text' => '---Biblio---' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "",             'text' => '---Biblio---' };
                foreach(qw(title author serial)) {
-               %line = ('value' => "biblio.$_", 'text' => ucfirst($_));
-               push @SQLfieldname, \%line;
+               push @SQLfieldname, { 'value' => "biblio.$_", 'text' => ucfirst($_) };
                }
     }
     else {
         $sth2 = $dbh->prepare("SHOW COLUMNS from biblio");
         $sth2->execute;
-        %line = ( 'value' => "", 'text' => '---BIBLIO---' );
+        push @SQLfieldname, { 'value' => "", 'text' => '---BIBLIO---' };
 
-        push @SQLfieldname, \%line;
         while ( ( my $field ) = $sth2->fetchrow_array ) {
-
-# note : %line is redefined, otherwise \%line contains the same value for every entry of the list
-            my %line = ( 'value' => "biblio." . $field, 'text' => "biblio." . $field );
-            push @SQLfieldname, \%line;
+            push @SQLfieldname, { 'value' => "biblio." . $field, 'text' => "biblio." . $field };
         }
         $sth2 = $dbh->prepare("SHOW COLUMNS from biblioitems");
         $sth2->execute;
-        %line = ( 'value' => "", 'text' => '---BIBLIOITEMS---' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "", 'text' => '---BIBLIOITEMS---' };
         while ( ( my $field ) = $sth2->fetchrow_array ) {
-            %line = (
+            push @SQLfieldname, {
                 'value' => "biblioitems." . $field,
                 'text'  => "biblioitems." . $field
-            );
-            push @SQLfieldname, \%line;
+            };
         }
-        %line = ( 'value' => "", 'text' => '---ITEMS---' );
-        push @SQLfieldname, \%line;
-        %line = ( 'value' => "items.content", 'text' => 'items.content' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "", 'text' => '---ITEMS---' };
+        push @SQLfieldname, { 'value' => "items.content", 'text' => 'items.content' };
 
         $sth2 = $dbh->prepare("SHOW COLUMNS from borrowers");
         $sth2->execute;
-        %line = ( 'value' => "", 'text' => '---BORROWERS---' );
-        push @SQLfieldname, \%line;
+        push @SQLfieldname, { 'value' => "", 'text' => '---BORROWERS---' };
         while ( ( my $field ) = $sth2->fetchrow_array ) {
-            %line = (
+            push @SQLfieldname, {
                 'value' => "borrowers." . $field,
                 'text'  => "borrowers." . $field
-            );
-            push @SQLfieldname, \%line;
+            };
         }
     }
     if ($code) {