Bug 19040: [QA Follow-up] Adjust embed_items parameter in showdiffmarc

[koha.git] / tools / showdiffmarc.pl

diff --git a/tools/showdiffmarc.pl b/tools/showdiffmarc.pl
index e0e0f7c..0c585a4 100755 (executable)
--- a/tools/showdiffmarc.pl
+++ b/tools/showdiffmarc.pl
@@ -8,7 +8,7 @@
 #
 # Koha is free software; you can redistribute it and/or modify it under the
 # terms of the GNU General Public License as published by the Free Software
-# Foundation; either version 2 of the License, or (at your option) any later
+# Foundation; either version 3 of the License, or (at your option) any later
 # version.
 #
 # Koha is distributed in the hope that it will be useful, but WITHOUT ANY
@@ -19,12 +19,10 @@
 # with Koha; if not, write to the Free Software Foundation, Inc.,
 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
 
-use strict;
-use warnings;
+use Modern::Perl;
 
 # standard or CPAN modules used
-use CGI qw(:standard);
-use DBI;
+use CGI qw(:standard -utf8);
 
 # Koha modules used
 use C4::Context;
@@ -32,68 +30,67 @@ use C4::Output;
 use C4::Auth;
 use C4::Biblio;
 use C4::ImportBatch;
-use XML::LibXSLT;
-use XML::LibXML;
 
+use Koha::Biblios;
 
 # Input params
 my $input        = new CGI;
 my $biblionumber = $input->param('id');
 my $importid     = $input->param('importid');
+my $batchid      = $input->param('batchid');
 
+if ( not $biblionumber or not $importid ) {
+    print $input->redirect("/cgi-bin/koha/errors/404.pl");
+    exit;
+}
 
-if ( $biblionumber and $importid ) {
-
-    # Init vars
-    my ($recordBiblionumber, $recordImportid, $biblioTitle, $importTitle, $formatted1, $formatted2,
-        $errorFormatted1, $errorFormatted2);
-
-
-    # Prepare template
-    my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
-        {
-            template_name   => "tools/showdiffmarc.tt",
-            query           => $input,
-            type            => "intranet",
-            authnotrequired => 0,
-            flagsrequired   => { catalogue => 1  },
-            debug           => 1,
-        }
-    );
-
-
-    $recordBiblionumber =GetMarcBiblio($biblionumber);
-    if( $recordBiblionumber ) {
-        $formatted1 = $recordBiblionumber->as_formatted;
-        my $data = GetBiblioData($biblionumber);
-        $biblioTitle = $data->{title};
-    } else {
-        $errorFormatted1 = 1;
-    }
-
-    my ($marc,$encoding) = GetImportRecordMarc($importid);
-    if( $marc ) {
-        $recordImportid = MARC::Record->new_from_usmarc($marc) ;
-        $formatted2 = $recordImportid->as_formatted;
-        my $biblio = GetImportBiblios($importid);
-        $importTitle = $biblio->[0]->{'title'};
-    } else {
-        $errorFormatted2 = 1;
+# Init vars
+my ($recordBiblionumber, $recordImportid, $biblioTitle, $importTitle, $formatted1, $formatted2, $errorFormatted1, $errorFormatted2);
+
+# Prepare template
+my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
+    {
+        template_name   => "tools/showdiffmarc.tt",
+        query           => $input,
+        type            => "intranet",
+        authnotrequired => 0,
+        flagsrequired   => { tools => 'manage_staged_marc' },
+        debug           => 1,
     }
+);
+
+$recordBiblionumber = GetMarcBiblio({
+    biblionumber => $biblionumber,
+    embed_items  => 1,
+});
+if( $recordBiblionumber ) {
+    $formatted1 = $recordBiblionumber->as_formatted;
+    my $biblio = Koha::Biblios->find( $biblionumber );
+    $biblioTitle = $biblio->title;
+} else {
+    $errorFormatted1 = 1;
+}
 
-
-    $template->param(     SCRIPT_NAME => $ENV{'SCRIPT_NAME'},
-                        BIBLIONUMBER => $biblionumber,
-                        IMPORTID => $importid,
-                        BIBLIOTITLE => $biblioTitle,
-                        IMPORTTITLE => $importTitle,
-                        MARC_FORMATTED1 => $formatted1,
-                        MARC_FORMATTED2 => $formatted2,
-                        ERROR_FORMATTED1 => $errorFormatted1,
-                        ERROR_FORMATTED2 => $errorFormatted2
-                    );
-
-    output_html_with_http_headers $input, $cookie, $template->output;
+if( $importid ) {
+    $recordImportid = C4::ImportBatch::GetRecordFromImportBiblio( $importid, 'embed_items' );
+    $formatted2 = $recordImportid->as_formatted;
+    my $biblio = GetImportBiblios($importid);
+    $importTitle = $biblio->[0]->{'title'};
 } else {
-    exit;
+    $errorFormatted2 = 1;
 }
+
+$template->param(
+    SCRIPT_NAME      => '/cgi-bin/koha/tools/showdiffmarc.pl',
+    BIBLIONUMBER     => $biblionumber,
+    IMPORTID         => $importid,
+    BIBLIOTITLE      => $biblioTitle,
+    IMPORTTITLE      => $importTitle,
+    MARC_FORMATTED1  => $formatted1,
+    MARC_FORMATTED2  => $formatted2,
+    ERROR_FORMATTED1 => $errorFormatted1,
+    ERROR_FORMATTED2 => $errorFormatted2,
+    batchid          => $batchid
+);
+
+output_html_with_http_headers $input, $cookie, $template->output;