Bug 11559: (followup) Fix keyboard control bugs, make labels clickable

[koha.git] / xt / author / icondirectories.t

diff --git a/xt/author/icondirectories.t b/xt/author/icondirectories.t
index a4145fa..e5b0039 100644 (file)
--- a/xt/author/icondirectories.t
+++ b/xt/author/icondirectories.t
@@ -1,5 +1,20 @@
 #!/usr/bin/env perl
 
+# This file is part of Koha.
+#
+# Koha is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License as published by
+# the Free Software Foundation; either version 3 of the License, or
+# (at your option) any later version.
+#
+# Koha is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with Koha; if not, see <http://www.gnu.org/licenses>.
+
 =head1 NAME
 
 icondirectories.t - test to ensure that the two directories of icons
@@ -13,8 +28,7 @@ ensures that they are.
 
 =cut
 
-use strict;
-use warnings;
+use Modern::Perl;
 
 use lib qw( .. );
 
@@ -22,42 +36,59 @@ use Data::Dumper;
 use File::Find;
 use Test::More tests => 3;
 
-my $opac_icon_directory  = 'koha-tmpl/opac-tmpl/prog/itemtypeimg';
-my $staff_icon_directory = 'koha-tmpl/intranet-tmpl/prog/img/itemtypeimg';
-
-ok( -d $opac_icon_directory, "opac_icon_directory: $opac_icon_directory exists" );
-ok( -d $staff_icon_directory, "staff_icon_directory: $staff_icon_directory exists" );
+# hardcoded OPAC & STAFF dirs
+my $opac_dir  = 'koha-tmpl/opac-tmpl';
+my $staff_dir = 'koha-tmpl/intranet-tmpl';
 
-my $opac_icons; # hashref of filenames to sizes
-sub opac_wanted {
-    my $file = $File::Find::name;
-    $file =~ s/^$opac_icon_directory//;
-    $opac_icons->{ $file } = -s $_;
-}
+# Find OPAC themes
+opendir ( my $dh, $opac_dir ) or die "can't opendir $opac_dir: $!";
+my @opac_themes = grep { not /^\.|lib|js/ } readdir($dh);
+close $dh;
 
-find( \&opac_wanted, $opac_icon_directory );
+# Find STAFF themes
+opendir ( $dh, $staff_dir ) or die "can't opendir $staff_dir: $!";
+my @staff_themes = grep { not /^\.|lib|js/ } readdir($dh);
+close $dh;
 
-my $staff_icons; # hashref of filenames to sizes
-sub staff_wanted {
-    my $file = $File::Find::name;
-    $file =~ s/^$staff_icon_directory//;
-    $staff_icons->{ $file } = -s $_;
+# Check existence of OPAC icon dirs
+for my $theme ( @opac_themes ) {
+    my $test_dir = "$opac_dir/$theme/itemtypeimg";
+    ok( -d $test_dir, "opac_icon_directory: $test_dir exists" );
 }
-find( \&staff_wanted, $staff_icon_directory );
-
-is_deeply( $opac_icons, $staff_icons, "staff and OPAC icon directories have same contents" )
-  or diag( Data::Dumper->Dump( [ $opac_icons ], [ 'opac_icons' ] ) );
-
-
-
-
-
-
-
-
-
-
-
 
+# Check existence of STAFF icon dirs
+for my $theme ( @staff_themes ) {
+    my $test_dir = "$staff_dir/$theme/img/itemtypeimg";
+    ok( -d $test_dir, "staff_icon_directory: $test_dir exists" );
+}
 
+# Check for same contents on STAFF and OPAC icondirs
+# foreach STAFF theme
+for my $staff_theme ( @staff_themes ) {
+    my $staff_icons; # hashref of filenames to sizes
+    my $staff_icon_directory = "$staff_dir/$staff_theme/img/itemtypeimg";
+    my $staff_wanted = sub {
+        my $file = $File::Find::name;
+        $file =~ s/^$staff_icon_directory//;
+        $staff_icons->{ $file } = -s $_;
+    };
+    find( { wanted => $staff_wanted }, $staff_icon_directory );
+
+    # foreach OPAC theme
+    for my $opac_theme ( @opac_themes ) {
+        next if ( $opac_theme =~ /ccsr/ );  # FIXME: skip CCSR opac theme, it fails and there is no point to fix it
+        my $opac_icons; # hashref of filenames to sizes
+        my $opac_icon_directory  = "$opac_dir/$opac_theme/itemtypeimg";
+        my $opac_wanted  = sub {
+            my $file = $File::Find::name;
+            $file =~ s/^$opac_icon_directory//;
+            $opac_icons->{ $file } = -s $_;
+        };
+        find( { wanted => $opac_wanted }, $opac_icon_directory );
+
+        is_deeply( $opac_icons, $staff_icons, "STAFF $staff_theme and OPAC $opac_theme icon directories have same contents" )
+            or diag( Data::Dumper->Dump( [ $opac_icons ], [ 'opac_icons' ] ) );
+    }
+}
 
+1;