koha.git
14 years agoUpdating update.pl to work locally
Chris Cormack [Tue, 22 Sep 2009 01:07:21 +0000 (13:07 +1200)]
Updating update.pl to work locally

14 years agoFollowup updating translation process
Henri-Damien LAURENT [Mon, 21 Sep 2009 21:47:59 +0000 (23:47 +0200)]
Followup updating translation process

14 years agoAdding xsl strings to po
Henri-Damien LAURENT [Wed, 2 Sep 2009 15:38:36 +0000 (17:38 +0200)]
Adding xsl strings to po

xsl strings are now taken into account.
This is a first draft.
Some parameters of the functions will be taken into account
and <xsl> tags are not translated

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoC4/Search.pm followup auto_truncation
Henri-Damien LAURENT [Mon, 21 Sep 2009 21:04:46 +0000 (23:04 +0200)]
C4/Search.pm followup auto_truncation

Auto_truncation is used even though exact search selected.
This patch removes this side effect

14 years agoFrench canadian updates
Chris Cormack [Mon, 21 Sep 2009 21:02:16 +0000 (09:02 +1200)]
French canadian updates

14 years ago(bug #3592) fix scan of terms
Henri-Damien LAURENT [Mon, 21 Sep 2009 20:39:49 +0000 (22:39 +0200)]
(bug #3592) fix scan of terms

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years ago[followup](bug #3584) fix variable name
Nahuel ANGELINETTI [Wed, 9 Sep 2009 09:41:34 +0000 (11:41 +0200)]
[followup](bug #3584) fix variable name

14 years ago[follow up](bug #3584) improve ccl detection
Nahuel ANGELINETTI [Wed, 9 Sep 2009 07:29:03 +0000 (09:29 +0200)]
[follow up](bug #3584) improve ccl detection

This improve the detection of ccl queries, and do not duplicate the "ccl=" value.

14 years ago(bug #3584) detect ccl queries
Nahuel ANGELINETTI [Tue, 8 Sep 2009 12:03:28 +0000 (14:03 +0200)]
(bug #3584) detect ccl queries

This patch C4::Search::buildQuery to detect ccl queries, and let zebra to parse them.
And set a default index "kw" if not specified.

14 years agoAuthoritiesMarc.pm Improvements
Henri-Damien LAURENT [Mon, 21 Sep 2009 20:23:23 +0000 (22:23 +0200)]
AuthoritiesMarc.pm Improvements

Users are now able to list authorities without entering a search term

14 years ago(bug #3653) fix list of recent checks-in
Nahuel ANGELINETTI [Mon, 21 Sep 2009 15:45:20 +0000 (17:45 +0200)]
(bug #3653) fix list of recent checks-in

bad use of a variable name, this patch fix it.

14 years agoFollowup C4::Circulation.pm previous commit
Henri-Damien LAURENT [Mon, 21 Sep 2009 15:23:38 +0000 (17:23 +0200)]
Followup C4::Circulation.pm previous commit

previous commit would generate warnings on compilation

14 years agoBugFix 2726 Resending
Henri-Damien LAURENT [Tue, 15 Sep 2009 19:39:45 +0000 (21:39 +0200)]
BugFix 2726 Resending

This bugfix was first sent By Michael Hafen but may not have made its way into LDAP Authentication

14 years ago(bug #3651) sending baskets and shelves
Nahuel ANGELINETTI [Mon, 21 Sep 2009 13:08:27 +0000 (15:08 +0200)]
(bug #3651) sending baskets and shelves

this patch restrict the send of baskets and shelves to authenticated users only, and show their surname/firstname in the e-mail, so the receiver will know who sent the list.

14 years agoreserve/request.pl Fixing superlibrarian flag checking
Henri-Damien LAURENT [Mon, 21 Sep 2009 14:32:40 +0000 (16:32 +0200)]
reserve/request.pl Fixing superlibrarian flag checking

superlibrarian flag was checked without %2 on reserve/request.pl

14 years agoRemoving call to a 3.2 function
Henri-Damien LAURENT [Mon, 21 Sep 2009 14:31:43 +0000 (16:31 +0200)]
Removing call to a 3.2 function

14 years agoBug fix : click on confirm Bellow on opac-shelves
Henri-Damien LAURENT [Mon, 21 Sep 2009 14:28:48 +0000 (16:28 +0200)]
Bug fix : click on confirm Bellow on opac-shelves

Click on confirm Bellow was not showing the button up, or button was not really obvious
This adds a button right bellow the message

14 years agoWrong update in UpdateHoldingBranch
Henri-Damien LAURENT [Mon, 21 Sep 2009 13:08:20 +0000 (15:08 +0200)]
Wrong update in UpdateHoldingBranch

14 years agoBug fixing Merge problem on opac-shelves.tmpl
Henri-Damien LAURENT [Mon, 21 Sep 2009 12:54:57 +0000 (14:54 +0200)]
Bug fixing Merge problem on opac-shelves.tmpl

14 years agoFixing AddReturn Bad Merge
Henri-Damien LAURENT [Mon, 21 Sep 2009 08:23:57 +0000 (10:23 +0200)]
Fixing AddReturn Bad Merge

14 years agoPolish language updates
Chris Cormack [Sun, 20 Sep 2009 01:54:37 +0000 (13:54 +1200)]
Polish language updates

14 years agoccl querys adding idx in detail.tmpl
Henri-Damien LAURENT [Sat, 19 Sep 2009 21:57:16 +0000 (23:57 +0200)]
ccl querys adding idx in detail.tmpl

14 years ago[3.0.x](bug #3597) Adds a check in "delete all items"
Jean-André Santoni [Thu, 10 Sep 2009 08:10:56 +0000 (10:10 +0200)]
[3.0.x](bug #3597) Adds a check in "delete all items"

This patch replaces DellItem by DellItemCheck in "delete all items".

14 years ago(bug #3598) normalize isbn
Nahuel ANGELINETTI [Thu, 10 Sep 2009 12:52:01 +0000 (14:52 +0200)]
(bug #3598) normalize isbn

This patch normalize isbn's of notices imported via z39.50

14 years agobug 3614 followup
Galen Charlton [Tue, 15 Sep 2009 13:19:57 +0000 (09:19 -0400)]
bug 3614 followup

* renamed default_ind_to_space to _default_ind_to_space
  as it is an internal function
* added calls to _default_ind_to_space in other places

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3614 Fix incorrect setting of indicator
Colin Campbell [Mon, 14 Sep 2009 18:26:47 +0000 (19:26 +0100)]
bug 3614 Fix incorrect setting of indicator

Pull the code into its own subr so that the dangers of
inaccurate copy & paste are avoided in future

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoEnable warnings in serial scripts
Henri-Damien LAURENT [Sat, 19 Sep 2009 21:28:48 +0000 (23:28 +0200)]
Enable warnings in serial scripts

Remove some superfluous variables
Simplify some loops over lists
Fix generated warnings
Strip whitespace from line endings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3602: Fixes a log error for opac-search.pl if expanded_options is not defined.
Garry Collum [Sat, 12 Sep 2009 16:27:18 +0000 (12:27 -0400)]
Bug 3602: Fixes a log error for opac-search.pl if expanded_options is not defined.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3603: Fixes XHMTL errors in catalogue/showmarc.tmpl
Garry Collum [Sun, 13 Sep 2009 14:41:43 +0000 (10:41 -0400)]
Bug 3603: Fixes XHMTL errors in catalogue/showmarc.tmpl

Missing <title> tags, missing </head> and <body>, extra </div>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3604: Fixes invalid XHTML in manage-marc-import.tmpl.
Garry Collum [Sun, 13 Sep 2009 15:08:35 +0000 (11:08 -0400)]
Bug 3604: Fixes invalid XHTML in manage-marc-import.tmpl.

Also adds zebra striping to <table>

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3606: fixes 'last 50 items only' link in members/readingrec.tmpl.
Garry Collum [Mon, 14 Sep 2009 02:15:31 +0000 (22:15 -0400)]
Bug 3606: fixes 'last 50 items only' link in members/readingrec.tmpl.

If a staff member clicked on 'Show all items' in a patron's reading record, and
then clicked on 'show last 50 items only,' all of the records would still be
shown.  The link for the 'last 50' items contains a switch for 'limit=full'
instead of 'limit=50'.

Also fixes some XHTML errors.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoAvoid potentially unnecessary database call in Auth
Michael Hafen [Mon, 14 Sep 2009 15:07:57 +0000 (09:07 -0600)]
Avoid potentially unnecessary database call in Auth

Auth, after verifying the session/logging in the user, calls to the database
to get the users borrowernumber.  This call is probably unnecessary because
borrowernumber is part of userenv.  Check userenv before going to the database.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoFollow-up for Bug 3524, adding itemtype text description
Owen Leonard [Thu, 10 Sep 2009 15:19:51 +0000 (10:19 -0500)]
Follow-up for Bug 3524, adding itemtype text description

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoHandle null-or-empty to Charset::StripNonXmlChars
J. David Bavousett [Thu, 10 Sep 2009 15:10:50 +0000 (11:10 -0400)]
Handle null-or-empty to Charset::StripNonXmlChars

When rebuild_zebra.pl is run from cron, there is an occasional error
of the form:

Use of uninitialized value $str in substitution (s///) at /home/ebpl/kohaclone/C4/Charset.pm line 304.

This error is occuring when the string that is fed to Charset::StripNonXmlChars
is null or undefined, for some reason.

This fix will handle the null-or-empty condition, and thus suppress the error.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 2505: Enabled warnings in tools-home.pl, holidays.pl, exceptionHolidays.pl, and...
Garry Collum [Fri, 11 Sep 2009 15:26:57 +0000 (11:26 -0400)]
Bug 2505: Enabled warnings in tools-home.pl, holidays.pl, exceptionHolidays.pl, and newHolidays.pl

Tested for warnings after addition of 'use warnings.' No warnings were generated.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoBug 3601: Cleanup of holiday.tmpl
Garry Collum [Fri, 11 Sep 2009 15:41:38 +0000 (11:41 -0400)]
Bug 3601: Cleanup of holiday.tmpl

Changes the word 'location' to 'library.'
Expands the description of 'exception.'

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agodon't die if a bad date is specified
Nahuel ANGELINETTI [Wed, 16 Sep 2009 10:29:43 +0000 (12:29 +0200)]
don't die if a bad date is specified

14 years ago(bug #3575) fix opac-detail.pl
Nahuel ANGELINETTI [Thu, 3 Sep 2009 08:17:19 +0000 (10:17 +0200)]
(bug #3575) fix opac-detail.pl

This delete an useless "use C4::Serials"(there are 2).
And fix the opac-detail template, to fix a variable conflict for serials.

14 years ago[3.0.x](bug #3563) This replaces the library name by the branchname attached to the...
Henri-Damien LAURENT [Sat, 19 Sep 2009 21:05:34 +0000 (23:05 +0200)]
[3.0.x](bug #3563) This replaces the library name by the branchname attached to the subscription, and hide streetaddesses in serials routing

In routing-preview, the title should be the branchname attached to the
subscription instead of the libraryname.
And showing the streetaddress of the members is useless, and harm privacy.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years ago[followup](bug #3550) show subtitle in opac search result
Nahuel ANGELINETTI [Wed, 26 Aug 2009 11:55:37 +0000 (13:55 +0200)]
[followup](bug #3550) show subtitle in opac search result

This fix the opac search result, to show subtitle using GetRecordValue.

14 years ago[followup](bug #3370) export function and fix return
Nahuel ANGELINETTI [Tue, 25 Aug 2009 14:06:57 +0000 (16:06 +0200)]
[followup](bug #3370) export function and fix return

this add GetRecordValue in exported functions, and made it to return a ref.

14 years ago[3.0.x](bug #3549) Sorted framework options in the dropdown menu
Henri-Damien LAURENT [Sat, 19 Sep 2009 20:57:16 +0000 (22:57 +0200)]
[3.0.x](bug #3549) Sorted framework options in the dropdown menu

In addbook.pl, the framework options are sorted in random order. They should be
sorted in alphabetical order of value or code.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years ago(bug #3505) fix 210c and 225a unimarc's plugins
Henri-Damien LAURENT [Sat, 19 Sep 2009 20:55:30 +0000 (22:55 +0200)]
(bug #3505) fix 210c and 225a unimarc's plugins

This fix the 2 plugins, make 225a to work with koha 3.0, and fix 210c to be xhtml valid

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years ago[followup](bug #3370) fix the "Get" function name
Nahuel ANGELINETTI [Tue, 7 Jul 2009 13:42:32 +0000 (15:42 +0200)]
[followup](bug #3370) fix the "Get" function name

This fix the problem with the Get function in C4::Biblio, the new name is GetRecordValue and located in export_ok.

14 years ago(bug #3395) fix unimarc plugin 225$a
Henri-Damien LAURENT [Sat, 19 Sep 2009 20:36:57 +0000 (22:36 +0200)]
(bug #3395) fix unimarc plugin 225$a

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years ago(bug #3370) add keyword to MARC field mapping
Nahuel ANGELINETTI [Tue, 30 Jun 2009 14:04:05 +0000 (16:04 +0200)]
(bug #3370) add keyword to MARC field mapping

This add the support of keyword => MARC field mapping, ton abstract the relation between human readable fields like subtitle, title, authors, location, ... and MARC fields in each framework.
This will allow to koha developper to be more flexible with each framework and don't care about the MARC flavour, just require some "keywords" to the user.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years ago(bug #3550) use GetRecordValue to retrieve subtitle
Nahuel ANGELINETTI [Tue, 25 Aug 2009 09:53:50 +0000 (11:53 +0200)]
(bug #3550) use GetRecordValue to retrieve subtitle

This patch, is the first use of GetRecordValue, that use the Field mapping.
It retrieve the subtitle in Intranet using it, instead of the use an old function that doesn't work anymore.
This is a way to made koha more generic with each framework.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years agoadditem : change GetBranches to GetBranchesLoop
Henri-Damien LAURENT [Sat, 19 Sep 2009 19:46:07 +0000 (21:46 +0200)]
additem : change GetBranches to GetBranchesLoop

14 years agoLots of language updates
Chris Cormack [Sat, 19 Sep 2009 01:36:37 +0000 (13:36 +1200)]
Lots of language updates

14 years agoMarkup corrections and opac-IBDdetail.pl fixing
Henri-Damien LAURENT [Thu, 17 Sep 2009 13:24:54 +0000 (15:24 +0200)]
Markup corrections and opac-IBDdetail.pl fixing

14 years agofollowup Amazon.pm bugfix fd4ed72988a0a00a97a9a74bd89b017453bb276b
Henri-Damien LAURENT [Thu, 17 Sep 2009 12:51:27 +0000 (14:51 +0200)]
followup Amazon.pm bugfix fd4ed72988a0a00a97a9a74bd89b017453bb276b

14 years agoBug Fixing Merge problem
Henri-Damien LAURENT [Thu, 17 Sep 2009 09:39:49 +0000 (11:39 +0200)]
Bug Fixing Merge problem

JS in moremember.tmpl was bogus

14 years agoTranslating unimarc_leader plugin in english
Henri-Damien LAURENT [Thu, 13 Aug 2009 13:07:03 +0000 (15:07 +0200)]
Translating unimarc_leader plugin in english

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agoLanguage updates
Chris Cormack [Thu, 17 Sep 2009 07:30:42 +0000 (19:30 +1200)]
Language updates

14 years agoBug Fixing updatedatabase
Henri-Damien LAURENT [Thu, 17 Sep 2009 07:16:51 +0000 (09:16 +0200)]
Bug Fixing updatedatabase

14 years agoBug Fixing Amazon.pm would not compile
Henri-Damien LAURENT [Wed, 16 Sep 2009 16:36:40 +0000 (18:36 +0200)]
Bug Fixing Amazon.pm would not compile

missing call of C4::External::Amazon in opac-ISBDdetail.pl
@aws was not defined

14 years agoThe rest of the staff interface updated
Chris Cormack [Tue, 15 Sep 2009 07:12:45 +0000 (19:12 +1200)]
The rest of the staff interface updated

14 years agoArmenian staff updates
Chris Cormack [Tue, 15 Sep 2009 04:59:32 +0000 (16:59 +1200)]
Armenian staff updates

14 years agoMalaysian and Portuguese staff updates
Chris Cormack [Tue, 15 Sep 2009 04:58:22 +0000 (16:58 +1200)]
Malaysian and Portuguese staff updates

14 years agoStaff language updates
Chris Cormack [Tue, 15 Sep 2009 04:57:01 +0000 (16:57 +1200)]
Staff language updates

14 years agoValencian staff
Chris Cormack [Tue, 15 Sep 2009 04:55:44 +0000 (16:55 +1200)]
Valencian staff

14 years agoSerbian staff update
Chris Cormack [Tue, 15 Sep 2009 04:53:11 +0000 (16:53 +1200)]
Serbian staff update

14 years agoCzech staff updates
Chris Cormack [Tue, 15 Sep 2009 04:52:35 +0000 (16:52 +1200)]
Czech staff updates

14 years agoLast of the opac updates
Chris Cormack [Tue, 15 Sep 2009 02:48:52 +0000 (14:48 +1200)]
Last of the opac updates

14 years agoMore language updates
Chris Cormack [Tue, 15 Sep 2009 02:47:55 +0000 (14:47 +1200)]
More language updates

14 years agoMore language updates
Chris Cormack [Tue, 15 Sep 2009 02:41:20 +0000 (14:41 +1200)]
More language updates

14 years agoHindi, Tetun, Thai, Tagalog, Turkish, Urdu and Ukranian opac updates
Chris Cormack [Tue, 15 Sep 2009 02:37:49 +0000 (14:37 +1200)]
Hindi, Tetun, Thai, Tagalog, Turkish, Urdu and Ukranian opac updates

14 years agoSpanish, Persian and Galician opac updates
Chris Cormack [Tue, 15 Sep 2009 02:35:09 +0000 (14:35 +1200)]
Spanish, Persian and Galician opac updates

14 years agoFrench (France), French (Canada) and Hebrew opac updates
Chris Cormack [Tue, 15 Sep 2009 02:29:49 +0000 (14:29 +1200)]
French (France), French (Canada) and Hebrew opac updates

14 years agoAmharic, German and English NZ opac updates
Chris Cormack [Tue, 15 Sep 2009 02:28:40 +0000 (14:28 +1200)]
Amharic, German and English NZ opac updates

14 years agoDanish and Bulgarian opac updates
Chris Cormack [Tue, 15 Sep 2009 02:26:34 +0000 (14:26 +1200)]
Danish and Bulgarian opac updates

14 years agoBengali, Arabic and Azerbaijanian opac updates
Chris Cormack [Tue, 15 Sep 2009 02:24:16 +0000 (14:24 +1200)]
Bengali, Arabic and Azerbaijanian opac updates

14 years agoIndonesian opac updates
Chris Cormack [Tue, 15 Sep 2009 02:17:24 +0000 (14:17 +1200)]
Indonesian opac updates

14 years agoGreek Opac updates
Chris Cormack [Tue, 15 Sep 2009 02:16:24 +0000 (14:16 +1200)]
Greek Opac updates

14 years agoCzech and Catalan opac updates
Chris Cormack [Tue, 15 Sep 2009 02:14:19 +0000 (14:14 +1200)]
Czech and Catalan opac updates

14 years agoFinnish and Chinese updates
Chris Cormack [Tue, 15 Sep 2009 02:11:10 +0000 (14:11 +1200)]
Finnish and Chinese updates

14 years agoFixing some leftover conflict
Chris Cormack [Tue, 15 Sep 2009 02:09:01 +0000 (14:09 +1200)]
Fixing some leftover conflict

14 years agoFixing mess leftover from conflict
Chris Cormack [Tue, 15 Sep 2009 01:55:19 +0000 (13:55 +1200)]
Fixing mess leftover from conflict

14 years agoStarting work updating translations
Chris Cormack [Tue, 15 Sep 2009 01:49:44 +0000 (13:49 +1200)]
Starting work updating translations

14 years agoFixing record.abs for authorities and MARC21
Chris Cormack [Mon, 14 Sep 2009 21:32:18 +0000 (09:32 +1200)]
Fixing record.abs for authorities and MARC21

14 years agoMore fixes to the shelves test
Chris Cormack [Mon, 14 Sep 2009 08:17:43 +0000 (20:17 +1200)]
More fixes to the shelves test

14 years agoFixing the tests for VirtualShelves, still a bit more to do
Chris Cormack [Sun, 13 Sep 2009 17:52:19 +0000 (05:52 +1200)]
Fixing the tests for VirtualShelves, still a bit more to do

14 years agoGet rid of a few warnings in the bulkmarcimport script: C4/Biblio.pm, hunks #1, ...
Sébastien Hinderer [Thu, 3 Sep 2009 18:11:09 +0000 (20:11 +0200)]
Get rid of a few warnings in the bulkmarcimport script: C4/Biblio.pm, hunks #1, #2: a warning occurring in NoZebra configurations. C4/Biblio.pm hunk #3: warning occurring in Unimarc MARC flavour. misc/migration_tools/bulkmarcimport.pl hunk #1: warning occurring when no default format is specified on command-line with -m switch.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years agobug 2505: remove additional warning messages
Galen Charlton [Sat, 5 Sep 2009 23:50:51 +0000 (19:50 -0400)]
bug 2505: remove additional warning messages

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years agoenable warnings in overduerules.pl Call GetBranchesLoop instead of duplicating code...
Colin Campbell [Fri, 4 Sep 2009 13:14:01 +0000 (14:14 +0100)]
enable warnings in overduerules.pl Call GetBranchesLoop instead of duplicating code make countletters a count as it says check for definedness before doing string comparisons do as not to generate warnings

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years agobugfix breeding results of cataloging search has wrong id
Michael Hafen [Tue, 1 Sep 2009 16:03:37 +0000 (10:03 -0600)]
bugfix breeding results of cataloging search has wrong id

The breeding id, rather than coming from the database, was set by a counter.
Not so good links in the search results that way.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years agoBug Fixing 3568 : Untranslated strings
Henri-Damien LAURENT [Tue, 1 Sep 2009 08:34:08 +0000 (10:34 +0200)]
Bug Fixing 3568 : Untranslated strings

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years agoSquashing Merge Fix and followup: renamed _GetCirculationBranch
Henri-Damien LAURENT [Thu, 10 Sep 2009 14:59:14 +0000 (16:59 +0200)]
Squashing Merge Fix and followup: renamed _GetCirculationBranch

Merge Fix Followup to 7e2bf9e

14 years agobug 3204: tweaks to AWS request signing
Galen Charlton [Thu, 13 Aug 2009 13:25:34 +0000 (09:25 -0400)]
bug 3204: tweaks to AWS request signing

* Add AWSPrivateKey system preference to the
  Enhanced Content tab in the syspref editor
* Now warns to log if attempting to use
  the Amazon API without setting AWSPrivateKey

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3204: add AWSPrivateKey syspref (DBrev 04.15)
Henri-Damien LAURENT [Thu, 10 Sep 2009 14:34:30 +0000 (16:34 +0200)]
bug 3204: add AWSPrivateKey syspref (DBrev 04.15)

The AWSPrivateKey syspref is describe more fully
in a previous commit, but to summarize, it should
contain the Amazon Web Services Secret Access Key
required by Amazon to sign requests to their
Product Advertising API.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years agobug 3204: followup to fix AWS request signing
Galen Charlton [Thu, 13 Aug 2009 12:55:25 +0000 (08:55 -0400)]
bug 3204: followup to fix AWS request signing

[1] There were some ersataz spaces in the string
    being signed.
[2] AWS expects a trailing '=' in the Base64 signature

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
14 years agobug 3204: implement request signing for Amazon Web Services
Henri-Damien LAURENT [Tue, 7 Jul 2009 13:44:26 +0000 (15:44 +0200)]
bug 3204: implement request signing for Amazon Web Services

After 2009-08-15, Amazon Web Services will expect that
all requests to the Product Advertising API, which is what
Koha uses for retrieving reviews and other enhanced content
from Amazon, include signatures.  This patch and
subsequenct patches implement this functionality.

What this means in practice (assuming the user has elected
to use any enhanced content from Amazon) is that

[1] The user must get a Amazon Secret Access Key.  This can
    be done by logging in to the user's AWS account
    at (e.g.) http://aws.amazon.com/, going to the 'Access Identifiers'
    page, and from there retrieving and/or creating a new Secret
    Access Key.

[2] The contents of the Secret Access Key should then be
    entered into the new AWSPrivateKey system preference.

Once that is done, grabbing reviews and table of contents from Amazon
should work as normal.  If the user doesn't do this before 2009-08-15,
reviews and TOCs will no longer be supplied from Amazon, although there
should be no crashes - the content will simply not show up.

Note that the requirement to sign requests does *NOT* appear to apply
to simply displaying book covers from Amazon.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years agoCorrecting some selectors to conform with upgraded jQuery syntax (see Bug 3297).
Henri-Damien LAURENT [Wed, 9 Sep 2009 21:46:31 +0000 (23:46 +0200)]
Correcting some selectors to conform with upgraded jQuery syntax (see Bug 3297).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
14 years agoBug 3532 show lost, damaged statuses on patron record
Henri-Damien LAURENT [Wed, 9 Sep 2009 21:42:58 +0000 (23:42 +0200)]
Bug 3532 show lost, damaged statuses on patron record

The patron record Details tab list of checkouts does not show lost, long overdue, claims returned, or damaged status, only that an item is overdue.  Added a check for lost and damaged statuses and a display of any matching statuses to the patron Details tab.

(revised version to drop unneeded lines from moremember.tmpl file)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
14 years ago[replaceprevious](bug #3562) fix returning document in another branch
Henri-Damien LAURENT [Wed, 9 Sep 2009 21:23:06 +0000 (23:23 +0200)]
[replaceprevious](bug #3562) fix returning document in another branch

there is no transfert alert if you make a return in another branch than the homebranch.

14 years agoFixing merge on moremember.pl (Deletion when IndependantBranches)
Henri-Damien LAURENT [Wed, 9 Sep 2009 07:10:48 +0000 (09:10 +0200)]
Fixing merge on moremember.pl (Deletion when IndependantBranches)

14 years ago(bug #3459) fix opac-topissue to take care of ccode
Nahuel ANGELINETTI [Fri, 31 Jul 2009 15:05:27 +0000 (17:05 +0200)]
(bug #3459) fix opac-topissue to take care of ccode

This bugfix, add a conditionnal sql request, that get the "ccode" document type if AdvancedSearchTypes is positionned to ccode.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
14 years ago(bug #2829) fix some mistakes extracting editor segment
Nahuel ANGELINETTI [Wed, 19 Aug 2009 13:22:24 +0000 (15:22 +0200)]
(bug #2829) fix some mistakes extracting editor segment

This patch fix how to extract the editor segment, and improve ISBN10/13 support.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
14 years agoRemoving memberofinstitution management
Henri-Damien LAURENT [Mon, 31 Aug 2009 08:58:11 +0000 (10:58 +0200)]
Removing memberofinstitution management

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
14 years agoBug Fixing 3542 : searching for authority in cataloguing
Henri-Damien LAURENT [Thu, 20 Aug 2009 15:18:24 +0000 (17:18 +0200)]
Bug Fixing 3542 : searching for authority in cataloguing

There was a problem in the query building
and PERL is quite picky with empty data in arrays so setting empty elements to undef

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>