bugfix: pagination bar has an empty page at the end

There are a few pages where the pagination_bar() call produces an empty page
when the number of results is a multiple of the results per page.  Looking at
getnbpages() I see the right way to do it.  So I changed these few pages to
either use getnbpages() or calculate the number of pages the same way.

diff --git a/authorities/authorities-home.pl b/authorities/authorities-home.pl
index d80acc4..1eb58b0 100755 (executable)
--- a/authorities/authorities-home.pl
+++ b/authorities/authorities-home.pl
@@ -125,7 +125,7 @@ if ( $op eq "do_search" ) {
 
     $template->param(
         pagination_bar => pagination_bar(
-            $base_url,  int( $total / $resultsperpage ) + 1,
+            $base_url,  getnbpages( $total, $resultsperpage ),
             $startfrom, 'startfrom'
         ),
         total     => $total,

diff --git a/labels/pcard-member-search.pl b/labels/pcard-member-search.pl
index 1ff5cf1..3842bd0 100755 (executable)
--- a/labels/pcard-member-search.pl
+++ b/labels/pcard-member-search.pl
@@ -141,7 +141,7 @@ my $base_url =
 
 $template->param(
     paginationbar => pagination_bar(
-        $base_url,  int( $count / $resultsperpage ) + 1,
+        $base_url,  int( ($count - 1) / $resultsperpage ) + 1,
         $startfrom, 'startfrom'
     ),
     startfrom => $startfrom,

diff --git a/members/member.pl b/members/member.pl
index 6d42b45..13daa0d 100755 (executable)
--- a/members/member.pl
+++ b/members/member.pl
@@ -138,7 +138,7 @@ my $base_url =
 
 $template->param(
     paginationbar => pagination_bar(
-        $base_url,  int( $count / $resultsperpage ) + 1,
+        $base_url,  int( ($count - 1) / $resultsperpage ) + 1,
         $startfrom, 'startfrom'
     ),
     startfrom => $startfrom,