Bug 9002 - Remove Problematic Logic from Patron Messaging Preferences Form

If you do not have SMSSendDriver set and you do not have a message_transport_type of "sms", you will get an extra table column filled with a hyphen "-" and no corresponding table heading in the Patron Messaging Preferences table.

This pushes the table out of alignment so the email checkbox goes under "Digests Only?", the digests checkbox goes under "Do not notify", and the Do not notify checkbox is pushed to the side with no heading.

Signed-off-by: Sophie Meynieux <sophie.meynieux@biblibre.com>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Tested for regressions.
All tests and QA script pass.
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
index b08c5ca..ed6b067 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/messaging-preference-form.inc
@@ -52,7 +52,7 @@
       [% ELSE %]
       <td>-</td>
       [% END %]
-      [% IF ( messaging_preference.transport_sms ) %]
+
       [% IF ( SMSSendDriver ) %]<td>
           [% IF ( messaging_form_inactive ) %]
               [% IF ( messaging_preference.transports_sms ) %]
@@ -80,9 +80,6 @@
               [% END %]
           [% END %]
       </td>[% END %]
-      [% ELSE %]
-      <td>-</td>
-      [% END %]
 
       [% IF ( TalkingTechItivaPhone ) %]<td>
           [% IF ( messaging_form_inactive ) %]