Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

diff --git a/t/db_dependent/Koha/ItemTypes.t b/t/db_dependent/Koha/ItemTypes.t
index 21f870d..ebd3597 100755 (executable)
--- a/t/db_dependent/Koha/ItemTypes.t
+++ b/t/db_dependent/Koha/ItemTypes.t
@@ -51,6 +51,8 @@ Koha::ItemType->new(
         summary        => 'summary',
         checkinmsg     => 'checkinmsg',
         checkinmsgtype => 'checkinmsgtype',
+        processfee         => '0.00',
+        defaultreplacecost => '0.00',
     }
 )->store;
 
@@ -63,6 +65,8 @@ Koha::ItemType->new(
         summary        => 'summary',
         checkinmsg     => 'checkinmsg',
         checkinmsgtype => 'checkinmsgtype',
+        processfee         => '0.00',
+        defaultreplacecost => '0.00',
     }
 )->store;
 
@@ -75,6 +79,8 @@ Koha::ItemType->new(
         summary        => 'summary',
         checkinmsg     => 'checkinmsg',
         checkinmsgtype => 'checkinmsgtype',
+        processfee         => '0.00',
+        defaultreplacecost => '0.00',
     }
 )->store;
 
@@ -161,21 +167,24 @@ subtest 'Koha::ItemType::calc_rental_charge_daily tests' => sub {
             itemtype            => 'type4',
             description         => 'description',
             rental_charge_daily => 1.00,
+            rentalcharge        => '0.00',
+            processfee          => '0.00',
+            defaultreplacecost  => '0.00',
         }
     )->store;
 
     is( $itemtype->rental_charge_daily, 1.00, 'Daily rental charge stored and retreived correctly' );
 
     my $dt_from = dt_from_string();
-    my $dt_to = dt_from_string()->add( days => 7 );
+    my $dt_to = dt_from_string()->add( days => 6 );
 
     t::lib::Mocks::mock_preference('finesCalendar', 'ignoreCalendar');
     my $charge = $itemtype->calc_rental_charge_daily( { from => $dt_from, to => $dt_to } );
-    is( $charge, 7.00, "Daily rental charge calculated correctly with finesCalendar = ignoreCalendar" );
+    is( $charge, 6.00, "Daily rental charge calculated correctly with finesCalendar = ignoreCalendar" );
 
     t::lib::Mocks::mock_preference('finesCalendar', 'noFinesWhenClosed');
     $charge = $itemtype->calc_rental_charge_daily( { from => $dt_from, to => $dt_to } );
-    is( $charge, 7.00, "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed" );
+    is( $charge, 6.00, "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed" );
 
     my $calendar = C4::Calendar->new( branchcode => $library->id );
     $calendar->insert_week_day_holiday(
@@ -184,7 +193,7 @@ subtest 'Koha::ItemType::calc_rental_charge_daily tests' => sub {
         description => 'Test holiday'
     );
     $charge = $itemtype->calc_rental_charge_daily( { from => $dt_from, to => $dt_to } );
-    is( $charge, 6.00, "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Wednesdays" );
+    is( $charge, 5.00, "Daily rental charge calculated correctly with finesCalendar = noFinesWhenClosed and closed Wednesdays" );
 
 };