Bug 18251: SCO alerts - need a trigger for successful checkouts
authorNick Clemens <nick@bywatersolutions.com>
Mon, 13 Mar 2017 14:30:42 +0000 (14:30 +0000)
committerroot <root@f1ebe1bec408>
Tue, 26 Feb 2019 13:18:28 +0000 (13:18 +0000)
This patch adds simple text and a div to allow for sounds to be
configured upon successful SCO checkout

To test:
1 - Enable sco module
2 - Enable AudioAlerts
3 - Define alert with
     Selector: .sco-alert-success
     Sound:http://localhost:8081/intranet-tmpl/prog/sound/opening.ogg
4 - Checkout to patron using SCO
5 - Note only feedback is a addition of item to checkouts list
6 - Apply patch
7 - Checkout ot patron via SCO
8 - You should hear the sound specified above
9 - You should also see a note: Item checked out

Followed test plan, works as expected.
(Works with external sound only, see Bug 16732)
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
koha-tmpl/opac-tmpl/bootstrap/en/modules/sco/sco-main.tt
opac/sco/sco-main.pl

index 2935351..048923b 100644 (file)
                         </div>
                     [% END %]
 
+                    [% IF ( issued ) %]
+                    <span class="sco-alert-success"></span>
+                    <p>Item checked out</p>
+                    [% END %]
+
 
                     [% UNLESS ( hide_main ) %]
 
index 841b59b..16e598d 100755 (executable)
@@ -223,6 +223,7 @@ elsif ( $patron and $op eq "checkout" ) {
             if ( $hold_existed ) {
                 my $dtf = Koha::Database->new->schema->storage->datetime_parser;
                 $template->param(
+                    issued => 1,
                     # If the hold existed before the check in, let's confirm that the charge line exists
                     # Note that this should not be needed but since we do not have proper exception handling here we do it this way
                     patron_has_hold_fee => Koha::Account::Lines->search(