cleanup some of value_builder MARC21 plugins

Tons of unnecessary dependencies removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>

diff --git a/cataloguing/value_builder/marc21_field_003.pl b/cataloguing/value_builder/marc21_field_003.pl
index e18b9b9..042b19f 100755 (executable)
--- a/cataloguing/value_builder/marc21_field_003.pl
+++ b/cataloguing/value_builder/marc21_field_003.pl
@@ -18,15 +18,8 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-
-use C4::Auth;
+use strict;
 use C4::Context;
-use C4::Output;
-use CGI;
-use C4::Search;
-use MARC::Record;
-use C4::Koha;
-
 
 =head1
 
@@ -34,8 +27,8 @@ plugin_parameters : other parameters added when the plugin is called by the dopo
 
 =cut
 sub plugin_parameters {
-my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
-return "";
+    # my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
+    return "";
 }
 
 =head1
@@ -53,12 +46,12 @@ the 3 scripts are inserted after the <input> in the html code
 
 =cut
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
-my $function_name= $field_number;
+    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my $function_name= $field_number;
 
-# find today's date
-my $org = C4::Context->preference('MARCOrgCode');
-my $res  = "
+    # find today's date
+    my $org = C4::Context->preference('MARCOrgCode');
+    my $res  = "
 <script type=\"text/javascript\">
 //<![CDATA[
 
@@ -76,7 +69,7 @@ function Clic$function_name(subfield_managed) {
 //]]>
 </script>
 ";
-return ($function_name,$res);
+    return ($function_name,$res);
 }
 
 =head1
@@ -86,8 +79,7 @@ plugin : the true value_builded. The screen that is open in the popup window.
 =cut
 
 sub plugin {
-my ($input) = @_;
-return "";
+    return "";
 }
 
 1;

diff --git a/cataloguing/value_builder/marc21_field_005.pl b/cataloguing/value_builder/marc21_field_005.pl
index 23308d8..ba4d2bf 100755 (executable)
--- a/cataloguing/value_builder/marc21_field_005.pl
+++ b/cataloguing/value_builder/marc21_field_005.pl
@@ -1,6 +1,5 @@
 #!/usr/bin/perl
 
-
 # Copyright 2000-2002 Katipo Communications
 #
 # This file is part of Koha.
@@ -18,24 +17,18 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-
-use C4::Auth;
+use strict;
 use C4::Context;
-use C4::Output;
-use CGI;
-use C4::Search;
-use MARC::Record;
-use C4::Koha;
-
 
 =head1
 
 plugin_parameters : other parameters added when the plugin is called by the dopop function
 
 =cut
+
 sub plugin_parameters {
-my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
-return "";
+    # my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
+    return "";
 }
 
 =head1
@@ -53,32 +46,31 @@ the 3 scripts are inserted after the <input> in the html code
 
 =cut
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
-my $function_name= $field_number;
-
-# find today's date
-my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime(time);
-$year +=1900;
-$mon +=1;
-if (length($mon)==1) {
-       $mon = "0".$mon;
-}
-if (length($mday)==1) {
-       $mday = "0".$mday;
-}
-if (length($hour)==1) {
+    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my $function_name= $field_number;
+
+    # find today's date
+    my ($sec,$min,$hour,$mday,$mon,$year,$wday,$yday,$isdst) = localtime(time);
+    $year +=1900;
+    $mon +=1;
+    if (length($mon)==1) {
+        $mon = "0".$mon;
+    }
+    if (length($mday)==1) {
+        $mday = "0".$mday;
+    }
+    if (length($hour)==1) {
         $hour = "0".$hour;
-}
-if (length($min)==1) {
+    }
+    if (length($min)==1) {
         $min = "0".$min;
-}
-if (length($sec)==1) {
+    }
+    if (length($sec)==1) {
         $hour = "0".$sec;
-}
-
+    }
 
-my $date = "$year$mon$mday$hour$min$sec".".0";
-my $res  = "
+    my $date = "$year$mon$mday$hour$min$sec".".0";
+    my $res  = "
 <script type=\"text/javascript\">
 //<![CDATA[
 
@@ -96,7 +88,7 @@ function Clic$function_name(subfield_managed) {
 //]]>
 </script>
 ";
-return ($function_name,$res);
+    return ($function_name,$res);
 }
 
 =head1
@@ -106,8 +98,7 @@ plugin : the true value_builded. The screen that is open in the popup window.
 =cut
 
 sub plugin {
-my ($input) = @_;
-return "";
+    return "";
 }
 
 1;

diff --git a/cataloguing/value_builder/marc21_field_040c.pl b/cataloguing/value_builder/marc21_field_040c.pl
index 667d0ae..6c70f84 100755 (executable)
--- a/cataloguing/value_builder/marc21_field_040c.pl
+++ b/cataloguing/value_builder/marc21_field_040c.pl
@@ -1,6 +1,5 @@
 #!/usr/bin/perl
 
-
 # Copyright 2000-2002 Katipo Communications
 #
 # This file is part of Koha.
@@ -18,29 +17,22 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-
-use C4::AuthoritiesMarc;
-use C4::Auth;
+use strict;
 use C4::Context;
-use C4::Output;
-use CGI;
-use C4::Search;
-use MARC::Record;
-use C4::Koha;
+# use MARC::Record;
 
-
-=head1
+=head1 plugin_parameters
 
 plugin_parameters : other parameters added when the plugin is called by the dopop function
 
 =cut
 
 sub plugin_parameters {
-my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
-return "";
+    # my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
+    return "";
 }
 
-=head1
+=head1 plugin_javascript
 
 plugin_javascript : the javascript function called when the user enters the subfield.
 contain 3 javascript functions :
@@ -54,13 +46,14 @@ returns :
 the 3 scripts are inserted after the <input> in the html code
 
 =cut
+
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
-my $function_name= $field_number;
+    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my $function_name= $field_number;
 
-# find today's date
-my $org = C4::Context->preference('MARCOrgCode');
-my $res  = "
+    # find today's date
+    my $org = C4::Context->preference('MARCOrgCode');
+    my $res  = "
 <script type=\"text/javascript\">
 //<![CDATA[
 
@@ -78,18 +71,17 @@ function Clic$function_name(subfield_managed) {
 //]]>
 </script>
 ";
-return ($function_name,$res);
+    return ($function_name,$res);
 }
 
-=head1
+=head1 plugin
 
 plugin : the true value_builded. The screen that is open in the popup window.
 
 =cut
 
 sub plugin {
-my ($input) = @_;
-return "";
+    return "";
 }
 
 1;

diff --git a/cataloguing/value_builder/marc21_field_040d.pl b/cataloguing/value_builder/marc21_field_040d.pl
index 667d0ae..f120c51 100755 (executable)
--- a/cataloguing/value_builder/marc21_field_040d.pl
+++ b/cataloguing/value_builder/marc21_field_040d.pl
@@ -18,16 +18,9 @@
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-
-use C4::AuthoritiesMarc;
-use C4::Auth;
+use strict;
 use C4::Context;
-use C4::Output;
-use CGI;
-use C4::Search;
-use MARC::Record;
-use C4::Koha;
-
+# use MARC::Record;
 
 =head1
 
@@ -36,8 +29,8 @@ plugin_parameters : other parameters added when the plugin is called by the dopo
 =cut
 
 sub plugin_parameters {
-my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
-return "";
+    # my ($dbh,$record,$tagslib,$i,$tabloop) = @_;
+    return "";
 }
 
 =head1
@@ -54,13 +47,14 @@ returns :
 the 3 scripts are inserted after the <input> in the html code
 
 =cut
+
 sub plugin_javascript {
-my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
-my $function_name= $field_number;
+    my ($dbh,$record,$tagslib,$field_number,$tabloop) = @_;
+    my $function_name = $field_number;
 
-# find today's date
-my $org = C4::Context->preference('MARCOrgCode');
-my $res  = "
+    # find today's date
+    my $org = C4::Context->preference('MARCOrgCode');
+    my $res  = "
 <script type=\"text/javascript\">
 //<![CDATA[
 
@@ -88,8 +82,7 @@ plugin : the true value_builded. The screen that is open in the popup window.
 =cut
 
 sub plugin {
-my ($input) = @_;
-return "";
+    return "";
 }
 
 1;