Bug 7688: (follow-up) rewrite 'for' loop in unit tests

Signed-off-by: Galen Charlton <gmc@esilibrary.com>

diff --git a/t/Serials/GetNextSeq.t b/t/Serials/GetNextSeq.t
index fe5a3d7..2f3a1c3 100644 (file)
--- a/t/Serials/GetNextSeq.t
+++ b/t/Serials/GetNextSeq.t
@@ -164,7 +164,7 @@ is($seq, 'Y: 2, X: 1');
 $seq = _next_seq($subscription, $pattern);
 is($seq, 'Y: 2, X: 2');
 # Back to the future
-for (my $i = 0; $i < 39; $i++) {
+for (1..39) {
     $seq = _next_seq($subscription, $pattern);
 }
 $seq = _next_seq($subscription, $pattern);
@@ -203,7 +203,7 @@ $seq = _next_seq($subscription, $pattern);
 is($seq, 'Z: 1, Y: 1, X: 4');
 $seq = _next_seq($subscription, $pattern);
 is($seq, 'Z: 1, Y: 2, X: 1');
-for (my $i = 0; $i < 24; $i++) {
+for (1..24) {
     $seq = _next_seq($subscription, $pattern);
 }
 $seq = _next_seq($subscription, $pattern);
@@ -214,7 +214,7 @@ $seq = _next_seq($subscription, $pattern);
 is($seq, 'Z: 1, Y: 8, X: 4');
 $seq = _next_seq($subscription, $pattern);
 is($seq, 'Z: 2, Y: 1, X: 1');
-for (my $i = 0; $i < 350; $i++) {
+for (1..350) {
     $seq = _next_seq($subscription, $pattern);
 }
 $seq = _next_seq($subscription, $pattern);

diff --git a/t/db_dependent/Serials/GetNextSeq.t b/t/db_dependent/Serials/GetNextSeq.t
index a569c77..fc6e3f2 100644 (file)
--- a/t/db_dependent/Serials/GetNextSeq.t
+++ b/t/db_dependent/Serials/GetNextSeq.t
@@ -246,7 +246,7 @@ is($seq, 'Z: 1, Y: 2, X: 3');
 $publisheddate = GetNextDate($subscription, $publisheddate);
 $seq = _next_seq($subscription, $pattern, $publisheddate);
 is($seq, 'Z: 1, Y: 2, X: 4');
-for (my $i = 0; $i < 100; $i++) {
+for (1..100) {
     $publisheddate = GetNextDate($subscription, $publisheddate);
     $seq = _next_seq($subscription, $pattern, $publisheddate);
 }