Bug 8196: FIX for Bug 5742: All extended attributes are shown when editing a patron
authorJonathan Druart <jonathan.druart@biblibre.com>
Wed, 6 Jun 2012 10:56:56 +0000 (12:56 +0200)
committerPaul Poulain <paul.poulain@biblibre.com>
Sat, 9 Jun 2012 10:37:06 +0000 (12:37 +0200)
Test scenario:

1. make sure that you have ExtendedPatronAttributes enabled
2. open /cgi-bin/koha/members/memberentry.pl?op=add;categorycode=S0
   (you might need to modify categorycode according to your local config)
3. verify that you get all extended patron attributes in form

Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
C4/Members/Attributes.pm

index b373c94..cde25d1 100644 (file)
@@ -77,12 +77,11 @@ sub GetBorrowerAttributes {
                  FROM borrower_attributes
                  JOIN borrower_attribute_types USING (code)
                  LEFT JOIN authorised_values ON (category = authorised_value_category AND attribute = authorised_value)
-                 WHERE 1";
-    $query .= "\nAND borrowernumber = ?" if $borrowernumber;
+                 WHERE borrowernumber = ?";
     $query .= "\nAND opac_display = 1" if $opac_only;
     $query .= "\nORDER BY code, attribute";
     my $sth = $dbh->prepare_cached($query);
-    $sth->execute($borrowernumber ? $borrowernumber : ());
+    $sth->execute($borrowernumber);
     my @results = ();
     while (my $row = $sth->fetchrow_hashref()) {
         push @results, {