Bug 6521 Follow up: previous patch breaks autoMemberNum functionality
authorIan Walls <ian.walls@bywatersolutions.com>
Wed, 20 Jul 2011 17:11:12 +0000 (13:11 -0400)
committerChris Cormack <chrisc@catalyst.net.nz>
Sun, 31 Jul 2011 23:31:27 +0000 (11:31 +1200)
The previous patch broke the autoMemberNum feature by adding a line to fixup_cardnumber
that returned 'undef' for cardnumber in all usages of the subroutine (limited to members/memberentry.pl
and tools/import_borrowers.pl.  This prevented the automatic number from being calculated in all cases.

This patch removes the offending line.

Signed-off-by: Ian Walls <ian.walls@bywatersolutions.com>
Signed-off-by: Nicole Engard <nengard@bywatersolutions.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
C4/Members.pm

index c6c6985..4970735 100644 (file)
@@ -900,7 +900,6 @@ sub fixup_cardnumber ($) {
 
     #     if ($cardnumber !~ /\S/ && $autonumber_members) {
     ($autonumber_members) or return $cardnumber;
-    defined($cardnumber) or return $cardnumber;
     my $checkdigit = C4::Context->preference('checkdigit');
     my $dbh = C4::Context->dbh;
     if ( $checkdigit and $checkdigit eq 'katipo' ) {