Bug 9695 - Use alphabet system preference on page used to browse patrons for patron...

When adding patrons to a batch for creating patron cards, the template
shows alphabet links for browsing all patrons. This patch converts the
hard-coded alphabet links to use the new alphabet system preference.

To test, go to the patron card creator and create a new batch. Click
"Add items" to pop up the window for browsing for patrons to add to the
batch. You should see a working array of alphabet letters which link to
patron search results.

Signed-off-by: David Cook <dcook@prosentient.com.au>
The patch adds consistency to the interface and works as described.
Signed-off-by: Jonathan Druarth <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/members-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/members-search.tt
index f34c2bd..c3a1df7 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/members-search.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/patroncards/members-search.tt
@@ -49,32 +49,9 @@ function add_item(borrowernum,batch_id,type_id){
 
 <div class="browse">
     Browse by last name:
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=a&amp;batch_id=[% batch_id %]">A</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=b&amp;batch_id=[% batch_id %]">B</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=c&amp;batch_id=[% batch_id %]">C</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=d&amp;batch_id=[% batch_id %]">D</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=e&amp;batch_id=[% batch_id %]">E</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=f&amp;batch_id=[% batch_id %]">F</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=g&amp;batch_id=[% batch_id %]">G</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=h&amp;batch_id=[% batch_id %]">H</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=i&amp;batch_id=[% batch_id %]">I</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=j&amp;batch_id=[% batch_id %]">J</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=k&amp;batch_id=[% batch_id %]">K</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=l&amp;batch_id=[% batch_id %]">L</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=m&amp;batch_id=[% batch_id %]">M</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=n&amp;batch_id=[% batch_id %]">N</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=o&amp;batch_id=[% batch_id %]">O</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=p&amp;batch_id=[% batch_id %]">P</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=q&amp;batch_id=[% batch_id %]">Q</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=r&amp;batch_id=[% batch_id %]">R</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=s&amp;batch_id=[% batch_id %]">S</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=t&amp;batch_id=[% batch_id %]">T</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=u&amp;batch_id=[% batch_id %]">U</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=v&amp;batch_id=[% batch_id %]">V</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=w&amp;batch_id=[% batch_id %]">W</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=x&amp;batch_id=[% batch_id %]">X</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=y&amp;batch_id=[% batch_id %]">Y</a>
-    <a href="/cgi-bin/koha/patroncards/members-search.pl?member=z&amp;batch_id=[% batch_id %]">Z</a>
+    [% FOREACH letter IN alphabet.split(' ') %]
+        <a href="/cgi-bin/koha/patroncards/members-search.pl?member=[% letter %]&amp;batch_id=[% batch_id %]">[% letter %]</a>
+    [% END %]
 </div>
 
 <form method="get" action="/cgi-bin/koha/patroncards/members-search.pl"><p>

diff --git a/patroncards/members-search.pl b/patroncards/members-search.pl
index 6c27095..ef7a776 100755 (executable)
--- a/patroncards/members-search.pl
+++ b/patroncards/members-search.pl
@@ -122,6 +122,8 @@ else {
     $template->param( batch_id => $batch_id);
 }
 
+$template->param( 'alphabet' => C4::Context->preference('alphabet') || join ' ', 'A' .. 'Z' );
+
 output_html_with_http_headers $cgi, $cookie, $template->output;
 
 __END__