bug 2505: turned on warnings for suggestion/acceptorreject.pl

Also fixed case where HTML could have unclosed <form> elements,
leading to warnings in the error log when accepting pending
or rejected suggestions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/acceptorreject.tmpl b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/acceptorreject.tmpl
index 4b426fd..50e4c53 100644 (file)
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/acceptorreject.tmpl
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/acceptorreject.tmpl
@@ -236,6 +236,7 @@
     <!--TMPL_IF EXPR="suggestiontype eq 'rejected'"-->
     <b>No rejected suggestions.</b>
     <!--/TMPL_IF-->  
+</form>
 <!-- /TMPL_IF -->
 
 </div>
@@ -245,6 +246,4 @@
 </div></div>
 
 </div>
-</div>
-</div>
-<!-- TMPL_INCLUDE NAME="intranet-bottom.inc" -->
\ No newline at end of file
+<!-- TMPL_INCLUDE NAME="intranet-bottom.inc" -->

diff --git a/suggestion/acceptorreject.pl b/suggestion/acceptorreject.pl
index 5100334..cbc0b98 100755 (executable)
--- a/suggestion/acceptorreject.pl
+++ b/suggestion/acceptorreject.pl
@@ -65,6 +65,7 @@ op can be :
 =cut
 
 use strict;
+use warnings;
 
 use CGI;
 
@@ -139,7 +140,6 @@ if ( $op eq "aorr_confirm" ) {
     $op = "else";
     if (scalar(@deletelist)>0){  
         my $params = "&delete_field=".join ("&delete_field=",@deletelist);
-        warn $params;    
         print $input->redirect("/cgi-bin/koha/suggestion/acceptorreject.pl?op=delete_confirm$params");
     }  
 }