r1397@llin: dpavlin | 2007-10-31 01:38:40 +0100

 never ever call dump unless working with debug
 (20% improvement in speed of record processing :-)

git-svn-id: svn+ssh://mjesec/home/dpavlin/svn/webpac2/trunk@925 07558da8-63fa-0310-ba24-9fe276d99e06

diff --git a/lib/WebPAC/Output/JSON.pm b/lib/WebPAC/Output/JSON.pm
index d412448..049d679 100644 (file)
--- a/lib/WebPAC/Output/JSON.pm
+++ b/lib/WebPAC/Output/JSON.pm
@@ -79,7 +79,7 @@ sub add {
        $log->logdie("need id") unless defined $id;
        $log->logdie("need ds") unless $ds;
 
-       $log->debug("id: $id ds = ",dump($ds));
+       $log->debug("id: $id ds = ",sub { dump($ds) });
 
        push @{ $self->{_data} }, $self->ds_to_hash( $ds, 'display' );
 

diff --git a/lib/WebPAC/Output/KinoSearch.pm b/lib/WebPAC/Output/KinoSearch.pm
index 8349550..cb48b06 100644 (file)
--- a/lib/WebPAC/Output/KinoSearch.pm
+++ b/lib/WebPAC/Output/KinoSearch.pm
@@ -132,7 +132,7 @@ sub add {
        $log->logdie("need id") unless defined $id;
        $log->logdie("need ds") unless $ds;
 
-       $log->debug("id: $id ds = ",dump($ds));
+       $log->debug("id: $id ds = ", sub { dump($ds) });
 
        my $hash = $self->ds_to_hash( $ds, 'search' ) || return;
 

diff --git a/lib/WebPAC/Output/Sorted.pm b/lib/WebPAC/Output/Sorted.pm
index 63d90b2..69cbf61 100644 (file)
--- a/lib/WebPAC/Output/Sorted.pm
+++ b/lib/WebPAC/Output/Sorted.pm
@@ -81,7 +81,7 @@ sub add {
        $log->logdie("need id") unless defined $id;
        $log->logdie("need ds") unless $ds;
 
-       $log->debug("id: $id ds = ",dump($ds));
+       $log->debug("id: $id ds = ",sub { dump($ds) });
 
        my $hash = $self->ds_to_hash( $ds, 'sorted' ) || return;