koha.git
15 years agofix the sql request to work in all mysqls
Nahuel Angelinetti [Thu, 4 Dec 2008 15:45:30 +0000 (16:45 +0100)]
fix the sql request to work in all mysqls

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoLibraries (branches) should be sorted by branchname.
Joe Atzberger [Tue, 30 Dec 2008 19:50:15 +0000 (13:50 -0600)]
Libraries (branches) should be sorted by branchname.

The display sorted by code, resulting in nonsensical order
for the users, who don't know or see the codes.  Note,
this data should come from GetBranchesLoop, when that
function is availabled (from a separate patch).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAllow all argument forms to GetBranchesLoops.
Joe Atzberger [Tue, 30 Dec 2008 19:42:10 +0000 (13:42 -0600)]
Allow all argument forms to GetBranchesLoops.

Allow arguments to be specified in the negative (i.e. 0).
Allow function to be called with no arguments.

This supercedes the patch titled:
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAllow GetBranchesLoop to intuit IndependantBranches if not specified in argument.
Joe Atzberger [Thu, 18 Dec 2008 03:35:21 +0000 (21:35 -0600)]
Allow GetBranchesLoop to intuit IndependantBranches if not specified in argument.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd GetBranchLoop since so many pages use exactly the same code.
Joe Atzberger [Thu, 30 Oct 2008 05:07:40 +0000 (00:07 -0500)]
Add GetBranchLoop since so many pages use exactly the same code.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agocatalogue_out report cleanup.
Joe Atzberger [Thu, 18 Dec 2008 03:36:05 +0000 (21:36 -0600)]
catalogue_out report cleanup.

Warnings enabled, comparison adjusted to accomodate undef.
Hardcoded CGI::scrolling_list removed.
Sort order on item types corrected.  Unused dependencies commented out.
GetBranchesLoop used instead of copy/paste code.

NOTE: CSV output is not fixed by this patch.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years ago(bug #2811)[3.2] fix opac-renew.pl part
Nahuel ANGELINETTI [Wed, 7 Jan 2009 13:33:23 +0000 (14:33 +0100)]
(bug #2811)[3.2] fix opac-renew.pl part

This patch only fix a "security" failure that permit a user to renew his loan using directly the opac-renew.pl url.
Now, we check that opacrenewalallowed is set to on to permit the renewal in opac.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAddReserve had bogus prepare statement.
Joe Atzberger [Tue, 13 Jan 2009 23:11:06 +0000 (17:11 -0600)]
AddReserve had bogus prepare statement.

This patch was not fully tested because the actual behavior intended
by constraints 'o' and 'e' was apparently never implemented here.
But it had no chance of success as with:
    my $sth = $dbh->prepare("");

This uses the inteneded query, removes unneeded $sth->finish calls and
fixes *some* redeclaration of my $variables in the same scope, as
would be needed to run under warnings pragma.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2904: fix display of URLs in UNIMARC
Galen Charlton [Fri, 6 Mar 2009 18:17:39 +0000 (12:17 -0600)]
bug 2904: fix display of URLs in UNIMARC

This based on a patch by Nahuel ANGELINETTI; done to
merge changes with Mason's patch for 2951.  The original
patch description is:

in the previous patch the field used for link "name" was 856$z, but the unimarc doesn't specify this, it say to use the 856$2 fi
This patch make koha to use the 856$2."

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agocorrected patch for bug 2951
Mason James [Thu, 12 Feb 2009 23:15:57 +0000 (12:15 +1300)]
corrected patch for bug 2951

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMarkup and style corrections.
Owen Leonard [Thu, 5 Mar 2009 20:37:49 +0000 (14:37 -0600)]
Markup and style corrections.

Corrects case of "onclick" and creates new style for "send" link rather than re-using inapplicable toolbar ID.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2772: bad image location
Nahuel Angelinetti [Mon, 10 Nov 2008 16:16:16 +0000 (17:16 +0100)]
bug 2772: bad image location

This patch make Page.pm to use the getitemtypeinfo function to generate the imageurl, and check (in the template) if an
image is set.
Before this patch, always the "Alt" information was shown, because the url wasn't right.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agotweak Inventory tool and sub in C4/Items so call number min and max are not required
Michael Hafen [Tue, 3 Feb 2009 23:46:25 +0000 (16:46 -0700)]
tweak Inventory tool and sub in C4/Items so call number min and max are not required

This changes the setting if default values in the inventory tool where
the min and max call number are concerned.  Also changes how the query
is formed in C4/Items so that these two are not required.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2883 - longoverdue cronjob fails to implement required functionality.
Joe Atzberger [Mon, 29 Dec 2008 16:51:45 +0000 (10:51 -0600)]
Bug 2883 - longoverdue cronjob fails to implement required functionality.

This does not fix all problems recorded in 2883 (see all the FIXME's), but
it does improve the script's basic feedback to an intelligible level.
It also adjusts the documentation and examples to correct bogus usage
instructions.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAllow LDAP test to bail if LDAP disabled.
Joe Atzberger [Fri, 23 Jan 2009 17:57:57 +0000 (11:57 -0600)]
Allow LDAP test to bail if LDAP disabled.

Also added more feedback and the ability to override KOHA_CONF
"useldapserver" value with ENV variable KOHA_USELDAPSERVER.

This patch should be considered for inclusion to 3.0 stable branch
because it prevents unnecessary failure of test battery.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoKohabug 2500 Fiction Call Number Splitting Enhancement/Bugfix
Chris Nighswonger [Thu, 26 Feb 2009 20:43:35 +0000 (15:43 -0500)]
Kohabug 2500 Fiction Call Number Splitting Enhancement/Bugfix

The current regexp used to split fiction call numbers does not handle the '.' char well. This patch corrects the regexp so that it behaves as expected.

This patch should be ported to the 3.0.x branch.

[fbcbug 5]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdding Copy Number column to table of item information on holds pages.
Owen Leonard [Thu, 26 Feb 2009 19:39:54 +0000 (13:39 -0600)]
Adding Copy Number column to table of item information on holds pages.

Fixes Bug 2753, Hold screen needs to show copy number.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2924 fixed rebuild_zebra.pl to work when export is skipped
Brian Harrington [Mon, 2 Mar 2009 21:08:13 +0000 (16:08 -0500)]
bug 2924 fixed rebuild_zebra.pl to work when export is skipped

reindexing now occurs if there are $num_records_exported or if
$skip_export is set

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agochanges to OPAC results and detail XSLT
Galen Charlton [Wed, 11 Feb 2009 23:01:01 +0000 (17:01 -0600)]
changes to OPAC results and detail XSLT

Various changes to OPAC search results and bib
detail display for MARC21.

* Search results

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a, displayed under author
[3] New other title field from 246$a$b, displayed under call number

* Bib details

[1] 245 subfields will be displayed in order $a, $b, $h, then
    rest of subfields in the order they appear in the record.
[2] New edition field from 250$a$b, displayed under publisher
[3] New description field from 300$a$b$c$e$g, under the edition.
[4] New other title field from the 246$i$a$b$h$f$g$n$p, above the
    uniform title field.
[6] All 6XX fields are displayed in the subjects field.
[7] '--' now separates subdivisions in subject headings.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoConsistency check between Makefile.pl and about.pl We weren't picking up JSOM so...
Andrew Elwell [Sun, 22 Feb 2009 13:53:08 +0000 (14:53 +0100)]
Consistency check between Makefile.pl and about.pl We weren't picking up JSOM so admin/item_circulation_alerts.pl gave a 500 internal server error if JOSM not installed.

 Also sorted packages.debian alphabetically so that we can maintain
 easier.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpgrade jquery dimensions plugin. Correction to Cart js to match.
Owen Leonard [Thu, 26 Feb 2009 20:14:36 +0000 (14:14 -0600)]
Upgrade jquery dimensions plugin. Correction to Cart js to match.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 1546 - REPLACE statements
John Beppu [Thu, 26 Feb 2009 19:19:28 +0000 (13:19 -0600)]
bug 1546 - REPLACE statements

A REPLACE statement in tools/letter.pl was indirectly corrupting data
in the message_transports table.  It has been replaced with code that
does an UPDATE or INSERT depending on whether the row existed or not.

Also, to protect data in the message_transports table further, letters
which have entries in the message_transports table are no longer
deletable.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFix for Bug 2984, Error when generating CSV output from "Generate labels for Batch...
Owen Leonard [Wed, 25 Feb 2009 21:17:15 +0000 (15:17 -0600)]
Fix for Bug 2984, Error when generating CSV output from "Generate labels for Batch" button

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdd option to inventory tool to ignore copies on loan
Michael Hafen [Tue, 24 Feb 2009 19:05:50 +0000 (12:05 -0700)]
Add option to inventory tool to ignore copies on loan

This adds an option to the inventory tool causing it to ignore copies
currently on loan.  This is good if you want to do inventory, but don't
want to update the date-last-seen on items currently on loan.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoChanges to improve keyboard access to global search box tabs.
Owen Leonard [Tue, 10 Feb 2009 20:45:36 +0000 (14:45 -0600)]
Changes to improve keyboard access to global search box tabs.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMoved several etch packages from cpan install to the packages.debian.
Andrew Elwell [Mon, 9 Feb 2009 21:30:53 +0000 (22:30 +0100)]
Moved several etch packages from cpan install to the packages.debian.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCorrecting title of link to admin/itemtypes.pl from "Item types and circulationcodes...
Owen Leonard [Tue, 10 Feb 2009 20:45:47 +0000 (14:45 -0600)]
Correcting title of link to admin/itemtypes.pl from "Item types and circulationcodes" to just "Item types." Ccodes are authorized values.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoadd some search indexes to opac advanced search that are on quick search
Michael Hafen [Mon, 2 Feb 2009 23:24:53 +0000 (16:24 -0700)]
add some search indexes to opac advanced search that are on quick search

This adds ISBN and Call Number, which are in the quick search index
list, but are not in the advanced search index lists.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoreduce bib fetches during search and OPAC display
Galen Charlton [Tue, 10 Feb 2009 22:38:11 +0000 (16:38 -0600)]
reduce bib fetches during search and OPAC display

Speed up bib search and OPAC bib display, especially
when the XSLT OPAC results and details display sysprefs are
ON, by passing an existing MARC::Record object to three
functions:

C4::Biblio::get_biblio_authorised_values()
C4::XSLT::XSLTParse4Display()
C4::XSLT::transformMARCXML4XSLT (internal)

These functions previously fetched the bib from the
database, incurring the cost of DB retrieval and MARCXML
parsing even though client code already had a
MARC::Record object available.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAdded empty item call number test to copies for reserve; added ending punctuation...
Daniel Sweeney [Wed, 4 Feb 2009 16:46:25 +0000 (10:46 -0600)]
Added empty item call number test to copies for reserve; added ending punctuation to availability statuses.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFixes to two issues with status display on OPAC:
Joshua Ferraro [Wed, 4 Feb 2009 16:46:24 +0000 (10:46 -0600)]
Fixes to two issues with status display on OPAC:

1. rather than testing for notforloan == -1, test for any negative values to set the On order status
2. in cases where itemcallnumber is blank or null, don't display the itemcallnumber brackets []

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoDisplays the itemcallnumber in brackets next to location in XSL Results
Joshua Ferraro [Wed, 4 Feb 2009 16:46:21 +0000 (10:46 -0600)]
Displays the itemcallnumber in brackets next to location in XSL Results

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoDistinguish between items marked 'not for loan' and 'Available'
Joshua Ferraro [Wed, 4 Feb 2009 16:46:23 +0000 (10:46 -0600)]
Distinguish between items marked 'not for loan' and 'Available'

This patch works with XSL* sysprefs == ON, a future patch will address XSL sysprefs==OFF

Items with notforloan set to a negative number still designate an 'ordered' status

Some items are marked 'not for loan' by setting that value at the item level, others by assigning
that value to that item's itemtype. This patch works for both scenarios.

Specific changes this patch introduces to the OPAC:

* Adds a new OPAC results page key 'Copies available for reference:'
* Changes 'Copies available at:' to 'Copies available for loan:'
* Changes the availability limit label in opac-advsearch from:
    'Only items currently available' to 'Only items currently
available for loan or reference
* Displays the authorised value for the specific notforloan value in the OPAC detail page in
parentheses next to 'Not for Loan'

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoAvoid XSLT stylesheet building for each biblio record to transform
Frederic Demians [Thu, 5 Feb 2009 07:26:13 +0000 (08:26 +0100)]
Avoid XSLT stylesheet building for each biblio record to transform

In XSLT.pm, put XSLT stylesheet object in a session variable in order
to avoid to build it for each biblio to parse: useful on search
result page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoUpdated INSTALL.debian and debian.packages for new dependencies
J. David Bavousett [Thu, 5 Feb 2009 21:27:30 +0000 (15:27 -0600)]
Updated INSTALL.debian and debian.packages for new dependencies

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoNew C4 Modules
John Beppu [Tue, 3 Feb 2009 22:02:03 +0000 (16:02 -0600)]
New C4 Modules

* C4::Category
  - patron categories as objects
  - an all() method to return all the categories as a list
* C4::ItemType
  - itemtypes as objects
  - an all() method to return all the item types as a list
* C4::ItemCirculationAlertPreference
  - wrapper around the item_circulation_alert_preference table
  - create() and delete() methods for easy manipulation of the preferences
  - I regret giving it such a long name.
  - The item_type column should've been named itemtype to make it
    more similar to pre-existing tables.  Oh well.

(C4::Category and C4::ItemType were made so that I wouldn't have to
write SQL inside my CGI scripts.
Their main purpose is to provide an easy way to get a list of
patron categories and item types.
Do not be fooled by the amount of POD.
There's actually very little code in these modules.)

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoShowing totals for charges and replacement costs on patron detail screen and print...
Owen Leonard [Tue, 3 Feb 2009 20:59:55 +0000 (14:59 -0600)]
Showing totals for charges and replacement costs on patron detail screen and print view.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoMove opaclanguagesdisplay to I18N/L10N tab where opaclanguages pref is.
Owen Leonard [Tue, 3 Feb 2009 21:00:06 +0000 (15:00 -0600)]
Move opaclanguagesdisplay to I18N/L10N tab where opaclanguages pref is.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2870, fixes non-populating of guarantor fields
Mason James [Wed, 28 Jan 2009 12:28:52 +0000 (01:28 +1300)]
bug 2870, fixes non-populating of guarantor fields

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleanup and perltidy.
Joe Atzberger [Wed, 28 Jan 2009 19:25:48 +0000 (13:25 -0600)]
Cleanup and perltidy.

Add "use warnings", remove unused variables and unnecessary finish/disconnect
at the end.  This script could be improved to run only on tables that need to
be altered instead of touching all of them.  It should also probably contain
warnings to the effect that it does not rescue your DATA that was forced into
whatever encoding the table used previously.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoObsolete harness for tests, replaced by make and other test structures.
Joe Atzberger [Wed, 28 Jan 2009 19:39:43 +0000 (13:39 -0600)]
Obsolete harness for tests, replaced by make and other test structures.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofollowup to holds policies - fix itype
Galen Charlton [Thu, 15 Jan 2009 21:26:18 +0000 (15:26 -0600)]
followup to holds policies - fix itype

Overriding items.itype from biblioitems.itemtype
is needed only with item-level_itypes is OFF.

[LL bug 321]

Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com>
Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRelated to earlier patch: adding body id to add flexibility to CSS customizations.
Owen Leonard [Fri, 9 Jan 2009 02:03:53 +0000 (20:03 -0600)]
Related to earlier patch: adding body id to add flexibility to CSS customizations.

This patch adds a different id to opac-shelves, opac-suggestions, and opac-tags based on whether or not the user is logged in, allowing for changes to style based on logged-in status.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agofix permission error introduced in a previous patch
Galen Charlton [Wed, 7 Jan 2009 03:03:40 +0000 (21:03 -0600)]
fix permission error introduced in a previous patch

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoA few more tweaks to the OPAC detail view menu
Owen Leonard [Wed, 31 Dec 2008 20:28:27 +0000 (14:28 -0600)]
A few more tweaks to the OPAC detail view menu

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoFormatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug...
Owen Leonard [Tue, 21 Oct 2008 16:13:36 +0000 (11:13 -0500)]
Formatting changes for OPAC xslt and staff client catalog detail pages. Fixes Bug 2704, 440 Display Issues.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoremove disused script admin/letter.pl
Galen Charlton [Wed, 31 Dec 2008 16:28:03 +0000 (10:28 -0600)]
remove disused script admin/letter.pl

Was moved to tools/letter.pl in 2006, but old
(and nonfunctional) version was left in place.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoremoving *.old files
Galen Charlton [Wed, 31 Dec 2008 16:23:34 +0000 (10:23 -0600)]
removing *.old files

Don't need to do this when modifying a script --
this is what Git is for.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoRemoving ':' from table headers.
Stan Brinkerhoff [Wed, 24 Dec 2008 12:13:16 +0000 (07:13 -0500)]
Removing ':' from table headers.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2856 followup: remove unconditional warn
Galen Charlton [Mon, 29 Dec 2008 19:53:11 +0000 (13:53 -0600)]
bug 2856 followup: remove unconditional warn

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoTest suite: C4::Members::GetMember
Allen Reinmeyer [Wed, 24 Dec 2008 22:09:50 +0000 (16:09 -0600)]
Test suite: C4::Members::GetMember

Tests the functionality of C4::Members::GetMember.  Tests exist
for every way that GetMember could be called on to search for an
existing member.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoBug 2868: fixing typo in NoZebraIndexes setting in sysprefs
Andrew Moore [Wed, 17 Dec 2008 21:13:49 +0000 (15:13 -0600)]
Bug 2868: fixing typo in NoZebraIndexes setting in sysprefs

There was a missing ' in the value of the NoZebraIndexes syspref. This
patch fixes it.

It's not necessary to fix the existing settings because
C4::Biblio::GetNoZebraIndexes is liberal enough to be able to parse even
the deformed value.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agowhitespace cleanup - admin/systempreferences.pl
Galen Charlton [Wed, 17 Dec 2008 15:53:40 +0000 (09:53 -0600)]
whitespace cleanup - admin/systempreferences.pl

applied xt/perltidyrc to admin/systempreferences.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agobug 2860: allow setting of a syspref value to '0'
Galen Charlton [Wed, 17 Dec 2008 15:53:39 +0000 (09:53 -0600)]
bug 2860: allow setting of a syspref value to '0'

Fixed invalid test for the existence of CGI parameter; if it
is possible that the value of a parameter can be 0, it is
not sufficient to test like this:

if ($input->param('foo')) { ...

since the test will fail for *any* value that evaluates
to Perl false.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: turn on warnings in admin/systemprefernces.pl
Galen Charlton [Wed, 17 Dec 2008 15:53:38 +0000 (09:53 -0600)]
bug 2505: turn on warnings in admin/systemprefernces.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2867 [1/2]: Move basic editing to main system preferences screen
Jesse Weaver [Wed, 17 Dec 2008 15:53:37 +0000 (09:53 -0600)]
bug 2867 [1/2]: Move basic editing to main system preferences screen

This allows the user to edit system preferences from the main system
preferences screen, rather than having to dig down into each
preference.

[This patch includes some modifications by Galen Charlton
 to fix XHTML validation errors and a couple errors that
 would crop up under warnings.]

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2505: enable warnings for opac/sco/sco-main.pl
Galen Charlton [Mon, 8 Dec 2008 14:45:39 +0000 (08:45 -0600)]
bug 2505: enable warnings for opac/sco/sco-main.pl

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoMinor cleanup, unused variable removed.
Joe Atzberger [Mon, 8 Dec 2008 17:42:47 +0000 (11:42 -0600)]
Minor cleanup, unused variable removed.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2857: fix UTF-8 conversion issues in web services
Galen Charlton [Wed, 10 Dec 2008 20:02:17 +0000 (14:02 -0600)]
bug 2857: fix UTF-8 conversion issues in web services

svc/bib and svc/new_bib had two problems related to UTF-8 character conversion:

[1] Couple instances of "Wide character" warnings
[2] When saving a new (MARC21) bib whose Leader/09 was not 'a', did not apply
default character conversion and set the Leader/09 to 'a'.

Fix includes two parts:

[1] Setting :utf8 on STDOUT
[2] Doing default MARC-8 to UTF-8 conversion if applicable

This patch also turns on warnings in all scripts under svc per bug 2505.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agobug 2613: allow web self-check to accept patron ID
Galen Charlton [Fri, 5 Dec 2008 23:17:02 +0000 (17:17 -0600)]
bug 2613: allow web self-check to accept patron ID

Use 'patronid' instead of 'userid' as the query parameter
for passing the patron userid or barcode around; 'userid'
is claimed by C4::Auth and should be used only for
authentication pages.

Fixes the problem where entering a patron's card
number would cause a redirect to the OPAC login
page.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoTweaks to display of "views" tabs (MARC, ISBD, etc).
Owen Leonard [Wed, 26 Nov 2008 20:45:58 +0000 (14:45 -0600)]
Tweaks to display of "views" tabs (MARC, ISBD, etc).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoTweaks to display of "views" tabs (MARC, ISBD, etc).
Owen Leonard [Wed, 26 Nov 2008 20:45:58 +0000 (14:45 -0600)]
Tweaks to display of "views" tabs (MARC, ISBD, etc).

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoCleaning up Self-Checkout interface, adding some basic formatting based on other...
Owen Leonard [Wed, 26 Nov 2008 20:46:07 +0000 (14:46 -0600)]
Cleaning up Self-Checkout interface, adding some basic formatting based on other standard styles.

Patch also removes a hard-coded English string from the script and some unused functions from sco.js.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoremove superfluous retrieval of $ENV{'REMOTE_USER'}
Galen Charlton [Fri, 5 Dec 2008 17:09:32 +0000 (11:09 -0600)]
remove superfluous retrieval of $ENV{'REMOTE_USER'}

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoSome minor markup corrections to opac authorities pages. Some fixes to address Bug...
Owen Leonard [Tue, 7 Oct 2008 18:51:07 +0000 (13:51 -0500)]
Some minor markup corrections to opac authorities pages. Some fixes to address Bug 2620.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoRemove hardcoded "Freelist" line from Auth.
Joe Atzberger [Tue, 30 Sep 2008 22:00:40 +0000 (17:00 -0500)]
Remove hardcoded "Freelist" line from Auth.

Apparently a leftover debugging snippet.

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
15 years agoFixing a couple of bugs in the package
Chris Cormack [Sun, 10 Aug 2008 06:50:47 +0000 (18:50 +1200)]
Fixing a couple of bugs in the package

Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
15 years agoGreek, Croatian, Portuguese and Turkish updates
Chris Cormack [Tue, 26 May 2009 02:42:11 +0000 (14:42 +1200)]
Greek, Croatian, Portuguese and Turkish updates

15 years agoFrench Canadia, Greek, Dari and Turkish updates
Chris Cormack [Sun, 24 May 2009 05:22:45 +0000 (17:22 +1200)]
French Canadia, Greek, Dari and Turkish updates

15 years agoTurkish and dari updates
Chris Cormack [Fri, 22 May 2009 09:13:24 +0000 (21:13 +1200)]
Turkish and dari updates

15 years agoTurkish and Greek updates
Chris Cormack [Thu, 21 May 2009 10:01:06 +0000 (22:01 +1200)]
Turkish and Greek updates

15 years agoGreek, french canadian, and Turkish updates
Chris Cormack [Tue, 19 May 2009 21:47:22 +0000 (09:47 +1200)]
Greek, french canadian, and Turkish updates

15 years agoGreek, French (canada), Slovak, Turkish and Tetun updates
Chris Cormack [Tue, 19 May 2009 09:01:05 +0000 (21:01 +1200)]
Greek, French (canada), Slovak, Turkish and Tetun updates

15 years agoMore updates
Chris Cormack [Mon, 18 May 2009 14:49:42 +0000 (02:49 +1200)]
More updates

15 years agoMore language updates
Chris Cormack [Mon, 18 May 2009 11:01:19 +0000 (23:01 +1200)]
More language updates

15 years agoArabic and german updates
Chris Cormack [Mon, 18 May 2009 09:41:12 +0000 (21:41 +1200)]
Arabic and german updates

15 years agoUpdated strings for 3.0.2 release
Chris Cormack [Mon, 18 May 2009 09:22:58 +0000 (21:22 +1200)]
Updated strings for 3.0.2 release

15 years agoSlovak opac update
Chris Cormack [Sun, 17 May 2009 10:01:32 +0000 (22:01 +1200)]
Slovak opac update

15 years agoLots of language updates
Chris Cormack [Sun, 17 May 2009 09:51:01 +0000 (21:51 +1200)]
Lots of language updates

15 years agoSlovak translations
Chris Cormack [Sun, 17 May 2009 09:50:37 +0000 (21:50 +1200)]
Slovak translations

15 years agoUpdated po files for 3.0.2 release
Chris Cormack [Sat, 9 May 2009 11:19:30 +0000 (23:19 +1200)]
Updated po files for 3.0.2 release

15 years agoTetun intranet updates
Chris Cormack [Thu, 7 May 2009 08:39:42 +0000 (20:39 +1200)]
Tetun intranet updates

15 years agoGerman OPAC update
Chris Cormack [Thu, 7 May 2009 08:38:16 +0000 (20:38 +1200)]
German OPAC update

15 years agoChinese (Taiwan) Intranet and OPAC updates
Chris Cormack [Thu, 7 May 2009 08:37:32 +0000 (20:37 +1200)]
Chinese (Taiwan) Intranet and OPAC updates

15 years agoTetun language updates
Chris Cormack [Sat, 2 May 2009 21:45:15 +0000 (09:45 +1200)]
Tetun language updates

15 years agoUpdating French Canadian intranet adding US english Academic
Chris Cormack [Sat, 2 May 2009 20:37:36 +0000 (08:37 +1200)]
Updating French Canadian intranet adding US english Academic

15 years agoDutch opac updates
Chris Cormack [Sat, 25 Apr 2009 19:37:27 +0000 (07:37 +1200)]
Dutch opac updates

15 years agoGerman opac updates
Chris Cormack [Sat, 25 Apr 2009 19:34:46 +0000 (07:34 +1200)]
German opac updates

15 years agoTetun opac updates
Chris Cormack [Sat, 25 Apr 2009 03:51:16 +0000 (15:51 +1200)]
Tetun opac updates

15 years agoPortuguese opac and intranet updates
Chris Cormack [Sat, 25 Apr 2009 03:50:52 +0000 (15:50 +1200)]
Portuguese opac and intranet updates

15 years agoTetun staff interface updates
Chris Cormack [Fri, 24 Apr 2009 03:34:35 +0000 (15:34 +1200)]
Tetun staff interface updates

15 years agoTetun and French canadian update
Chris Cormack [Sat, 18 Apr 2009 14:46:17 +0000 (02:46 +1200)]
Tetun and French canadian update

15 years agoTetun intranet updates
Chris Cormack [Mon, 13 Apr 2009 05:54:36 +0000 (17:54 +1200)]
Tetun intranet updates

15 years agoTetun Intranet
Chris Cormack [Fri, 10 Apr 2009 06:05:19 +0000 (18:05 +1200)]
Tetun Intranet

15 years agoTetun Opac
Chris Cormack [Fri, 10 Apr 2009 06:02:44 +0000 (18:02 +1200)]
Tetun Opac

15 years agoGerman Intranet and Brazilian Portuguese Intranet updates
Chris Cormack [Fri, 10 Apr 2009 06:01:51 +0000 (18:01 +1200)]
German Intranet and Brazilian Portuguese Intranet updates

15 years agoBrazilian Portuguese Opac updates
Chris Cormack [Mon, 6 Apr 2009 07:04:53 +0000 (19:04 +1200)]
Brazilian Portuguese Opac updates

15 years agoCatalan opac updates
Chris Cormack [Mon, 6 Apr 2009 06:55:01 +0000 (18:55 +1200)]
Catalan opac updates

15 years agoStarting Brazilian Portuguese translations
Chris Cormack [Sat, 4 Apr 2009 19:57:11 +0000 (07:57 +1200)]
Starting Brazilian Portuguese translations

15 years agoPashto opac and intranet
Chris Cormack [Tue, 31 Mar 2009 09:12:25 +0000 (22:12 +1300)]
Pashto opac and intranet